Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-management

.github/CODEOWNERS

@@ -868,12 +868,15 @@ x-pack/platform/plugins/private/runtime_fields @elastic/kibana-management
 x-pack/platform/plugins/private/snapshot_restore @elastic/kibana-management
 x-pack/platform/plugins/private/transform @elastic/ml-ui
 x-pack/platform/plugins/private/translations @elastic/kibana-localization
+x-pack/platform/plugins/private/upgrade_assistant @elastic/kibana-management
 x-pack/platform/plugins/private/watcher @elastic/kibana-management
 x-pack/platform/plugins/shared/ai_infra/llm_tasks @elastic/appex-ai-infra
 x-pack/platform/plugins/shared/ai_infra/product_doc_base @elastic/appex-ai-infra
 x-pack/platform/plugins/shared/aiops @elastic/ml-ui
 x-pack/platform/plugins/shared/entity_manager @elastic/obs-entities
+x-pack/platform/plugins/shared/index_management @elastic/kibana-management
 x-pack/platform/plugins/shared/inference @elastic/appex-ai-infra
+x-pack/platform/plugins/shared/ingest_pipelines @elastic/kibana-management
 x-pack/platform/plugins/shared/integration_assistant @elastic/security-scalability
 x-pack/platform/plugins/shared/license_management @elastic/kibana-management
 x-pack/platform/plugins/shared/ml @elastic/ml-ui
@@ -910,8 +913,6 @@ x-pack/plugins/global_search @elastic/appex-sharedux
 x-pack/plugins/global_search_bar @elastic/appex-sharedux
 x-pack/plugins/global_search_providers @elastic/appex-sharedux
 x-pack/plugins/graph @elastic/kibana-visualizations
-x-pack/plugins/index_management @elastic/kibana-management
-x-pack/plugins/ingest_pipelines @elastic/kibana-management
 x-pack/plugins/kubernetes_security @elastic/kibana-cloud-security-posture
 x-pack/plugins/lens @elastic/kibana-visualizations
 x-pack/plugins/licensing @elastic/kibana-core
@@ -964,7 +965,6 @@ x-pack/plugins/stack_connectors @elastic/response-ops
 x-pack/plugins/task_manager @elastic/response-ops
 x-pack/plugins/telemetry_collection_xpack @elastic/kibana-core
 x-pack/plugins/triggers_actions_ui @elastic/response-ops
-x-pack/plugins/upgrade_assistant @elastic/kibana-management
 x-pack/solutions/observability/packages/alert_details @elastic/obs-ux-management-team
 x-pack/solutions/observability/packages/alerting_test_data @elastic/obs-ux-management-team
 x-pack/solutions/observability/packages/get_padded_alert_time_range_util @elastic/obs-ux-management-team

docs/developer/plugin-list.asciidoc

@@ -639,7 +639,7 @@ which are particularly useful for ingesting logs.
 Index Management by running this series of requests in Console:
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/index_management/README.md[indexManagement]
+|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/index_management/README.md[indexManagement]
 |This service is exposed from the Index Management setup contract and can be used to add content to the indices list and the index details page.
 
 
@@ -653,7 +653,7 @@ external LLM APIs. Its goals are:
 the infrastructure monitoring use-case within Kibana.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/ingest_pipelines/README.md[ingestPipelines]
+|{kib-repo}blob/{branch}/x-pack/platform/plugins/shared/ingest_pipelines/README.md[ingestPipelines]
 |The ingest_pipelines plugin provides Kibana support for Elasticsearch's ingest pipelines.
 
 
@@ -960,7 +960,7 @@ For adding localizations and instrument a ui to support translated content, see
 As a developer you can reuse and extend built-in alerts and actions UI functionality:
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/upgrade_assistant/README.md[upgradeAssistant]
+|{kib-repo}blob/{branch}/x-pack/platform/plugins/private/upgrade_assistant/README.md[upgradeAssistant]
 |Upgrade Assistant helps users prepare their Stack for being upgraded to the next version of the Elastic stack.
 
 

package.json

@@ -575,15 +575,15 @@
     "@kbn/index-adapter": "link:x-pack/solutions/security/packages/index-adapter",
     "@kbn/index-lifecycle-management-common-shared": "link:x-pack/platform/packages/shared/index-lifecycle-management/index_lifecycle_management_common_shared",
     "@kbn/index-lifecycle-management-plugin": "link:x-pack/platform/plugins/private/index_lifecycle_management",
-    "@kbn/index-management-plugin": "link:x-pack/plugins/index_management",
+    "@kbn/index-management-plugin": "link:x-pack/platform/plugins/shared/index_management",
     "@kbn/index-management-shared-types": "link:x-pack/platform/packages/shared/index-management/index_management_shared_types",
     "@kbn/index-patterns-test-plugin": "link:test/plugin_functional/plugins/index_patterns",
     "@kbn/inference-common": "link:x-pack/platform/packages/shared/ai-infra/inference-common",
     "@kbn/inference-plugin": "link:x-pack/platform/plugins/shared/inference",
     "@kbn/inference_integration_flyout": "link:x-pack/platform/packages/private/ml/inference_integration_flyout",
     "@kbn/infra-forge": "link:x-pack/platform/packages/private/kbn-infra-forge",
     "@kbn/infra-plugin": "link:x-pack/plugins/observability_solution/infra",
-    "@kbn/ingest-pipelines-plugin": "link:x-pack/plugins/ingest_pipelines",
+    "@kbn/ingest-pipelines-plugin": "link:x-pack/platform/plugins/shared/ingest_pipelines",
     "@kbn/input-control-vis-plugin": "link:src/plugins/input_control_vis",
     "@kbn/inspector-plugin": "link:src/plugins/inspector",
     "@kbn/integration-assistant-plugin": "link:x-pack/platform/plugins/shared/integration_assistant",
@@ -994,7 +994,7 @@
     "@kbn/unified-search-plugin": "link:src/plugins/unified_search",
     "@kbn/unsaved-changes-badge": "link:packages/kbn-unsaved-changes-badge",
     "@kbn/unsaved-changes-prompt": "link:src/platform/packages/shared/kbn-unsaved-changes-prompt",
-    "@kbn/upgrade-assistant-plugin": "link:x-pack/plugins/upgrade_assistant",
+    "@kbn/upgrade-assistant-plugin": "link:x-pack/platform/plugins/private/upgrade_assistant",
     "@kbn/uptime-plugin": "link:x-pack/solutions/observability/plugins/uptime",
     "@kbn/url-drilldown-plugin": "link:x-pack/plugins/drilldowns/url_drilldown",
     "@kbn/url-forwarding-plugin": "link:src/plugins/url_forwarding",

src/dev/precommit_hook/casing_check_config.js

@@ -164,7 +164,7 @@ export const TEMPORARILY_IGNORED_PATHS = [
   'src/core/server/core_app/assets/favicons/mstile-310x310.png',
   'src/core/server/core_app/assets/favicons/safari-pinned-tab.svg',
   'test/functional/apps/management/exports/_import_objects-conflicts.json',
-  'x-pack/legacy/plugins/index_management/public/lib/editSettings.js',
+  'x-pack/legacy/platform/plugins/shared/index_management/public/lib/editSettings.js',
   'x-pack/legacy/platform/plugins/shared/license_management/public/store/reducers/licenseManagement.js',
   'x-pack/plugins/monitoring/public/icons/health-gray.svg',
   'x-pack/plugins/monitoring/public/icons/health-green.svg',

tsconfig.base.json

@@ -1056,8 +1056,8 @@
       "@kbn/index-lifecycle-management-common-shared/*": ["x-pack/platform/packages/shared/index-lifecycle-management/index_lifecycle_management_common_shared/*"],
       "@kbn/index-lifecycle-management-plugin": ["x-pack/platform/plugins/private/index_lifecycle_management"],
       "@kbn/index-lifecycle-management-plugin/*": ["x-pack/platform/plugins/private/index_lifecycle_management/*"],
-      "@kbn/index-management-plugin": ["x-pack/plugins/index_management"],
-      "@kbn/index-management-plugin/*": ["x-pack/plugins/index_management/*"],
+      "@kbn/index-management-plugin": ["x-pack/platform/plugins/shared/index_management"],
+      "@kbn/index-management-plugin/*": ["x-pack/platform/plugins/shared/index_management/*"],
       "@kbn/index-management-shared-types": ["x-pack/platform/packages/shared/index-management/index_management_shared_types"],
       "@kbn/index-management-shared-types/*": ["x-pack/platform/packages/shared/index-management/index_management_shared_types/*"],
       "@kbn/index-patterns-test-plugin": ["test/plugin_functional/plugins/index_patterns"],
@@ -1072,8 +1072,8 @@
       "@kbn/infra-forge/*": ["x-pack/platform/packages/private/kbn-infra-forge/*"],
       "@kbn/infra-plugin": ["x-pack/plugins/observability_solution/infra"],
       "@kbn/infra-plugin/*": ["x-pack/plugins/observability_solution/infra/*"],
-      "@kbn/ingest-pipelines-plugin": ["x-pack/plugins/ingest_pipelines"],
-      "@kbn/ingest-pipelines-plugin/*": ["x-pack/plugins/ingest_pipelines/*"],
+      "@kbn/ingest-pipelines-plugin": ["x-pack/platform/plugins/shared/ingest_pipelines"],
+      "@kbn/ingest-pipelines-plugin/*": ["x-pack/platform/plugins/shared/ingest_pipelines/*"],
       "@kbn/input-control-vis-plugin": ["src/plugins/input_control_vis"],
       "@kbn/input-control-vis-plugin/*": ["src/plugins/input_control_vis/*"],
       "@kbn/inspector-plugin": ["src/plugins/inspector"],
@@ -2000,8 +2000,8 @@
       "@kbn/unsaved-changes-badge/*": ["packages/kbn-unsaved-changes-badge/*"],
       "@kbn/unsaved-changes-prompt": ["src/platform/packages/shared/kbn-unsaved-changes-prompt"],
       "@kbn/unsaved-changes-prompt/*": ["src/platform/packages/shared/kbn-unsaved-changes-prompt/*"],
-      "@kbn/upgrade-assistant-plugin": ["x-pack/plugins/upgrade_assistant"],
-      "@kbn/upgrade-assistant-plugin/*": ["x-pack/plugins/upgrade_assistant/*"],
+      "@kbn/upgrade-assistant-plugin": ["x-pack/platform/plugins/private/upgrade_assistant"],
+      "@kbn/upgrade-assistant-plugin/*": ["x-pack/platform/plugins/private/upgrade_assistant/*"],
       "@kbn/uptime-plugin": ["x-pack/solutions/observability/plugins/uptime"],
       "@kbn/uptime-plugin/*": ["x-pack/solutions/observability/plugins/uptime/*"],
       "@kbn/url-drilldown-plugin": ["x-pack/plugins/drilldowns/url_drilldown"],

x-pack/.i18nrc.json

@@ -56,15 +56,15 @@
       "plugins/graph"
     ],
     "xpack.grokDebugger": "platform/plugins/private/grokdebugger",
-    "xpack.idxMgmt": "plugins/index_management",
+    "xpack.idxMgmt": "platform/plugins/shared/index_management",
     "xpack.idxMgmtPackage": "packages/index-management",
     "xpack.indexLifecycleMgmt": "platform/plugins/private/index_lifecycle_management",
     "xpack.infra": "plugins/observability_solution/infra",
     "xpack.logsDataAccess": "plugins/observability_solution/logs_data_access",
     "xpack.logsExplorer": "plugins/observability_solution/logs_explorer",
     "xpack.logsShared": "plugins/observability_solution/logs_shared",
     "xpack.fleet": "plugins/fleet",
-    "xpack.ingestPipelines": "plugins/ingest_pipelines",
+    "xpack.ingestPipelines": "platform/plugins/shared/ingest_pipelines",
     "xpack.integrationAssistant": "platform/plugins/shared/integration_assistant",
     "xpack.inference": "platform/plugins/shared/inference",
     "xpack.inventory": "plugins/observability_solution/inventory",
@@ -164,7 +164,7 @@
     "xpack.timelines": "solutions/security/plugins/timelines",
     "xpack.transform": "platform/plugins/private/transform",
     "xpack.triggersActionsUI": "plugins/triggers_actions_ui",
-    "xpack.upgradeAssistant": "plugins/upgrade_assistant",
+    "xpack.upgradeAssistant": "platform/plugins/private/upgrade_assistant",
     "xpack.uptime": [
       "solutions/observability/plugins/uptime"
     ],

x-pack/platform/plugins/private/transform/common/types/es_ingest_pipeline.ts

@@ -7,7 +7,7 @@
 
 // This interface doesn't cover a full ingest pipeline spec,
 // just what's necessary to make it work in the transform creation wizard.
-// The full interface can be found in x-pack/plugins/ingest_pipelines/common/types.ts
+// The full interface can be found in x-pack/platform/plugins/shared/ingest_pipelines/common/types.ts
 export interface EsIngestPipeline {
   name: string;
 }

x-pack/plugins/upgrade_assistant/README.md → x-pack/platform/plugins/private/upgrade_assistant/README.md

@@ -16,7 +16,7 @@ Some features of the UA are only needed when upgrading to a new major version. T
 When we want to enable ML model snapshot deprecation warnings again we need to change the constant `MachineLearningField.MIN_CHECKED_SUPPORTED_SNAPSHOT_VERSION` to something higher than 7.0.0 in the Elasticsearch code.
 * Migrating system indices (`featureSet.migrateSystemIndices`): Migrating system indices should only be enabled for major version upgrades. This config hides the second step from the UA UI for migrating system indices.
 * Reindex Data Streams (`featureSet.migrateDataStreams`): Migrating deprecated Data streams should only be enabled for major version upgrades. The purpose of this feature guard is to hide all data streams related deprecations from the end user until the next major upgrade.
-* Reindex corrective actions (`featureSet.reindexCorrectiveActions`): Deprecations with reindexing corrective actions are only enabled for major version upgrades. Currently, the reindex actions include some logic that is specific to the [8.0 upgrade](https://github.com/elastic/kibana/blob/main/x-pack/plugins/upgrade_assistant/server/lib/reindexing/index_settings.ts). End users could get into a bad situation if this is enabled before this logic is fixed.
+* Reindex corrective actions (`featureSet.reindexCorrectiveActions`): Deprecations with reindexing corrective actions are only enabled for major version upgrades. Currently, the reindex actions include some logic that is specific to the [8.0 upgrade](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/private/upgrade_assistant/server/lib/reindexing/index_settings.ts). End users could get into a bad situation if this is enabled before this logic is fixed.
 
 ## Deprecations
 
@@ -38,7 +38,7 @@ deprecations are discovered as data is migrated. Starting in 7.x, deprecation lo
 Elasticsearch deprecations can be handled in a number of ways:
 
 * **Reindexing.** When a user's index contains deprecations (e.g. mappings) a reindex solves them. The Upgrade Assistant only automates reindexing for indices. For example, if you are currently on 7.x, and want to migrate to 8.0, but you still have indices that were created on 6.x. For this scenario, the user will see a "Reindex" button that they can click, which will perform the reindex.
-  * Reindexing is an idempotent action in Upgrade Assistant. It works like this ([overview in code](https://github.com/elastic/kibana/blob/b320a37d8b703b2fa101a93b6971b36ee2c37f06/x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts#L498-L540)):
+  * Reindexing is an idempotent action in Upgrade Assistant. It works like this ([overview in code](https://github.com/elastic/kibana/blob/b320a37d8b703b2fa101a93b6971b36ee2c37f06/x-pack/platform/plugins/private/upgrade_assistant/server/lib/reindexing/reindex_service.ts#L498-L540)):
     1. Set a write-block on the original index, no new data can be written during reindexing.
     2. Create a target index with the following name `reindexed-v{majorVersion}-{originalIndex}`. E.g., if `my-index` is the original, the target will be named `reindexed-v8-my-index`.
     3. [Reindex](https://www.elastic.co/guide/en/elasticsearch/reference/master/docs-reindex.html) from the original index to the target index. Kibana will continuously report reindexing status.
@@ -51,7 +51,7 @@ Elasticsearch deprecations can be handled in a number of ways:
 
     Currently reindexing deprecations are only enabled for major version upgrades  by setting the config `featureSet.reindexCorrectiveActions` to `true` on the `x.last` version of the stack.
 
-Reindexing at the moment includes some logic that is specific to the [8.0 upgrade](https://github.com/elastic/kibana/blob/main/x-pack/plugins/upgrade_assistant/server/lib/reindexing/index_settings.ts). End users could get into a bad situation if this is enabled before this logic is fixed.
+Reindexing at the moment includes some logic that is specific to the [8.0 upgrade](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/private/upgrade_assistant/server/lib/reindexing/index_settings.ts). End users could get into a bad situation if this is enabled before this logic is fixed.
 * **Removing settings.** Some index and cluser settings are deprecated and need to be removed. The Upgrade Assistant provides a way to auto-resolve these settings via a "Remove deprecated settings" button. Migrating system indices should only be enabled for major version upgrades. This is controlled by the config `featureSet.migrateSystemIndices` which hides the second step from the UA UI for migrating system indices.
 * **Upgrading or deleting snapshots**. This is specific to Machine Learning. If a user has old Machine Learning job model snapshots, they will need to be upgraded or deleted. The Upgrade Assistant provides a way to resolve this automatically for the user ([#100066](https://github.com/elastic/kibana/pull/100066)).
 Deprecations related to ML snapshots are only enabled during `x.last` version of the stack. This is controlled by the `featureSet.mlSnapshots` config. When we want to enable ML model snapshot deprecation warnings again we need to change the constant `MachineLearningField.MIN_CHECKED_SUPPORTED_SNAPSHOT_VERSION` to something higher than `7.0.0` in the Elasticsearch code.
@@ -334,8 +334,8 @@ For a complete list of Kibana deprecations, refer to the [8.0 Kibana deprecation
 
 This is a non-exhaustive list of different error scenarios in Upgrade Assistant. It's recommended to use the [tweak browser extension](https://chrome.google.com/webstore/detail/tweak-mock-api-calls/feahianecghpnipmhphmfgmpdodhcapi?hl=en), or something similar, to mock the API calls.
 
-- **Error loading deprecation logging status.** Mock a `404` status code to `GET /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/545c1420c285af8f5eee56f414bd6eca735aea11/x-pack/plugins/upgrade_assistant/public/application/lib/api.ts#L70) locally and replace `deprecation_logging` with `fake_deprecation_logging`.
-- **Error updating deprecation logging status.** Mock a `404` status code to `PUT /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/545c1420c285af8f5eee56f414bd6eca735aea11/x-pack/plugins/upgrade_assistant/public/application/lib/api.ts#L77) locally and replace `deprecation_logging` with `fake_deprecation_logging`.
+- **Error loading deprecation logging status.** Mock a `404` status code to `GET /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/545c1420c285af8f5eee56f414bd6eca735aea11/x-pack/platform/plugins/private/upgrade_assistant/public/application/lib/api.ts#L70) locally and replace `deprecation_logging` with `fake_deprecation_logging`.
+- **Error updating deprecation logging status.** Mock a `404` status code to `PUT /api/upgrade_assistant/deprecation_logging`. Alternatively, edit [this line](https://github.com/elastic/kibana/blob/545c1420c285af8f5eee56f414bd6eca735aea11/x-pack/platform/plugins/private/upgrade_assistant/public/application/lib/api.ts#L77) locally and replace `deprecation_logging` with `fake_deprecation_logging`.
 - **Unauthorized error fetching ES deprecations.** Mock a `403` status code to `GET /api/upgrade_assistant/es_deprecations` with the response payload: `{ "statusCode": 403 }`
 - **Partially upgraded error fetching ES deprecations.** Mock a `426` status code to `GET /api/upgrade_assistant/es_deprecations` with the response payload: `{ "statusCode": 426, "attributes": { "allNodesUpgraded": false } }`
 - **Upgraded error fetching ES deprecations.** Mock a `426` status code to `GET /api/upgrade_assistant/es_deprecations` with the response payload: `{ "statusCode": 426, "attributes": { "allNodesUpgraded": true } }`

x-pack/plugins/ingest_pipelines/jest.config.js → x-pack/platform/plugins/private/upgrade_assistant/jest.config.js

@@ -7,11 +7,12 @@
 
 module.exports = {
   preset: '@kbn/test',
-  rootDir: '../../..',
-  roots: ['<rootDir>/x-pack/plugins/ingest_pipelines'],
-  coverageDirectory: '<rootDir>/target/kibana-coverage/jest/x-pack/plugins/ingest_pipelines',
+  rootDir: '../../../../..',
+  roots: ['<rootDir>/x-pack/platform/plugins/private/upgrade_assistant'],
+  coverageDirectory:
+    '<rootDir>/target/kibana-coverage/jest/x-pack/platform/plugins/private/upgrade_assistant',
   coverageReporters: ['text', 'html'],
   collectCoverageFrom: [
-    '<rootDir>/x-pack/plugins/ingest_pipelines/{common,public,server}/**/*.{ts,tsx}',
+    '<rootDir>/x-pack/platform/plugins/private/upgrade_assistant/{common,public,server}/**/*.{ts,tsx}',
   ],
 };

x-pack/plugins/upgrade_assistant/tsconfig.json → x-pack/platform/plugins/private/upgrade_assistant/tsconfig.json

@@ -1,10 +1,10 @@
 {
-  "extends": "../../../tsconfig.base.json",
+  "extends": "../../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "target/types",
   },
   "include": [
-    "../../../typings/**/*",
+    "../../../../../typings/**/*",
     "__jest__/**/*",
     "common/**/*",
     "public/**/*",