Skip to content

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-management#202736

Closed
gsoldevila wants to merge 5 commits intoelastic:mainfrom
gsoldevila:kbn-team-1309-move-kibana-management
Closed

Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-management#202736
gsoldevila wants to merge 5 commits intoelastic:mainfrom
gsoldevila:kbn-team-1309-move-kibana-management

Conversation

@gsoldevila
Copy link
Copy Markdown
Member

@gsoldevila gsoldevila commented Dec 3, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

3 plugin(s) are going to be relocated:

Id Target folder
@kbn/index-management-plugin x-pack/platform/plugins/shared/index_management
@kbn/ingest-pipelines-plugin x-pack/platform/plugins/shared/ingest_pipelines
@kbn/upgrade-assistant-plugin x-pack/platform/plugins/private/upgrade_assistant
Updated references
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/dev/precommit_hook/casing_check_config.js
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/platform/plugins/private/transform/common/types/es_ingest_pipeline.ts
./x-pack/platform/plugins/private/upgrade_assistant/README.md
./x-pack/platform/plugins/private/upgrade_assistant/jest.config.js
./x-pack/platform/plugins/shared/index_management/README.md
./x-pack/platform/plugins/shared/index_management/jest.config.js
./x-pack/platform/plugins/shared/ingest_pipelines/jest.config.js
./yarn.lock
.github/CODEOWNERS
Updated relative paths
x-pack/platform/plugins/private/upgrade_assistant/jest.config.js:10
x-pack/platform/plugins/private/upgrade_assistant/tsconfig.json:2
x-pack/platform/plugins/private/upgrade_assistant/tsconfig.json:7
x-pack/platform/plugins/shared/index_management/jest.config.js:10
x-pack/platform/plugins/shared/index_management/tsconfig.json:12
x-pack/platform/plugins/shared/index_management/tsconfig.json:2
x-pack/platform/plugins/shared/ingest_pipelines/jest.config.js:10
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.json:11
x-pack/platform/plugins/shared/ingest_pipelines/tsconfig.json:2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@gsoldevila gsoldevila added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Dec 3, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 3, 2024 14:40
@gsoldevila gsoldevila requested review from a team as code owners December 3, 2024 14:40
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCSS files only

@gsoldevila gsoldevila added backport:skip This PR does not require backporting and removed backport:prev-minor labels Dec 4, 2024
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-management branch from 7c62cd7 to bdd2a23 Compare December 4, 2024 22:03
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-management branch from 35c50aa to 6795e9f Compare December 5, 2024 18:28
@mattkime
Copy link
Copy Markdown
Contributor

mattkime commented Dec 8, 2024

@gsoldevila At first glance this PR appears to be too disruptive. There are already a lot of merge conflicts plus this hasn't accounted for any work that's in progress. My initial impression is that a change like this would be best managed by the team to minimize disruption.

@gsoldevila
Copy link
Copy Markdown
Member Author

@gsoldevila At first glance this PR appears to be too disruptive. There are already a lot of merge conflicts plus this hasn't accounted for any work that's in progress. My initial impression is that a change like this would be best managed by the team to minimise disruption.

Well, I imagine there's never a good time to perform such a big restructuring, but here we are 😆.
On my side, I have a script that did all this automatically, I can easily run it again from latest main to pickup latest changes, but ideally I would like to coordinate with @elastic/kibana-management to run it at the right time.
I have fixed a couple of bugs in the script, so I'm confident that CI will be green for this one next time I run it.

When do you think we could do this? FWIW our goal is to have this merged before 9.0, and also backported to 8.x.

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-management branch from 3da2d76 to 706b385 Compare December 9, 2024 09:43
@mattkime
Copy link
Copy Markdown
Contributor

@gsoldevila Lets split this up, we should be able to get this through really quick -

All 17 packages

All plugins EXCEPT @kbn/index-management-plugin and @kbn/ingest-pipelines-plugin which are currently being worked on.

Then we'll follow up on those two plugins before too long.

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-management branch from 1ae027c to 1a893bb Compare December 16, 2024 11:00
@gsoldevila gsoldevila requested a review from a team as a code owner December 16, 2024 11:00
@gsoldevila gsoldevila removed the request for review from a team December 16, 2024 11:03
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit to transform file LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless AI Assistant - Security Solution Cypress Tests / AI Assistant Conversations Changing conversations Correctly creates and titles new conversations, and allows title updates Correctly creates and titles new conversations, and allows title updates
  • [job] [logs] AI Assistant - Security Solution Cypress Tests / AI Assistant Conversations Changing conversations Correctly creates and titles new conversations, and allows title updates Correctly creates and titles new conversations, and allows title updates
  • [job] [logs] FTR Configs #66 / Entity Manager _count API is resilient to no valid sources
  • [job] [logs] FTR Configs #67 / lens serverless - group 1 - subgroup 6 lens logsdb smoke testing functions support Scenarios with changing stream type LogsDB downgraded to regular data stream scenarios LogsDB stream with no additional stream/index and no host.name field should visualize an annotation layer from a logsDB stream
  • [job] [logs] Jest Tests #12 / useMonitorStatusData handles resize events and requests based on new data

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
indexManagement 3 2 -1

Total ESLint disabled count

id before after diff
indexManagement 19 18 -1

History

  • 💔 Build #258125 failed 1ae027c3599f02edbeb0d1f8d79a3733db4a8e0a
  • 💔 Build #258113 failed 678c80f09d9b3d7edd754f2e8b36625949025176
  • 💔 Build #257620 failed 3da2d76bc7cfbd5918b4f6fa9dfb0120d3ad1561
  • 💔 Build #257153 failed 35c50aaf5aaf037e64e42db59759ada33eef3cff

Copy link
Copy Markdown
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

@rudolf rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Dec 18, 2024
@gsoldevila
Copy link
Copy Markdown
Member Author

gsoldevila commented Dec 30, 2024

This PR has been split up in multiple relocation PRs (e.g. this one), and all of the involved modules have already been relocated.

@gsoldevila gsoldevila closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting plugin groups Relocate all plugins and packages under their respective platform/solution groups release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.