[Dataset Quality] Fix tests for degraded fields flyout#202288
Merged
tonyghiani merged 3 commits intoelastic:mainfrom Dec 2, 2024
Merged
[Dataset Quality] Fix tests for degraded fields flyout#202288tonyghiani merged 3 commits intoelastic:mainfrom
tonyghiani merged 3 commits intoelastic:mainfrom
Conversation
tonyghiani
added
Team:obs-onboarding
Contributor
|
I think this is a good solution give we never know when these components are going to be available so increasing timeouts wouldn't work. |
Contributor
Author
Some tests also rely on changes on the UI components which might not be immediate, I would leave those retries as they are since I don't know which ones are fixing previous issues. If the element is already there, the retry won't wait for the whole time anyway. |
mohamedhamed-ahmed
approved these changes
Nov 29, 2024
Contributor
mohamedhamed-ahmed
left a comment
mohamedhamed-ahmed
left a comment
There was a problem hiding this comment.
Changes LGTM! Thank you 🚀
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7537[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 50/50 tests passed. |
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12118005054 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
## 📓 Summary Closes elastic#198849 Closes elastic#200287 Closes elastic#201273 Closes elastic#201975 The above issues were raised with similar conditions which converged in the following assumptions: - They are raised due to timeout identifying a visual element on the degraded fields flyout. - They are raised due to a missing UI element, which is part of a common sub-tree conditionally rendered when the data analysis is completed. - They are raised in serverless tests, where the latency might be randomly higher. Given the nature of these tests, which locally always pass correctly given the fastest nature of a local setup, I assume these random failures are due to latency on the common request gating the rendering of these sections. As a fix, I added a wait on the global loading indicator before the assertions, which should wait for the data loading to be completed before running the assertions on the UI elements. Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> (cherry picked from commit d13904e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
#202432) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Fix tests for degraded fields flyout (#202288)](#202288) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T11:04:48Z","message":"[Dataset Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓 Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273 \r\nCloses #201975 \r\n\r\nThe above issues were raised with similar conditions which converged in\r\nthe following assumptions:\r\n- They are raised due to timeout identifying a visual element on the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI element, which is part of a common\r\nsub-tree conditionally rendered when the data analysis is completed.\r\n- They are raised in serverless tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the nature of these tests, which locally always pass correctly\r\ngiven the fastest nature of a local setup, I assume these random\r\nfailures are due to latency on the common request gating the rendering\r\nof these sections.\r\n\r\nAs a fix, I added a wait on the global loading indicator before the\r\nassertions, which should wait for the data loading to be completed\r\nbefore running the assertions on the UI elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[Dataset Quality] Fix tests for degraded fields flyout","number":202288,"url":"https://github.com/elastic/kibana/pull/202288","mergeCommit":{"message":"[Dataset Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓 Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273 \r\nCloses #201975 \r\n\r\nThe above issues were raised with similar conditions which converged in\r\nthe following assumptions:\r\n- They are raised due to timeout identifying a visual element on the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI element, which is part of a common\r\nsub-tree conditionally rendered when the data analysis is completed.\r\n- They are raised in serverless tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the nature of these tests, which locally always pass correctly\r\ngiven the fastest nature of a local setup, I assume these random\r\nfailures are due to latency on the common request gating the rendering\r\nof these sections.\r\n\r\nAs a fix, I added a wait on the global loading indicator before the\r\nassertions, which should wait for the data loading to be completed\r\nbefore running the assertions on the UI elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202288","number":202288,"mergeCommit":{"message":"[Dataset Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓 Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273 \r\nCloses #201975 \r\n\r\nThe above issues were raised with similar conditions which converged in\r\nthe following assumptions:\r\n- They are raised due to timeout identifying a visual element on the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI element, which is part of a common\r\nsub-tree conditionally rendered when the data analysis is completed.\r\n- They are raised in serverless tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the nature of these tests, which locally always pass correctly\r\ngiven the fastest nature of a local setup, I assume these random\r\nfailures are due to latency on the common request gating the rendering\r\nof these sections.\r\n\r\nAs a fix, I added a wait on the global loading indicator before the\r\nassertions, which should wait for the data loading to be completed\r\nbefore running the assertions on the UI elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## 📓 Summary Closes elastic#198849 Closes elastic#200287 Closes elastic#201273 Closes elastic#201975 The above issues were raised with similar conditions which converged in the following assumptions: - They are raised due to timeout identifying a visual element on the degraded fields flyout. - They are raised due to a missing UI element, which is part of a common sub-tree conditionally rendered when the data analysis is completed. - They are raised in serverless tests, where the latency might be randomly higher. Given the nature of these tests, which locally always pass correctly given the fastest nature of a local setup, I assume these random failures are due to latency on the common request gating the rendering of these sections. As a fix, I added a wait on the global loading indicator before the assertions, which should wait for the data loading to be completed before running the assertions on the UI elements. Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #198849
Closes #200287
Closes #201273
Closes #201975
The above issues were raised with similar conditions which converged in the following assumptions:
Given the nature of these tests, which locally always pass correctly given the fastest nature of a local setup, I assume these random failures are due to latency on the common request gating the rendering of these sections.
As a fix, I added a wait on the global loading indicator before the assertions, which should wait for the data loading to be completed before running the assertions on the UI elements.