Skip to content

[SecuritySolution] Onboarding page centralize duplicated styles#202229

Merged
semd merged 3 commits intoelastic:mainfrom
semd:onboarding_hub/centralize_styles
Nov 29, 2024
Merged

[SecuritySolution] Onboarding page centralize duplicated styles#202229
semd merged 3 commits intoelastic:mainfrom
semd:onboarding_hub/centralize_styles

Conversation

@semd
Copy link
Copy Markdown
Contributor

@semd semd commented Nov 28, 2024

Summary

There is no visual change, just a refactor to remove duplicate code from cards to centralized places.

@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore backport:version Backport to applied version labels v8.18.0 labels Nov 28, 2024
@semd semd self-assigned this Nov 28, 2024
@semd semd requested a review from a team as a code owner November 28, 2024 19:16
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

Copy link
Copy Markdown
Contributor

@agusruidiazgd agusruidiazgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@semd semd enabled auto-merge (squash) November 29, 2024 09:44
@semd semd disabled auto-merge November 29, 2024 09:44
@semd semd enabled auto-merge (squash) November 29, 2024 16:18
@semd semd disabled auto-merge November 29, 2024 17:16
@semd semd enabled auto-merge (squash) November 29, 2024 17:36
@semd semd merged commit 89d4011 into elastic:main Nov 29, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12088870148

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6295 6297 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.6MB 14.6MB +1.2KB

History

cc @semd

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [SIEM migrations][Onboarding] Add support for topics in the onboarding page (#201411)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202229

Questions ?

Please refer to the Backport tool documentation

semd added a commit to semd/kibana that referenced this pull request Nov 30, 2024
…tic#202229)

## Summary

There is no visual change, just a refactor to remove duplicate code from
cards to centralized places.

(cherry picked from commit 89d4011)
@semd
Copy link
Copy Markdown
Contributor Author

semd commented Nov 30, 2024

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

semd added a commit that referenced this pull request Dec 2, 2024
…#202229) (#202384)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution] Onboarding page centralize duplicated styles
(#202229)](#202229)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2024-11-29T17:47:16Z","message":"[SecuritySolution]
Onboarding page centralize duplicated styles (#202229)\n\n##
Summary\r\n\r\nThere is no visual change, just a refactor to remove
duplicate code from\r\ncards to centralized
places.","sha":"89d40117640e19ce93128b3b35190ff3f7138302","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting","Team:Threat
Hunting:Explore","backport:version","v8.18.0"],"number":202229,"url":"https://github.com/elastic/kibana/pull/202229","mergeCommit":{"message":"[SecuritySolution]
Onboarding page centralize duplicated styles (#202229)\n\n##
Summary\r\n\r\nThere is no visual change, just a refactor to remove
duplicate code from\r\ncards to centralized
places.","sha":"89d40117640e19ce93128b3b35190ff3f7138302"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202229","number":202229,"mergeCommit":{"message":"[SecuritySolution]
Onboarding page centralize duplicated styles (#202229)\n\n##
Summary\r\n\r\nThere is no visual change, just a refactor to remove
duplicate code from\r\ncards to centralized
places.","sha":"89d40117640e19ce93128b3b35190ff3f7138302"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…tic#202229)

## Summary

There is no visual change, just a refactor to remove duplicate code from
cards to centralized places.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants