Skip to content

[Inventory][ECO] Entity type Remove Control groups filter#202177

Merged
cauemarcondes merged 8 commits intoelastic:mainfrom
cauemarcondes:inventory-remove-control-groups
Dec 2, 2024
Merged

[Inventory][ECO] Entity type Remove Control groups filter#202177
cauemarcondes merged 8 commits intoelastic:mainfrom
cauemarcondes:inventory-remove-control-groups

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Nov 28, 2024 •
edited by kibanamachine
Loading

closes #201584

  • Removes control group entity types filter
  • Adds multi-select entity types filer
  • Add kuery to url
  • Remove unified entities page
  • Adding telemetry when entity type is filtered
  • Refactoring...
Screen.Recording.2024-11-28.at.13.52.48.mov

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor v8.18.0 labels Nov 28, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner November 28, 2024 14:00
@cauemarcondes cauemarcondes requested a review from a team November 28, 2024 14:00
@cauemarcondes cauemarcondes requested a review from a team as a code owner November 28, 2024 14:00
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Nov 28, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 28, 2024

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes changed the title Inventory remove control groups [Inventory][ECO] Entity type Remove Control groups filter Nov 28, 2024
@cauemarcondes cauemarcondes mentioned this pull request Nov 28, 2024
Closed
iblancof
iblancof reviewed Nov 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@iblancof iblancof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reviewing the code, I wondered how telemetry was adjusted for the entity type filter. After some investigation, I noticed the reportEntityInventoryEntityTypeFiltered event was removed in #199174. When was this decision made?

AFAIK the data was being used in this dashboard. Is the dashboard owner aware of the recent changes (and the ones this PR will introduce)?

@cauemarcondes @iblancof
Update x-pack/plugins/observability_solution/inventory/public/compone…
07cab76 
…nts/badge_filter_with_popover/index.tsx

Co-authored-by: Irene Blanco <irene.blanco@elastic.co>
@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Nov 28, 2024

While reviewing the code, I wondered how telemetry was adjusted for the entity type filter. After some investigation, I noticed the reportEntityInventoryEntityTypeFiltered event was removed in #199174. When was this decision made?

When we migrated to use the Control group field.

AFAIK the data was being used in this dashboard. Is the dashboard owner aware of the recent changes (and the ones this PR will introduce)?

@roshan-elastic was aware of the removal of the telemetry on the other PR. And now he'll be aware of the new telemetry on the entity types filter. 😆

crespocarlos
crespocarlos approved these changes Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tonyghiani
tonyghiani approved these changes Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synthtrace change LGTM, code review only

@jennypavlova jennypavlova self-requested a review November 29, 2024 10:56
jennypavlova
jennypavlova approved these changes Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes cauemarcondes enabled auto-merge (squash) November 29, 2024 13:02
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 1, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 285 256 -29

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 236.6KB 234.0KB -2.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
inventory 12.4KB 12.6KB +178.0B

History

@cauemarcondes cauemarcondes merged commit d8f3f4c into elastic:main Dec 2, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 2, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12116160148

@cauemarcondes cauemarcondes deleted the inventory-remove-control-groups branch December 2, 2024 09:15
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 2, 2024

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Streams] App plugin (#200060)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202177

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
1 task
@cauemarcondes cauemarcondes mentioned this pull request Dec 2, 2024
Merged
@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Dec 2, 2024
@cauemarcondes @iblancof
[Inventory][ECO] Entity type Remove Control groups filter (elastic#20…
409c6cd 
…2177)

closes elastic#201584

- Removes control group entity types filter
- Adds multi-select entity types filer
- Add kuery to url
- Remove unified entities page
- Adding telemetry when entity type is filtered
- Refactoring...

https://github.com/user-attachments/assets/98fb11ab-76e7-497b-af86-86378c6bfd7f

---------

Co-authored-by: Irene Blanco <irene.blanco@elastic.co>
(cherry picked from commit d8f3f4c)
cauemarcondes added a commit that referenced this pull request Dec 2, 2024
@cauemarcondes
[8.x] [Inventory][ECO] Entity type Remove Control groups filter (#202177
be73fbe 
) (#202514)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Entity type Remove Control groups filter
(#202177)](#202177)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-02T09:14:35Z","message":"[Inventory][ECO]
Entity type Remove Control groups filter (#202177)\n\ncloses
https://github.com/elastic/kibana/issues/201584\r\n\r\n- Removes control
group entity types filter\r\n- Adds multi-select entity types filer\r\n-
Add kuery to url\r\n- Remove unified entities page\r\n- Adding telemetry
when entity type is filtered\r\n-
Refactoring...\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/98fb11ab-76e7-497b-af86-86378c6bfd7f\r\n\r\n---------\r\n\r\nCo-authored-by:
Irene Blanco
<irene.blanco@elastic.co>","sha":"d8f3f4cb3c4dd3af2e75c69a04ab357b6514976b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.18.0"],"number":202177,"url":"https://github.com/elastic/kibana/pull/202177","mergeCommit":{"message":"[Inventory][ECO]
Entity type Remove Control groups filter (#202177)\n\ncloses
https://github.com/elastic/kibana/issues/201584\r\n\r\n- Removes control
group entity types filter\r\n- Adds multi-select entity types filer\r\n-
Add kuery to url\r\n- Remove unified entities page\r\n- Adding telemetry
when entity type is filtered\r\n-
Refactoring...\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/98fb11ab-76e7-497b-af86-86378c6bfd7f\r\n\r\n---------\r\n\r\nCo-authored-by:
Irene Blanco
<irene.blanco@elastic.co>","sha":"d8f3f4cb3c4dd3af2e75c69a04ab357b6514976b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202177","number":202177,"mergeCommit":{"message":"[Inventory][ECO]
Entity type Remove Control groups filter (#202177)\n\ncloses
https://github.com/elastic/kibana/issues/201584\r\n\r\n- Removes control
group entity types filter\r\n- Adds multi-select entity types filer\r\n-
Add kuery to url\r\n- Remove unified entities page\r\n- Adding telemetry
when entity type is filtered\r\n-
Refactoring...\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/98fb11ab-76e7-497b-af86-86378c6bfd7f\r\n\r\n---------\r\n\r\nCo-authored-by:
Irene Blanco
<irene.blanco@elastic.co>","sha":"d8f3f4cb3c4dd3af2e75c69a04ab357b6514976b"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
JoseLuisGJ added a commit that referenced this pull request Dec 3, 2024
@JoseLuisGJ
[Search][Ent Search deprecation] Removing errors (#202177) (#202437)
9e144b1 
## Summary

This PR removes all error messages regarding Enterprise Search node. Due
to it will go away in 9.0 and listed in this epic:
elastic/search-team#8231


![image](https://github.com/user-attachments/assets/a71ffe1c-af8e-418c-99b3-fc29856cbf5b)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@cauemarcondes @iblancof @CAWilson94
[Inventory][ECO] Entity type Remove Control groups filter (elastic#20…
5c3417a 
…2177)

closes elastic#201584

- Removes control group entity types filter
- Adds multi-select entity types filer
- Add kuery to url
- Remove unified entities page
- Adding telemetry when entity type is filtered
- Refactoring...



https://github.com/user-attachments/assets/98fb11ab-76e7-497b-af86-86378c6bfd7f

---------

Co-authored-by: Irene Blanco <irene.blanco@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@JoseLuisGJ @CAWilson94
[Search][Ent Search deprecation] Removing errors (elastic#202177) (el…
8c0c0d8 
…astic#202437)

## Summary

This PR removes all error messages regarding Enterprise Search node. Due
to it will go away in 9.0 and listed in this epic:
elastic/search-team#8231


![image](https://github.com/user-attachments/assets/a71ffe1c-af8e-418c-99b3-fc29856cbf5b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iblancof iblancof iblancof left review comments

@crespocarlos crespocarlos crespocarlos approved these changes

@jloleysens jloleysens jloleysens approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees

No one assigned

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Inventory][ECO] Entity type Remove Control groups filter

8 participants

@cauemarcondes @elasticmachine @kibanamachine @crespocarlos @jloleysens @jennypavlova @tonyghiani @iblancof