[Logstash Pipeline Viewer] Remove explicit close button #20044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
review
v7.0.0
Team:Logstash
v6.4.0
Team:Monitoring
justinkambic
approved these changes
Jun 19, 2018
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
LGTM pending green CI
Contributor
💚 Build Succeeded |
ycombinator
added a commit
that referenced
this pull request
Jun 19, 2018
Contributor
Author
|
Backported to:
|
ycombinator
deleted the
x-pack/monitoring/logstash/pipeline-viewer/flyout-changes
branch
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #20005.
In #20005, EUI was upgraded to 0.0.53. This version changes the behavior of the
EuiFlyoutcomponent by providing a close button by default. TheDetailDrawercomponent in the Logstash Pipeline Viewer was adding a close button explicitly, resulting in two close buttons. This PR removes the explicit close button.Before this PR
After this PR
Testing this PR
x) button in top right.