Update EUI to 0.0.53 #20005
Merged
Update EUI to 0.0.53 #20005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Team:Core
Contributor
|
Dashboard "add panel" already places a close button on the top right. Can you remove this? Here are the required changes - nreese@cf18931. For some reason I can not create a PR against your PR that has a clean history |
Contributor
Author
|
I actually wanted to leave that Flyout changes to individual PRs after that has been merged, since as in your PR it might require some test changes, and I would rather not have them all in one big PR. Would it be okay, if you open another PR after that one? (Would still ping every FlyOut owner.) |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins, test this |
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins, test this |
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins, test this |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
Jenkins, test this - just to get a second pass |
nreese
approved these changes
Jun 19, 2018
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review and tested input controls in chrome
Contributor
💚 Build Succeeded |
timroes
added a commit
that referenced
this pull request
Jun 19, 2018
Contributor
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates EUI to 0.0.53, updates some broken snapshot tests, and fix #19927
One of the major changes in that version is, that all
EuiFlyoutnow have by default a close button in the top right corner. That might mean (or not depending on your use-case - in question of doubt consult the design team), that you might want to remove existing "Close" footers, or other Close buttons.I saw, that these teams are using
EuiFlyoutand might to look over their existing close solution: