Skip to content

[8.x] [presentation-utils] remove defaultTheme$ (#200044)#200205

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-200044
Nov 14, 2024
Merged

[8.x] [presentation-utils] remove defaultTheme$ (#200044)#200205
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-200044

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Closes elastic#200037

defaultTheme$ is only used in storybooks. This PR removes defaultTheme$
and replaces it with theme$ available from core start mock.

(cherry picked from commit f3e7735)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Nov 14, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) November 14, 2024 15:49
@kibanamachine kibanamachine merged commit 450f38e into elastic:8.x Nov 14, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #66 / aiops log pattern analysis attaches log pattern analysis table to a case

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
presentationUtil 181 180 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 130 129 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionError 7.7KB 7.5KB -190.0B
expressionImage 6.8KB 6.8KB -18.0B
expressionMetric 8.3KB 8.1KB -172.0B
expressionRepeatImage 8.6KB 8.6KB -18.0B
expressionRevealImage 8.5KB 8.5KB -14.0B
expressionShape 23.2KB 23.1KB -190.0B
presentationUtil 31.4KB 31.3KB -97.0B
total -699.0B
Unknown metric groups

API count

id before after diff
presentationUtil 160 159 -1

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants