Skip to content

[presentation-utils] remove defaultTheme$#200044

Merged
nreese merged 3 commits intoelastic:mainfrom
nreese:remove_default_theme
Nov 14, 2024
Merged

[presentation-utils] remove defaultTheme$#200044
nreese merged 3 commits intoelastic:mainfrom
nreese:remove_default_theme

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Nov 13, 2024 •
edited by kibanamachine
Loading

Closes #200037

defaultTheme$ is only used in storybooks. This PR removes defaultTheme$ and replaces it with theme$ available from core start mock.

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 13, 2024

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 13, 2024

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Nov 13, 2024

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 13, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
presentationUtil 181 180 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 130 129 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionError 7.7KB 7.5KB -190.0B
expressionImage 6.8KB 6.8KB -18.0B
expressionMetric 8.3KB 8.1KB -172.0B
expressionRepeatImage 8.6KB 8.6KB -18.0B
expressionRevealImage 8.5KB 8.5KB -14.0B
expressionShape 23.2KB 23.1KB -190.0B
presentationUtil 31.4KB 31.3KB -97.0B
total -699.0B
Unknown metric groups

API count

id before after diff
presentationUtil 160 159 -1

@nreese nreese marked this pull request as ready for review November 13, 2024 18:33
@nreese nreese requested a review from a team as a code owner November 13, 2024 18:33
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.17.0 labels Nov 13, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 13, 2024

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the backport:version Backport to applied version labels label Nov 13, 2024
@Heenawter Heenawter self-requested a review November 14, 2024 15:22
Heenawter
Heenawter approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review - already tested Canvas on my own to ensure that this doesn't impact the theming. LGTM 👍

@nreese nreese merged commit f3e7735 into elastic:main Nov 14, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 14, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11840610028

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 14, 2024
@nreese
[presentation-utils] remove defaultTheme$ (elastic#200044)
3be7555 
Closes elastic#200037

defaultTheme$ is only used in storybooks. This PR removes defaultTheme$
and replaces it with theme$ available from core start mock.

(cherry picked from commit f3e7735)
@kibanamachine kibanamachine mentioned this pull request Nov 14, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 14, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 14, 2024
Merged
kibanamachine added a commit that referenced this pull request Nov 14, 2024
@kibanamachine @nreese
[8.x] [presentation-utils] remove defaultTheme$ (#200044) (#200205)
450f38e 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[presentation-utils] remove defaultTheme$
(#200044)](#200044)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T15:43:56Z","message":"[presentation-utils]
remove defaultTheme$ (#200044)\n\nCloses
https://github.com/elastic/kibana/issues/200037\r\n\r\ndefaultTheme$ is
only used in storybooks. This PR removes defaultTheme$\r\nand replaces
it with theme$ available from core start
mock.","sha":"f3e773552d2f98d26afd8e9df866c812a5e6fdd7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","backport:version","v8.17.0"],"title":"[presentation-utils]
remove
defaultTheme$","number":200044,"url":"https://github.com/elastic/kibana/pull/200044","mergeCommit":{"message":"[presentation-utils]
remove defaultTheme$ (#200044)\n\nCloses
https://github.com/elastic/kibana/issues/200037\r\n\r\ndefaultTheme$ is
only used in storybooks. This PR removes defaultTheme$\r\nand replaces
it with theme$ available from core start
mock.","sha":"f3e773552d2f98d26afd8e9df866c812a5e6fdd7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200044","number":200044,"mergeCommit":{"message":"[presentation-utils]
remove defaultTheme$ (#200044)\n\nCloses
https://github.com/elastic/kibana/issues/200037\r\n\r\ndefaultTheme$ is
only used in storybooks. This PR removes defaultTheme$\r\nand replaces
it with theme$ available from core start
mock.","sha":"f3e773552d2f98d26afd8e9df866c812a5e6fdd7"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
wayneseymour pushed a commit to wayneseymour/kibana that referenced this pull request Nov 18, 2024
@nreese @wayneseymour
[presentation-utils] remove defaultTheme$ (elastic#200044)
96b48ba 
Closes elastic#200037

defaultTheme$ is only used in storybooks. This PR removes defaultTheme$
and replaces it with theme$ available from core start mock.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@nreese @CAWilson94
[presentation-utils] remove defaultTheme$ (elastic#200044)
5b05a4b 
Closes elastic#200037

defaultTheme$ is only used in storybooks. This PR removes defaultTheme$
and replaces it with theme$ available from core start mock.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@nreese @CAWilson94
[presentation-utils] remove defaultTheme$ (elastic#200044)
ad6204f 
Closes elastic#200037

defaultTheme$ is only used in storybooks. This PR removes defaultTheme$
and replaces it with theme$ available from core start mock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Canvas] Remove defaultTheme$ from presentation_util

4 participants

@nreese @elasticmachine @kibanamachine @Heenawter