[8.x] [One Discover] Add app menu actions for Observability projects (#198987)#200145
Merged
tonyghiani merged 2 commits intoelastic:8.xfrom Nov 14, 2024
Merged
[8.x] [One Discover] Add app menu actions for Observability projects (#198987)#200145tonyghiani merged 2 commits intoelastic:8.xfrom
tonyghiani merged 2 commits intoelastic:8.xfrom
Conversation
…ic#198987) ## 📓 Summary Closes elastic#182230 This work introduces a new observability root profile and uses the new extension point to register custom actions on the app menu. The registered actions and link will appear only with the new project navigation enabled on an Observability project: - A link to the data sets quality page - On the alerts sub menu... - replace the default search rule creation with the observability custom threshold rule - add an entry to directly create an SLO for the current search To access the SLO capabilities without breaking the dependencies hierarchy of the new sustainable architecture, the feature is registered by the common plugin `discover-shared` in SLO and consumed then by Discover using the IoC principle. ## 🖼️ Screenshots ### Observability project solution - show new menu <img width="3004" alt="Screenshot 2024-11-06 at 12 37 02" src="https://github.com/user-attachments/assets/d70b532d-1889-4d5b-b2ee-de2f048560f4"> ### Search project solution - hide new menu <img width="3006" alt="Screenshot 2024-11-06 at 12 36 19" src="https://github.com/user-attachments/assets/660893c3-f6b5-4b06-b8de-50a61a6bdb98"> ### Default navigation mode - hide new menu <img width="3002" alt="Screenshot 2024-11-06 at 12 35 43" src="https://github.com/user-attachments/assets/674c5a08-0084-40e5-ae34-a56c363cacce"> ## 🎥 Demo https://github.com/user-attachments/assets/104e6074-0401-4fd2-a8e6-8b05f2c070d7 --------- Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9d38922) # Conflicts: # x-pack/plugins/observability_solution/slo/public/pages/slo_edit/shared_flyout/get_create_slo_flyout.tsx # x-pack/plugins/observability_solution/slo/public/plugin.ts # x-pack/plugins/observability_solution/slo/public/types.ts # x-pack/plugins/observability_solution/slo/tsconfig.json # x-pack/test_serverless/functional/test_suites/common/discover_ml_uptime/discover/search_source_alert.ts
botelastic
bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
⏳ Build in-progress
|
mohamedhamed-ahmed
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation