[Ownership] Assign test files to Appex QA#199767
Conversation
…anch 'main' of github.com:elastic/kibana
Contributes to: elastic#192979
wayneseymour
added
the
release_note:skip
|
@elasticmachine merge upstream |
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
I think some files should be owned by other teams, let me know if it makes sense
dmlemeshko
left a comment
dmlemeshko
left a comment
There was a problem hiding this comment.
Thanks for update, I left few more questions/suggestions
.github/CODEOWNERS
Outdated
| /test/functional/services/query_bar.ts @elastic/appex-qa | ||
| /test/functional/services/menu_toggle.ts @elastic/appex-qa | ||
| /test/functional/services/listing_table.ts @elastic/appex-qa | ||
| /test/functional/screenshots/.empty @elastic/appex-qa |
There was a problem hiding this comment.
question: do we need owners for file like this?
There was a problem hiding this comment.
Great question. What say you boss man? @pheyos
There was a problem hiding this comment.
Actually, I think the file can be removed. It was added as a placeholder when the directory was clean (see #14122). Since then, new base line screenshots have been added, so the directory is no longer empty.
There was a problem hiding this comment.
Will be removed in #200161, so can be taken off the code owners list
|
@elasticmachine merge upstream |
| /test/plugin_functional/services/index.ts @elastic/appex-qa | ||
| /test/plugin_functional/README.md @elastic/appex-qa | ||
| /test/plugin_functional/config.ts @elastic/appex-qa |
There was a problem hiding this comment.
Having another look at /test/plugin_functional I think we shouldn't own individual files and keep the main owner own the whole path. WDYT?
There was a problem hiding this comment.
Like this: /test/plugin_functional @elastic/appex-qa?
There was a problem hiding this comment.
I was wrong, there are different team owners:
/test/plugin_functional/test_suites/panel_actions @elastic/kibana-presentation
/test/plugin_functional/plugins/rendering_plugin @elastic/kibana-core
...
Let's leave it as is
💚 Build Succeeded
Metrics [docs]
History
|
## Summary Assign test files to Appex QA Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary Assign test files to Appex QA Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary Assign test files to Appex QA Contributes to: elastic#192979 --------- Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
6 participants
Summary
Assign test files to Appex QA
Contributes to: #192979