[functional tests] Remove default screenshots#14122
Merged
jbudz merged 2 commits intoelastic:masterfrom Sep 26, 2017
Merged
Conversation
Closed
jbudz
added a commit
that referenced
this pull request
Sep 26, 2017
* [functional tests] Remove default screenshots * Remove baseline screenshots
jbudz
added a commit
that referenced
this pull request
Sep 26, 2017
* [functional tests] Remove default screenshots * Remove baseline screenshots
This was referenced Nov 14, 2024
pheyos
added a commit
that referenced
this pull request
Nov 14, 2024
## Summary This PR removes the `.empty` file from the `test/functional/screenshots` directory as it's no longer needed. ### Details The file has been introduced as part of #14122 when the directory was cleaned. Since then, new base line screenshots have been added, so the directory is no longer empty.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 14, 2024
…00161) ## Summary This PR removes the `.empty` file from the `test/functional/screenshots` directory as it's no longer needed. ### Details The file has been introduced as part of elastic#14122 when the directory was cleaned. Since then, new base line screenshots have been added, so the directory is no longer empty. (cherry picked from commit 79c5e84)
kibanamachine
added a commit
that referenced
this pull request
Nov 14, 2024
…0161) (#200198) # Backport This will backport the following commits from `main` to `8.x`: - [Functional tests - remove .empty file from screenshots dir (#200161)](#200161) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Oskamp","email":"robert.oskamp@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T14:46:28Z","message":"Functional tests - remove .empty file from screenshots dir (#200161)\n\n## Summary\r\n\r\nThis PR removes the `.empty` file from the `test/functional/screenshots`\r\ndirectory as it's no longer needed.\r\n\r\n### Details\r\n\r\nThe file has been introduced as part of #14122 when the directory was\r\ncleaned. Since then, new base line screenshots have been added, so the\r\ndirectory is no longer empty.","sha":"79c5e844ff288db593fcd6467ba560e75e884242","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.17.0"],"title":"Functional tests - remove .empty file from screenshots dir","number":200161,"url":"https://github.com/elastic/kibana/pull/200161","mergeCommit":{"message":"Functional tests - remove .empty file from screenshots dir (#200161)\n\n## Summary\r\n\r\nThis PR removes the `.empty` file from the `test/functional/screenshots`\r\ndirectory as it's no longer needed.\r\n\r\n### Details\r\n\r\nThe file has been introduced as part of #14122 when the directory was\r\ncleaned. Since then, new base line screenshots have been added, so the\r\ndirectory is no longer empty.","sha":"79c5e844ff288db593fcd6467ba560e75e884242"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200161","number":200161,"mergeCommit":{"message":"Functional tests - remove .empty file from screenshots dir (#200161)\n\n## Summary\r\n\r\nThis PR removes the `.empty` file from the `test/functional/screenshots`\r\ndirectory as it's no longer needed.\r\n\r\n### Details\r\n\r\nThe file has been introduced as part of #14122 when the directory was\r\ncleaned. Since then, new base line screenshots have been added, so the\r\ndirectory is no longer empty.","sha":"79c5e844ff288db593fcd6467ba560e75e884242"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
wayneseymour
pushed a commit
to wayneseymour/kibana
that referenced
this pull request
Nov 18, 2024
…00161) ## Summary This PR removes the `.empty` file from the `test/functional/screenshots` directory as it's no longer needed. ### Details The file has been introduced as part of elastic#14122 when the directory was cleaned. Since then, new base line screenshots have been added, so the directory is no longer empty.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…00161) ## Summary This PR removes the `.empty` file from the `test/functional/screenshots` directory as it's no longer needed. ### Details The file has been introduced as part of elastic#14122 when the directory was cleaned. Since then, new base line screenshots have been added, so the directory is no longer empty.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…00161) ## Summary This PR removes the `.empty` file from the `test/functional/screenshots` directory as it's no longer needed. ### Details The file has been introduced as part of elastic#14122 when the directory was cleaned. Since then, new base line screenshots have been added, so the directory is no longer empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not remove screenshots on test failures.
A while back we started adding screenshots to the functional test runner with the intent of automatically keeping documentation screenshots up to date. The infrastructure for this next step is not ready, and in the meantime these screenshots add unnecessary bandwith.
This removes al ofl the application screenshots. When/if we get to docs, lets add screenshots back in as needed.
Closes #11350