[WIP] Migrations/major version#19965
Closed
chrisdavies wants to merge 35 commits intoelastic:masterfrom
Closed
Conversation
Making onBeforeWrite accessible to custom factories
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins test this |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one in a series of several PRs that will go towards resolving #15100.
This builds on the original PR, so it's probably best to wait to review this until that one is approved.
This introduces the following changes:
Testing this PR
var index = '.kibana;` in the REPL example belowyarn start --replWe haven't determined how major migrations will be launched (via UI, via cli, automatically on start (probably not))? So, this PR is only the core of major index migrations. To actually run migrations, you have to tinker with some code, which is easily done via the REPL. The following code provides a way to migrate the index, and a way to undo the migration (
undoMigrate()) if the migration fails. If the undo function is handy enough, we should probably incororate it into the codebase.Note: it's helpful to use
varin the REPL, as it allows you to more easily revover from mistakes.