Move index management concerns into the saved object client#19762
Move index management concerns into the saved object client#19762chrisdavies wants to merge 18 commits intoelastic:masterfrom
Conversation
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
| const scopedClientProvider = new ScopedSavedObjectsClientProvider({ | ||
| index: server.config().get('kibana.index'), | ||
| mappings: server.getKibanaIndexMappingsDsl(), | ||
| onBeforeWrite, |
There was a problem hiding this comment.
We're no longer passing the onBeforeWrite to the ScopedSavedObjectsClientProvider constructor so when we set a custom client factory, we'll no longer have access to the onBeforeWrite.
Perhaps a sample usage makes this easier to follow: https://github.com/elastic/kibana/blob/security-app-privs/x-pack/plugins/security/index.js#L120
There was a problem hiding this comment.
I'm bad with words, so I threw up chrisdavies#1 to illustrate the changes that would make this possible.
Making onBeforeWrite accessible to custom factories
|
@kobelb Thanks! Merged your PR and master and made some adjustments. Have a look to see if it passes muster. |
💚 Build Succeeded |
|
Just dropping a note to say I'm backlogged on reviews, haven't forgotten, hope to get to it this week. |
|
@archanid I'm canning this one, as we've decided to write migrations in such a way that breaking changes are allowable. So, that changes this PR a bit. |
This is one in a series of several PRs that will go towards resolving #15100.
This introduces the following changes:
Testing this PR
_foo)