[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form#198725
Merged
Zacqary merged 76 commits intoelastic:mainfrom Dec 3, 2024
Merged
[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form#198725Zacqary merged 76 commits intoelastic:mainfrom
Zacqary merged 76 commits intoelastic:mainfrom
Conversation
# Conflicts: # x-pack/plugins/security_solution/public/detection_engine/rule_management/api/api.ts
Zacqary
added
Team:ResponseOps
…ckage # Conflicts: # packages/response-ops/rule_form/src/rule_actions/rule_actions_system_actions_item.tsx # x-pack/plugins/observability_solution/observability/tsconfig.json # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/system_action_type_form.tsx
kdelemme
force-pushed
the
195211-rule-form-package
branch
2 times, most recently
from
05c3965 to
6401b97
Compare
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7515[❌] x-pack/test/observability_functional/with_rac_write.config.ts: 0/10 tests passed. |
patrykkopycinski
approved these changes
Nov 27, 2024
Contributor
Author
|
Mystery solved, the test that was failing in CI but not locally was because these key names for This is because the changes to Let's avoid using |
benakansara
approved these changes
Dec 3, 2024
Contributor
benakansara
left a comment
benakansara
left a comment
There was a problem hiding this comment.
obs-ux-management changes LGTM
neptunian
approved these changes
Dec 3, 2024
…ckage # Conflicts: # packages/kbn-alerts-ui-shared/src/common/hooks/index.ts # packages/kbn-alerts-ui-shared/src/common/hooks/use_fetch_alerts_fields_query.ts # packages/response-ops/rule_form/src/rule_actions/rule_actions_alerts_filter.tsx # x-pack/plugins/triggers_actions_ui/public/types.ts
Contributor
⏳ Build in-progress
Failed CI StepsHistory
|
Contributor
|
Starting backport for target branches: 8.17 https://github.com/elastic/kibana/actions/runs/12146117808 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cnasikas
added a commit
that referenced
this pull request
Dec 4, 2024
…-rule-form (#198725) (#202907) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form (#198725)](#198725) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Zacqary Adam Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-03T18:40:48Z","message":"[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form (#198725)\n\n## Summary\r\n\r\nPart of #195211\r\n\r\nMoves Rule Form code out of `@kbn/alerts-ui-shared` and into a new\r\npackage called `@kbn/response-ops-rule-form`.\r\n\r\nSome types and hooks that are used by multiple features or solutions are\r\nstill in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of\r\nRule Form-specific code is in this new package.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Kevin Delemme <kevin.delemme@elastic.co>","sha":"8f267fd83c05c3c7c97a07e7abb671c35fc7a617","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:Fleet","v9.0.0","Feature:Alerting/RulesManagement","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.18.0"],"number":198725,"url":"https://github.com/elastic/kibana/pull/198725","mergeCommit":{"message":"[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form (#198725)\n\n## Summary\r\n\r\nPart of #195211\r\n\r\nMoves Rule Form code out of `@kbn/alerts-ui-shared` and into a new\r\npackage called `@kbn/response-ops-rule-form`.\r\n\r\nSome types and hooks that are used by multiple features or solutions are\r\nstill in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of\r\nRule Form-specific code is in this new package.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Kevin Delemme <kevin.delemme@elastic.co>","sha":"8f267fd83c05c3c7c97a07e7abb671c35fc7a617"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198725","number":198725,"mergeCommit":{"message":"[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-form (#198725)\n\n## Summary\r\n\r\nPart of #195211\r\n\r\nMoves Rule Form code out of `@kbn/alerts-ui-shared` and into a new\r\npackage called `@kbn/response-ops-rule-form`.\r\n\r\nSome types and hooks that are used by multiple features or solutions are\r\nstill in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of\r\nRule Form-specific code is in this new package.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Kevin Delemme <kevin.delemme@elastic.co>","sha":"8f267fd83c05c3c7c97a07e7abb671c35fc7a617"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…form (elastic#198725) ## Summary Part of elastic#195211 Moves Rule Form code out of `@kbn/alerts-ui-shared` and into a new package called `@kbn/response-ops-rule-form`. Some types and hooks that are used by multiple features or solutions are still in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of Rule Form-specific code is in this new package. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #195211
Moves Rule Form code out of
@kbn/alerts-ui-sharedand into a new package called@kbn/response-ops-rule-form.Some types and hooks that are used by multiple features or solutions are still in
@kbn/alerts-ui-sharedand have been rerouted. The bulk of Rule Form-specific code is in this new package.Checklist