[ResponseOps][New Rule Form] Fix new rule form issues with basic license#198036
Merged
js-jankisalvi merged 5 commits intoelastic:mainfrom Nov 4, 2024
Merged
Conversation
js-jankisalvi
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
reviewed
Oct 31, 2024
packages/kbn-alerts-ui-shared/src/rule_type_modal/components/rule_type_list.tsx
Outdated
Show resolved
Hide resolved
adcoelho
approved these changes
Oct 31, 2024
19 tasks
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11671063202 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
…nse (elastic#198036) ## Summary Fixes below issues from new rule form leftovers elastic#196235 <details><summary>On basic license, if I hover on unsupported connectors, a tooltip explains the reasoning. This is not happening for rule types. We should do the same for the rule types</summary>  </details> <details><summary>On basic license, I can edit a rule that is not available on the basic. This leads to a bunch of errors in edit mode. The same is happening on main. We should prevent accessing this kind of rule types.</summary>  </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 962082e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
…c license (#198036) (#198842) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][New Rule Form] Fix new rule form issues with basic license (#198036)](#198036) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Janki Salvi","email":"117571355+js-jankisalvi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-04T19:13:33Z","message":"[ResponseOps][New Rule Form] Fix new rule form issues with basic license (#198036)\n\n## Summary\r\n\r\nFixes below issues from new rule form leftovers\r\nhttps://github.com//issues/196235?reload=1?reload=1\r\n\r\n<details><summary>On basic license, if I hover on unsupported\r\nconnectors, a tooltip explains the reasoning. This is not happening for\r\nrule types. We should do the same for the rule types</summary>\r\n\r\n\r\n</details> \r\n\r\n<details><summary>On basic license, I can edit a rule that is not\r\navailable on the basic. This leads to a bunch of errors in edit mode.\r\nThe same is happening on main. We should prevent accessing this kind of\r\nrule types.</summary>\r\n\r\n\r\n</details> \r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"962082ead77fbd0c23a64347f9fa19e7424c400b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.17.0"],"title":"[ResponseOps][New Rule Form] Fix new rule form issues with basic license","number":198036,"url":"https://github.com/elastic/kibana/pull/198036","mergeCommit":{"message":"[ResponseOps][New Rule Form] Fix new rule form issues with basic license (#198036)\n\n## Summary\r\n\r\nFixes below issues from new rule form leftovers\r\nhttps://github.com//issues/196235?reload=1?reload=1\r\n\r\n<details><summary>On basic license, if I hover on unsupported\r\nconnectors, a tooltip explains the reasoning. This is not happening for\r\nrule types. We should do the same for the rule types</summary>\r\n\r\n\r\n</details> \r\n\r\n<details><summary>On basic license, I can edit a rule that is not\r\navailable on the basic. This leads to a bunch of errors in edit mode.\r\nThe same is happening on main. We should prevent accessing this kind of\r\nrule types.</summary>\r\n\r\n\r\n</details> \r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"962082ead77fbd0c23a64347f9fa19e7424c400b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198036","number":198036,"mergeCommit":{"message":"[ResponseOps][New Rule Form] Fix new rule form issues with basic license (#198036)\n\n## Summary\r\n\r\nFixes below issues from new rule form leftovers\r\nhttps://github.com//issues/196235?reload=1?reload=1\r\n\r\n<details><summary>On basic license, if I hover on unsupported\r\nconnectors, a tooltip explains the reasoning. This is not happening for\r\nrule types. We should do the same for the rule types</summary>\r\n\r\n\r\n</details> \r\n\r\n<details><summary>On basic license, I can edit a rule that is not\r\navailable on the basic. This leads to a bunch of errors in edit mode.\r\nThe same is happening on main. We should prevent accessing this kind of\r\nrule types.</summary>\r\n\r\n\r\n</details> \r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"962082ead77fbd0c23a64347f9fa19e7424c400b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com>
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Nov 4, 2024
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Nov 4, 2024
This reverts commit 6c6240e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes below issues from new rule form leftovers #196235
On basic license, if I hover on unsupported connectors, a tooltip explains the reasoning. This is not happening for rule types. We should do the same for the rule types
On basic license, I can edit a rule that is not available on the basic. This leads to a bunch of errors in edit mode. The same is happening on main. We should prevent accessing this kind of rule types.
Checklist