New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] List k8s entities in the grid #197292

Merged

cauemarcondes merged 23 commits into elastic:main from cauemarcondes:inventory-k8s-entities-2

Oct 24, 2024

Contributor

cauemarcondes commented Oct 22, 2024 •

edited by kibanamachine

Loading

closes #196155
Blocked by #196916 (K8s entities alias patterns don't exist yet.)

node scripts/synthtrace many_entities.ts --clean --live
node scripts/synthtrace k8s_entities.ts --clean --live

Screen.Recording.2024-10-22.at.16.mp4

cauemarcondes and others added 17 commits

October 21, 2024 15:30


          [Synthtrace][Inventory] K8s entities support

3ec4009


          refactoring

c7e4470


          refactoring 2

4831d81


          making params optional

8e4b113


          fixing

ea4963e


          refactoring

dd09c8b


          Merge branch 'main' into inventory-k8s-entities

a3f5ad8


          Merge remote-tracking branch 'origin/inventory-k8s-entities' into inv…

ec84270

…entory-k8s-entities-2


          forgot to add the identity fields

d82f134


          Merge remote-tracking branch 'origin/inventory-k8s-entities' into inv…

36b0397

…entory-k8s-entities-2


          api changes

02ed26d


          stop using entityType

ae12e02


          removing alot of types

657c003


          adding icon

d15fa64


          reverting

54187be


          using raw entity type

3bc8988


          Merge branch 'main' of github.com:elastic/kibana into inventory-k8s-e…

09f9279

…ntities-2

cauemarcondes added release_note:skip backport:prev-minor v8.17.0 labels

cauemarcondes marked this pull request as ready for review

October 22, 2024 15:56

cauemarcondes requested a review from a team as a code owner

October 22, 2024 15:56


          fix ci

botelastic bot added the ci:project-deploy-observability label

Contributor

github-actions bot commented Oct 23, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

cauemarcondes added blocked and removed blocked labels

kpatticha reviewed

View reviewed changes

x-pack/plugins/observability_solution/inventory/server/routes/entities/get_latest_entities.ts Show resolved Hide resolved

kpatticha reviewed

View reviewed changes

x-pack/plugins/observability_solution/inventory/server/routes/entities/get_latest_entities.ts Outdated

+                const where: string[] = [getBuiltinEntityDefinitionIdESQLWhereClause()];
+                if (entityTypes) {
+                  where.push(getEntityTypesWhereClause(entityTypes));

Contributor

kpatticha Oct 23, 2024

Now the entityTypes could be any string that the user passes, maybe it's time to use the params. Up to you

Contributor Author

cauemarcondes Oct 23, 2024

I tried, but it was throwing an error. I was having another look at the types now and apparently I missed something... will try it again. Thanks.

Contributor Author

cauemarcondes Oct 23, 2024

kpatticha approved these changes

View reviewed changes

Contributor

kpatticha left a comment

I tested it only with the node scripts/synthtrace k8s_entities and it looks good. it would be nice to have a way to test all the entities

Contributor

elasticmachine commented Oct 23, 2024

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Contributor Author

cauemarcondes commented Oct 23, 2024

I tested it only with the node scripts/synthtrace k8s_entities and it looks good. it would be nice to have a way to test all the entities

cauemarcondes added 3 commits

October 23, 2024 14:33


          fixing e2e

6b0b0ad


          using esql params

a03061e


          Merge branch 'main' of github.com:elastic/kibana into inventory-k8s-e…

1e59a35

…ntities-2

crespocarlos reviewed

View reviewed changes

x-pack/plugins/observability_solution/inventory/public/components/entity_icon/index.tsx Show resolved Hide resolved

...gins/observability_solution/inventory/public/components/search_bar/entity_types_controls.tsx Outdated Show resolved Hide resolved

...gins/observability_solution/inventory/public/components/search_bar/entity_types_controls.tsx Outdated Show resolved Hide resolved

x-pack/plugins/observability_solution/inventory/server/routes/entities/get_latest_entities.ts Show resolved Hide resolved

...gins/observability_solution/inventory/public/components/search_bar/entity_types_controls.tsx

                 key: entityType,
-                label: getEntityTypeLabel(entityType),
+                label: entityType,

Contributor

crespocarlos Oct 24, 2024

What's the plan here? is EEM going to send the label?

Contributor Author

cauemarcondes Oct 24, 2024

That's the plan for the future.

...gins/observability_solution/inventory/public/components/search_bar/entity_types_controls.tsx Outdated Show resolved Hide resolved


          PR comments

2e1c306

mohamedhamed-ahmed approved these changes

View reviewed changes

Contributor

mohamedhamed-ahmed left a comment

LGTM! code review only

cauemarcondes requested a review from crespocarlos

October 24, 2024 09:45

Contributor

elasticmachine commented Oct 24, 2024

⏳ Build in-progress

Buildkite Build
Commit: 2e1c306
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197292-2e1c306d2019

History

💔 Build #245173 failed a03061e
💚 Build #245088 succeeded 6b0b0ad
💔 Build #244951 failed 9618099
💔 Build #244752 failed 09f9279

crespocarlos approved these changes

View reviewed changes

Contributor

crespocarlos left a comment

LGTM

cauemarcondes merged commit c6f4178 into elastic:main

28 checks passed

cauemarcondes deleted the inventory-k8s-entities-2 branch

October 24, 2024 13:35

kibanamachine added the v9.0.0 label

Contributor

kibanamachine commented Oct 24, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11500451419

Contributor

kibanamachine commented Oct 24, 2024

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197292

Questions ?

Please refer to the Backport tool documentation

kibanamachine mentioned this pull request

[Reporting/Tests] Improvements for task stability in serverless tests #195841

Merged

kibanamachine added the backport missing label

Contributor

kibanamachine commented Oct 25, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197292 locally

kibanamachine mentioned this pull request

[Entity Inventory] Add basic telemetry #197055

Merged

Contributor

kibanamachine commented Oct 28, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197292 locally

3 similar comments

Contributor

kibanamachine commented Oct 29, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197292 locally

Contributor

kibanamachine commented Oct 30, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197292 locally

Contributor

kibanamachine commented Oct 31, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197292 locally

cauemarcondes mentioned this pull request

[8.x] [Inventory] List k8s entities in the grid (#197292) #198643

Closed

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request


          [Inventory] List k8s entities in the grid (elastic#197292)

985e230

closes elastic#196155
Blocked by elastic#196916 (K8s entities
alias patterns don't exist yet.)

```
node scripts/synthtrace many_entities.ts --clean --live
node scripts/synthtrace k8s_entities.ts --clean --live
```

https://github.com/user-attachments/assets/5861ebc7-8386-4a4b-a68b-50adc5244d43
(cherry picked from commit c6f4178)

# Conflicts:
#	x-pack/plugins/observability_solution/inventory/public/components/search_bar/index.tsx

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request


          [Inventory] List k8s entities in the grid (elastic#197292)

4b3179c

closes elastic#196155
Blocked by elastic#196916 (K8s entities
alias patterns don't exist yet.)

```
node scripts/synthtrace many_entities.ts --clean --live
node scripts/synthtrace k8s_entities.ts --clean --live
```

https://github.com/user-attachments/assets/5861ebc7-8386-4a4b-a68b-50adc5244d43
(cherry picked from commit c6f4178)

# Conflicts:
#	x-pack/plugins/observability_solution/inventory/public/components/search_bar/index.tsx

cauemarcondes mentioned this pull request

[8.x] [Inventory] List k8s entities in the grid (#197292) #198665

Merged

cauemarcondes added a commit that referenced this pull request


          [8.x] [Inventory] List k8s entities in the grid (#197292) (#198665)

4371eb8

# Backport

This will backport the following commits from `main` to `8.x`:
 - [Inventory] List k8s entities in the grid (#197292) (c6f4178)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:35:19Z","message":"[Inventory]
List k8s entities in the grid (#197292)\n\ncloses
https://github.com/elastic/kibana/issues/196155\r\nBlocked by
#196916 (K8s entities\r\nalias
patterns don't exist yet.)\r\n\r\n```\r\nnode scripts/synthtrace
many_entities.ts --clean --live\r\nnode scripts/synthtrace
k8s_entities.ts --clean
--live\r\n```\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5861ebc7-8386-4a4b-a68b-50adc5244d43","sha":"c6f41783bf853f2828787cc4c48a96511fec2eec"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->

kibanamachine removed the backport missing label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:prev-minor ci:project-deploy-observability release_note:skip Team:obs-ux-infra_services v8.17.0 v9.0.0