-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Entity Inventory] Add basic telemetry #197055
[Entity Inventory] Add basic telemetry #197055
Conversation
x-pack/plugins/observability_solution/inventory/.storybook/get_mock_inventory_context.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/inventory/public/services/types.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @iblancof |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11520477239 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
## Summary Closes elastic#195608. In this PR, we introduce basic telemetry tracking for the new Inventory plugin. These events will help us gain insight into how users are interacting with the Inventory feature, including the state of the views, search behaviors, and entity type filtering. **New events** - Entity Inventory Viewed - Entity Inventory Search Query Submitted - Entity Inventory Entity Type Filtered - Entity View Clicked ![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264) ~**New attribute added to global context**~ - ~eem_enabled~ ~It will only be populated if the Inventory plugin is accessible to users and after they access the Observability solution. If EEM is not enabled and the user enables it, the property will be updated accordingly.~ Details about not implementing `eem_enabled` can be found in [this comment](elastic#197055 (comment)). (cherry picked from commit 7d673b8) # Conflicts: # x-pack/plugins/observability_solution/inventory/public/components/search_bar/index.tsx
## Summary Closes elastic#195608. In this PR, we introduce basic telemetry tracking for the new Inventory plugin. These events will help us gain insight into how users are interacting with the Inventory feature, including the state of the views, search behaviors, and entity type filtering. **New events** - Entity Inventory Viewed - Entity Inventory Search Query Submitted - Entity Inventory Entity Type Filtered - Entity View Clicked ![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264) ~**New attribute added to global context**~ - ~eem_enabled~ ~It will only be populated if the Inventory plugin is accessible to users and after they access the Observability solution. If EEM is not enabled and the user enables it, the property will be updated accordingly.~ Details about not implementing `eem_enabled` can be found in [this comment](elastic#197055 (comment)). (cherry picked from commit 7d673b8) # Conflicts: # x-pack/plugins/observability_solution/inventory/public/components/search_bar/index.tsx
# Backport This will backport the following commits from `main` to `8.16`: - [[Entity Inventory] Add basic telemetry (#197055)](#197055) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T14:49:49Z","message":"[Entity Inventory] Add basic telemetry (#197055)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195608.\r\n\r\nIn this PR, we introduce basic telemetry tracking for the new Inventory\r\nplugin.\r\nThese events will help us gain insight into how users are interacting\r\nwith the Inventory feature, including the state of the views, search\r\nbehaviors, and entity type filtering.\r\n\r\n\r\n**New events**\r\n- Entity Inventory Viewed\r\n- Entity Inventory Search Query Submitted\r\n- Entity Inventory Entity Type Filtered\r\n- Entity View Clicked\r\n\r\n\r\n![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264)\r\n\r\n\r\n~**New attribute added to global context**~\r\n- ~eem_enabled~\r\n\r\n~It will only be populated if the Inventory plugin is accessible to\r\nusers and after they access the Observability solution.\r\nIf EEM is not enabled and the user enables it, the property will be\r\nupdated accordingly.~\r\n\r\nDetails about not implementing `eem_enabled` can be found in [this\r\ncomment](https://github.com/elastic/kibana/pull/197055#issuecomment-2432123047).","sha":"7d673b84c3ecec2f6da81b57196301c6e7fe384a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","telemetry","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":197055,"url":"https://github.com/elastic/kibana/pull/197055","mergeCommit":{"message":"[Entity Inventory] Add basic telemetry (#197055)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195608.\r\n\r\nIn this PR, we introduce basic telemetry tracking for the new Inventory\r\nplugin.\r\nThese events will help us gain insight into how users are interacting\r\nwith the Inventory feature, including the state of the views, search\r\nbehaviors, and entity type filtering.\r\n\r\n\r\n**New events**\r\n- Entity Inventory Viewed\r\n- Entity Inventory Search Query Submitted\r\n- Entity Inventory Entity Type Filtered\r\n- Entity View Clicked\r\n\r\n\r\n![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264)\r\n\r\n\r\n~**New attribute added to global context**~\r\n- ~eem_enabled~\r\n\r\n~It will only be populated if the Inventory plugin is accessible to\r\nusers and after they access the Observability solution.\r\nIf EEM is not enabled and the user enables it, the property will be\r\nupdated accordingly.~\r\n\r\nDetails about not implementing `eem_enabled` can be found in [this\r\ncomment](https://github.com/elastic/kibana/pull/197055#issuecomment-2432123047).","sha":"7d673b84c3ecec2f6da81b57196301c6e7fe384a"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197055","number":197055,"mergeCommit":{"message":"[Entity Inventory] Add basic telemetry (#197055)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195608.\r\n\r\nIn this PR, we introduce basic telemetry tracking for the new Inventory\r\nplugin.\r\nThese events will help us gain insight into how users are interacting\r\nwith the Inventory feature, including the state of the views, search\r\nbehaviors, and entity type filtering.\r\n\r\n\r\n**New events**\r\n- Entity Inventory Viewed\r\n- Entity Inventory Search Query Submitted\r\n- Entity Inventory Entity Type Filtered\r\n- Entity View Clicked\r\n\r\n\r\n![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264)\r\n\r\n\r\n~**New attribute added to global context**~\r\n- ~eem_enabled~\r\n\r\n~It will only be populated if the Inventory plugin is accessible to\r\nusers and after they access the Observability solution.\r\nIf EEM is not enabled and the user enables it, the property will be\r\nupdated accordingly.~\r\n\r\nDetails about not implementing `eem_enabled` can be found in [this\r\ncomment](https://github.com/elastic/kibana/pull/197055#issuecomment-2432123047).","sha":"7d673b84c3ecec2f6da81b57196301c6e7fe384a"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Irene Blanco <[email protected]>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
# Backport This will backport the following commits from `main` to `8.x`: - [[Entity Inventory] Add basic telemetry (#197055)](#197055) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T14:49:49Z","message":"[Entity Inventory] Add basic telemetry (#197055)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195608.\r\n\r\nIn this PR, we introduce basic telemetry tracking for the new Inventory\r\nplugin.\r\nThese events will help us gain insight into how users are interacting\r\nwith the Inventory feature, including the state of the views, search\r\nbehaviors, and entity type filtering.\r\n\r\n\r\n**New events**\r\n- Entity Inventory Viewed\r\n- Entity Inventory Search Query Submitted\r\n- Entity Inventory Entity Type Filtered\r\n- Entity View Clicked\r\n\r\n\r\n![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264)\r\n\r\n\r\n~**New attribute added to global context**~\r\n- ~eem_enabled~\r\n\r\n~It will only be populated if the Inventory plugin is accessible to\r\nusers and after they access the Observability solution.\r\nIf EEM is not enabled and the user enables it, the property will be\r\nupdated accordingly.~\r\n\r\nDetails about not implementing `eem_enabled` can be found in [this\r\ncomment](https://github.com/elastic/kibana/pull/197055#issuecomment-2432123047).","sha":"7d673b84c3ecec2f6da81b57196301c6e7fe384a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","telemetry","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":197055,"url":"https://github.com/elastic/kibana/pull/197055","mergeCommit":{"message":"[Entity Inventory] Add basic telemetry (#197055)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195608.\r\n\r\nIn this PR, we introduce basic telemetry tracking for the new Inventory\r\nplugin.\r\nThese events will help us gain insight into how users are interacting\r\nwith the Inventory feature, including the state of the views, search\r\nbehaviors, and entity type filtering.\r\n\r\n\r\n**New events**\r\n- Entity Inventory Viewed\r\n- Entity Inventory Search Query Submitted\r\n- Entity Inventory Entity Type Filtered\r\n- Entity View Clicked\r\n\r\n\r\n![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264)\r\n\r\n\r\n~**New attribute added to global context**~\r\n- ~eem_enabled~\r\n\r\n~It will only be populated if the Inventory plugin is accessible to\r\nusers and after they access the Observability solution.\r\nIf EEM is not enabled and the user enables it, the property will be\r\nupdated accordingly.~\r\n\r\nDetails about not implementing `eem_enabled` can be found in [this\r\ncomment](https://github.com/elastic/kibana/pull/197055#issuecomment-2432123047).","sha":"7d673b84c3ecec2f6da81b57196301c6e7fe384a"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197055","number":197055,"mergeCommit":{"message":"[Entity Inventory] Add basic telemetry (#197055)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195608.\r\n\r\nIn this PR, we introduce basic telemetry tracking for the new Inventory\r\nplugin.\r\nThese events will help us gain insight into how users are interacting\r\nwith the Inventory feature, including the state of the views, search\r\nbehaviors, and entity type filtering.\r\n\r\n\r\n**New events**\r\n- Entity Inventory Viewed\r\n- Entity Inventory Search Query Submitted\r\n- Entity Inventory Entity Type Filtered\r\n- Entity View Clicked\r\n\r\n\r\n![Untitled-2024-07-24-1420](https://github.com/user-attachments/assets/6e85ea00-c626-4bc1-a4f8-9907674eb264)\r\n\r\n\r\n~**New attribute added to global context**~\r\n- ~eem_enabled~\r\n\r\n~It will only be populated if the Inventory plugin is accessible to\r\nusers and after they access the Observability solution.\r\nIf EEM is not enabled and the user enables it, the property will be\r\nupdated accordingly.~\r\n\r\nDetails about not implementing `eem_enabled` can be found in [this\r\ncomment](https://github.com/elastic/kibana/pull/197055#issuecomment-2432123047).","sha":"7d673b84c3ecec2f6da81b57196301c6e7fe384a"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Irene Blanco <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
Closes #195608.
In this PR, we introduce basic telemetry tracking for the new Inventory plugin.
These events will help us gain insight into how users are interacting with the Inventory feature, including the state of the views, search behaviors, and entity type filtering.
New events
New attribute added to global contexteem_enabledIt will only be populated if the Inventory plugin is accessible to users and after they access the Observability solution.If EEM is not enabled and the user enables it, the property will be updated accordingly.
Details about not implementing
eem_enabled
can be found in this comment.