[SecuritySolution] Allow custom sorting on integration cards#195397
Merged
angorayc merged 1 commit intoelastic:mainfrom Oct 8, 2024
Merged
[SecuritySolution] Allow custom sorting on integration cards#195397angorayc merged 1 commit intoelastic:mainfrom
angorayc merged 1 commit intoelastic:mainfrom
Conversation
angorayc
added
Team:Threat Hunting:Explore
backport
angorayc
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
criamico
approved these changes
Oct 8, 2024
Member
criamico
left a comment
criamico
left a comment
There was a problem hiding this comment.
I didn't test locally but it's a small enough PR that should be ok. LGTM
| showMissingIntegrationMessage?: boolean; | ||
| showControls?: boolean; | ||
| showSearchTools?: boolean; | ||
| // Customizing whether to sort by the default featured integrations' categories. Security Solution has custom sorting logic |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11237506671 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
…#195397) Part of elastic#193131 It shows the customised cards without applying the default sorting under the `recommended` tab: Added two optional props: 1. `calloutTopSpacerSize` - Props to decide the size of the spacer above callout. Security Solution uses this prop to customize the size of the spacer 2. `sortByFeaturedIntegrations` - Customizing whether to sort by the default featured integrations' categories. Security Solution has `custom sorting logic` Featured cards: 1. AWS 3. GCP 4. Azure 5. Elastic Defend 6. CrowdStrike (to promote our extended protections/3rd party EDR support) 7. Wiz (or another cloud integration to promote extended protections) 8. Network Packet Capture 9. Osquery Manager 10. ~**Cloud Asset Inventory (need to confirm that's confirmed for 8.16)** - Currently Not Found any integration matched~ <img width="1249" alt="Screenshot 2024-10-08 at 13 31 12" src="https://github.com/user-attachments/assets/95fb03a4-5a7b-4e8f-8b03-ee45b0e18633"> (cherry picked from commit d20c579)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
…195397) (#195428) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Allow custom sorting on integration cards (#195397)](#195397) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-08T14:22:09Z","message":"[SecuritySolution] Allow custom sorting on integration cards (#195397)\n\nPart of https://github.com/elastic/kibana/pull/193131\r\n\r\nIt shows the customised cards without applying the default sorting under\r\nthe `recommended` tab:\r\n\r\nAdded two optional props:\r\n1. `calloutTopSpacerSize` - Props to decide the size of the spacer above\r\ncallout. Security Solution uses this prop to customize the size of the\r\nspacer\r\n2. `sortByFeaturedIntegrations` - Customizing whether to sort by the\r\ndefault featured integrations' categories. Security Solution has `custom\r\nsorting logic`\r\n\r\nFeatured cards:\r\n\r\n1. AWS\r\n3. GCP\r\n4. Azure\r\n5. Elastic Defend\r\n6. CrowdStrike (to promote our extended protections/3rd party EDR\r\nsupport)\r\n7. Wiz (or another cloud integration to promote extended protections)\r\n8. Network Packet Capture\r\n9. Osquery Manager\r\n10. ~**Cloud Asset Inventory (need to confirm that's confirmed for\r\n8.16)** - Currently Not Found any integration matched~\r\n\r\n<img width=\"1249\" alt=\"Screenshot 2024-10-08 at 13 31 12\"\r\nsrc=\"https://github.com/user-attachments/assets/95fb03a4-5a7b-4e8f-8b03-ee45b0e18633\">","sha":"d20c579304b5fd212971bd9ef80cfbbda0932d94","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Fleet","v9.0.0","Team:Threat Hunting:Explore","v8.16.0"],"title":"[SecuritySolution] Allow custom sorting on integration cards","number":195397,"url":"https://github.com/elastic/kibana/pull/195397","mergeCommit":{"message":"[SecuritySolution] Allow custom sorting on integration cards (#195397)\n\nPart of https://github.com/elastic/kibana/pull/193131\r\n\r\nIt shows the customised cards without applying the default sorting under\r\nthe `recommended` tab:\r\n\r\nAdded two optional props:\r\n1. `calloutTopSpacerSize` - Props to decide the size of the spacer above\r\ncallout. Security Solution uses this prop to customize the size of the\r\nspacer\r\n2. `sortByFeaturedIntegrations` - Customizing whether to sort by the\r\ndefault featured integrations' categories. Security Solution has `custom\r\nsorting logic`\r\n\r\nFeatured cards:\r\n\r\n1. AWS\r\n3. GCP\r\n4. Azure\r\n5. Elastic Defend\r\n6. CrowdStrike (to promote our extended protections/3rd party EDR\r\nsupport)\r\n7. Wiz (or another cloud integration to promote extended protections)\r\n8. Network Packet Capture\r\n9. Osquery Manager\r\n10. ~**Cloud Asset Inventory (need to confirm that's confirmed for\r\n8.16)** - Currently Not Found any integration matched~\r\n\r\n<img width=\"1249\" alt=\"Screenshot 2024-10-08 at 13 31 12\"\r\nsrc=\"https://github.com/user-attachments/assets/95fb03a4-5a7b-4e8f-8b03-ee45b0e18633\">","sha":"d20c579304b5fd212971bd9ef80cfbbda0932d94"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195397","number":195397,"mergeCommit":{"message":"[SecuritySolution] Allow custom sorting on integration cards (#195397)\n\nPart of https://github.com/elastic/kibana/pull/193131\r\n\r\nIt shows the customised cards without applying the default sorting under\r\nthe `recommended` tab:\r\n\r\nAdded two optional props:\r\n1. `calloutTopSpacerSize` - Props to decide the size of the spacer above\r\ncallout. Security Solution uses this prop to customize the size of the\r\nspacer\r\n2. `sortByFeaturedIntegrations` - Customizing whether to sort by the\r\ndefault featured integrations' categories. Security Solution has `custom\r\nsorting logic`\r\n\r\nFeatured cards:\r\n\r\n1. AWS\r\n3. GCP\r\n4. Azure\r\n5. Elastic Defend\r\n6. CrowdStrike (to promote our extended protections/3rd party EDR\r\nsupport)\r\n7. Wiz (or another cloud integration to promote extended protections)\r\n8. Network Packet Capture\r\n9. Osquery Manager\r\n10. ~**Cloud Asset Inventory (need to confirm that's confirmed for\r\n8.16)** - Currently Not Found any integration matched~\r\n\r\n<img width=\"1249\" alt=\"Screenshot 2024-10-08 at 13 31 12\"\r\nsrc=\"https://github.com/user-attachments/assets/95fb03a4-5a7b-4e8f-8b03-ee45b0e18633\">","sha":"d20c579304b5fd212971bd9ef80cfbbda0932d94"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #193131
It shows the customised cards without applying the default sorting under the
recommendedtab:Added two optional props:
calloutTopSpacerSize- Props to decide the size of the spacer above callout. Security Solution uses this prop to customize the size of the spacersortByFeaturedIntegrations- Customizing whether to sort by the default featured integrations' categories. Security Solution hascustom sorting logicFeatured cards:
Cloud Asset Inventory (need to confirm that's confirmed for 8.16) - Currently Not Found any integration matched