[SecuritySolution] Add fleet integration#193131
Closed
angorayc wants to merge 59 commits intoelastic:mainfrom
Closed
[SecuritySolution] Add fleet integration#193131angorayc wants to merge 59 commits intoelastic:mainfrom
angorayc wants to merge 59 commits intoelastic:mainfrom
Conversation
…_hub_new_architecture
…_hub_new_architecture
…_hub_new_architecture
…_hub_new_architecture
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
angorayc
force-pushed
the
onboarding-fleet-integration
branch
from
82c2cf3 to
e9d5329
Compare
…_hub_new_architecture
…_hub_new_architecture' into refactor/onboarding_hub_new_architecture
angorayc
commented
Sep 24, 2024
Comment on lines
405
to
421
Contributor
Author
There was a problem hiding this comment.
This change is to allow customised redirect on cancel:
Screen.Recording.2024-09-24.at.14.14.25.mov
angorayc
commented
Sep 24, 2024
Contributor
Author
There was a problem hiding this comment.
SecuritySolution uses onboardingLink url param to get the back link (I'm trying to name it more general, open for suggestion):
Back link video here:
https://github.com/elastic/kibana/pull/193131/files#r1773326131
angorayc
commented
Sep 24, 2024
Contributor
Author
There was a problem hiding this comment.
SecuritySolution uses this api to check the installed packages' count.
2 tasks
angorayc
force-pushed
the
onboarding-fleet-integration
branch
from
8736574 to
ca0da36
Compare
Contributor
Author
|
/ci |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
angorayc
force-pushed
the
onboarding-fleet-integration
branch
from
32298df to
3733369
Compare
angorayc
added a commit
that referenced
this pull request
Oct 3, 2024
## Summary This is the Fleet relevant changes from #193131 1. Add an option to display installation status on package cards. 2. Add options to display spacer in grid, card height, line clamps for card title and description. 3. On the integration details page, if `onboardingLink` and `onboardingAppId` are appended as url params, they will be used as the redirect link after clicking `cancel` or `save and continue` on the installation form page. Please run from this branch and visit Security Solution to test: #193131 https://github.com/user-attachments/assets/40fc155f-d07c-460f-ab70-372e3b43bfc0 https://github.com/user-attachments/assets/06bd0c5e-14b2-4074-b5a1-932a88a1cc6a https://github.com/user-attachments/assets/1ed4ace9-20a7-42ab-9082-4536d6cd643a ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2024
) ## Summary This is the Fleet relevant changes from elastic#193131 1. Add an option to display installation status on package cards. 2. Add options to display spacer in grid, card height, line clamps for card title and description. 3. On the integration details page, if `onboardingLink` and `onboardingAppId` are appended as url params, they will be used as the redirect link after clicking `cancel` or `save and continue` on the installation form page. Please run from this branch and visit Security Solution to test: elastic#193131 https://github.com/user-attachments/assets/40fc155f-d07c-460f-ab70-372e3b43bfc0 https://github.com/user-attachments/assets/06bd0c5e-14b2-4074-b5a1-932a88a1cc6a https://github.com/user-attachments/assets/1ed4ace9-20a7-42ab-9082-4536d6cd643a ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 3d932e1)
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2024
…) (#194863) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Onboarding hub with Fleet integration (#194028)](#194028) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Angela Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-03T16:56:11Z","message":"[SecuritySolution] Onboarding hub with Fleet integration (#194028)\n\n## Summary\r\nThis is the Fleet relevant changes from\r\nhttps://github.com//pull/193131\r\n1. Add an option to display installation status on package cards.\r\n2. Add options to display spacer in grid, card height, line clamps for\r\ncard title and description.\r\n3. On the integration details page, if `onboardingLink` and\r\n`onboardingAppId` are appended as url params, they will be used as the\r\nredirect link after clicking `cancel` or `save and continue` on the\r\ninstallation form page.\r\n\r\nPlease run from this branch and visit Security Solution to test:\r\nhttps://github.com//pull/193131\r\n\r\n\r\nhttps://github.com/user-attachments/assets/40fc155f-d07c-460f-ab70-372e3b43bfc0\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/06bd0c5e-14b2-4074-b5a1-932a88a1cc6a\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1ed4ace9-20a7-42ab-9082-4536d6cd643a\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3d932e18e88a5b093c5be38da27139785d572061","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Fleet","v9.0.0","Team:Threat Hunting:Explore","v8.16.0"],"title":"[SecuritySolution] Onboarding hub with Fleet integration","number":194028,"url":"https://github.com/elastic/kibana/pull/194028","mergeCommit":{"message":"[SecuritySolution] Onboarding hub with Fleet integration (#194028)\n\n## Summary\r\nThis is the Fleet relevant changes from\r\nhttps://github.com//pull/193131\r\n1. Add an option to display installation status on package cards.\r\n2. Add options to display spacer in grid, card height, line clamps for\r\ncard title and description.\r\n3. On the integration details page, if `onboardingLink` and\r\n`onboardingAppId` are appended as url params, they will be used as the\r\nredirect link after clicking `cancel` or `save and continue` on the\r\ninstallation form page.\r\n\r\nPlease run from this branch and visit Security Solution to test:\r\nhttps://github.com//pull/193131\r\n\r\n\r\nhttps://github.com/user-attachments/assets/40fc155f-d07c-460f-ab70-372e3b43bfc0\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/06bd0c5e-14b2-4074-b5a1-932a88a1cc6a\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1ed4ace9-20a7-42ab-9082-4536d6cd643a\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3d932e18e88a5b093c5be38da27139785d572061"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194028","number":194028,"mergeCommit":{"message":"[SecuritySolution] Onboarding hub with Fleet integration (#194028)\n\n## Summary\r\nThis is the Fleet relevant changes from\r\nhttps://github.com//pull/193131\r\n1. Add an option to display installation status on package cards.\r\n2. Add options to display spacer in grid, card height, line clamps for\r\ncard title and description.\r\n3. On the integration details page, if `onboardingLink` and\r\n`onboardingAppId` are appended as url params, they will be used as the\r\nredirect link after clicking `cancel` or `save and continue` on the\r\ninstallation form page.\r\n\r\nPlease run from this branch and visit Security Solution to test:\r\nhttps://github.com//pull/193131\r\n\r\n\r\nhttps://github.com/user-attachments/assets/40fc155f-d07c-460f-ab70-372e3b43bfc0\r\n\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/06bd0c5e-14b2-4074-b5a1-932a88a1cc6a\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1ed4ace9-20a7-42ab-9082-4536d6cd643a\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"3d932e18e88a5b093c5be38da27139785d572061"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
) ## Summary This is the Fleet relevant changes from elastic#193131 1. Add an option to display installation status on package cards. 2. Add options to display spacer in grid, card height, line clamps for card title and description. 3. On the integration details page, if `onboardingLink` and `onboardingAppId` are appended as url params, they will be used as the redirect link after clicking `cancel` or `save and continue` on the installation form page. Please run from this branch and visit Security Solution to test: elastic#193131 https://github.com/user-attachments/assets/40fc155f-d07c-460f-ab70-372e3b43bfc0 https://github.com/user-attachments/assets/06bd0c5e-14b2-4074-b5a1-932a88a1cc6a https://github.com/user-attachments/assets/1ed4ace9-20a7-42ab-9082-4536d6cd643a ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
angorayc
added a commit
that referenced
this pull request
Oct 8, 2024
Part of #193131 It shows the customised cards without applying the default sorting under the `recommended` tab: Added two optional props: 1. `calloutTopSpacerSize` - Props to decide the size of the spacer above callout. Security Solution uses this prop to customize the size of the spacer 2. `sortByFeaturedIntegrations` - Customizing whether to sort by the default featured integrations' categories. Security Solution has `custom sorting logic` Featured cards: 1. AWS 3. GCP 4. Azure 5. Elastic Defend 6. CrowdStrike (to promote our extended protections/3rd party EDR support) 7. Wiz (or another cloud integration to promote extended protections) 8. Network Packet Capture 9. Osquery Manager 10. ~**Cloud Asset Inventory (need to confirm that's confirmed for 8.16)** - Currently Not Found any integration matched~ <img width="1249" alt="Screenshot 2024-10-08 at 13 31 12" src="https://github.com/user-attachments/assets/95fb03a4-5a7b-4e8f-8b03-ee45b0e18633">
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
…#195397) Part of elastic#193131 It shows the customised cards without applying the default sorting under the `recommended` tab: Added two optional props: 1. `calloutTopSpacerSize` - Props to decide the size of the spacer above callout. Security Solution uses this prop to customize the size of the spacer 2. `sortByFeaturedIntegrations` - Customizing whether to sort by the default featured integrations' categories. Security Solution has `custom sorting logic` Featured cards: 1. AWS 3. GCP 4. Azure 5. Elastic Defend 6. CrowdStrike (to promote our extended protections/3rd party EDR support) 7. Wiz (or another cloud integration to promote extended protections) 8. Network Packet Capture 9. Osquery Manager 10. ~**Cloud Asset Inventory (need to confirm that's confirmed for 8.16)** - Currently Not Found any integration matched~ <img width="1249" alt="Screenshot 2024-10-08 at 13 31 12" src="https://github.com/user-attachments/assets/95fb03a4-5a7b-4e8f-8b03-ee45b0e18633"> (cherry picked from commit d20c579)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#189487
It shows featured cards without the search box on the recommended tab; and shows all the cards and a search box on other tabs:
Featured cards:
It persists the search term across tabs when the search box is visible:
When clicking on back button, cancellation button, and save button, it should go back to the security onboarding hub:
Screen.Recording.2024-10-08.at.13.15.12.mov
Screen.Recording.2024-10-08.at.13.13.17.mov
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers