Skip to content

Fix monaco editor functional test service check#195154

Merged
davismcphee merged 2 commits intoelastic:mainfrom
davismcphee:fix-monaco-editor-check
Oct 8, 2024
Merged

Fix monaco editor functional test service check#195154
davismcphee merged 2 commits intoelastic:mainfrom
davismcphee:fix-monaco-editor-check

Conversation

@davismcphee
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee commented Oct 4, 2024

Summary

This PR fixes a monaco editor functional test service check that was added in #193851. The check validates that the editor updates with the correct text content, but it looks like it may run a bit too quickly sometimes before the DOM has a chance to update.

Fixes #194511.
Fixes #194482.
Fixes #194425.
Fixes #194305.

Flaky test runs:

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Oct 4, 2024
@davismcphee davismcphee self-assigned this Oct 4, 2024
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7099

[✅] test/functional/apps/discover/group4/config.ts: 50/50 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group6.ts: 28/50 tests passed.

see run history

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee
Copy link
Copy Markdown
Contributor Author

On the other hand, the failure in this flaky test run looks to be caused by the issue resolved in #195147, not the one causing these failures. Guess we won't get a clean run until one of them is merged:
image

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @davismcphee

Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davismcphee davismcphee merged commit 11ff4a9 into elastic:main Oct 8, 2024
@davismcphee davismcphee deleted the fix-monaco-editor-check branch October 8, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.0.0

Projects

None yet

5 participants