Fix monaco editor functional test service check#195154
Merged
davismcphee merged 2 commits intoelastic:mainfrom Oct 8, 2024
Merged
Fix monaco editor functional test service check#195154davismcphee merged 2 commits intoelastic:mainfrom
davismcphee merged 2 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @davismcphee |
Contributor
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7099[✅] test/functional/apps/discover/group4/config.ts: 50/50 tests passed. |
10 tasks
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Contributor
Author
|
On the other hand, the failure in this flaky test run looks to be caused by the issue resolved in #195147, not the one causing these failures. Guess we won't get a clean run until one of them is merged: |
Contributor
💚 Build Succeeded
Metrics [docs]
cc @davismcphee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR fixes a monaco editor functional test service check that was added in #193851. The check validates that the editor updates with the correct text content, but it looks like it may run a bit too quickly sometimes before the DOM has a chance to update.
Fixes #194511.
Fixes #194482.
Fixes #194425.
Fixes #194305.
Flaky test runs:
Checklist
For maintainers