Add functional tests for painless lab flyout#193851
Merged
fake-haris merged 11 commits intoelastic:mainfrom Sep 27, 2024
Merged
Add functional tests for painless lab flyout#193851fake-haris merged 11 commits intoelastic:mainfrom
fake-haris merged 11 commits intoelastic:mainfrom
Conversation
…ed data-test-subj to request and response fields
fake-haris
added
test_ui_functional
release_note:skip
Contributor
wayneseymour
left a comment
wayneseymour
left a comment
There was a problem hiding this comment.
https://eui.elastic.co/#/editors-syntax/code#code-block
has data-test-subj propery, so that looks great.
wayneseymour
suggested changes
Sep 24, 2024
wayneseymour
suggested changes
Sep 24, 2024
Contributor
wayneseymour
left a comment
wayneseymour
left a comment
There was a problem hiding this comment.
Not bad at all, just a nit one small change
pheyos
reviewed
Sep 25, 2024
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ElenaStoeva
approved these changes
Sep 26, 2024
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for improving the painless lab tests! Do you mind running the flaky test runner to make sure there's no flakyness?
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7022[✅] x-pack/test/functional/apps/painless_lab/config.ts: 25/25 tests passed. |
10 tasks
davismcphee
added a commit
that referenced
this pull request
Oct 8, 2024
## Summary This PR fixes a monaco editor functional test service check that was added in #193851. The check validates that the editor updates with the correct text content, but it looks like it may run a bit too quickly sometimes before the DOM has a chance to update. Fixes #194511. Fixes #194482. Fixes #194425. Fixes #194305. Flaky test runs: - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7099 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set a simple script in code editor.
Validate that request and response in flyout are the expected.
Resolves:(https://github.com/elastic/appex-qa-team/issues/248)