Skip to content

[ResponseOps][Cases]Design Review changes PR 3 #194936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgianaonoleata1904 merged 8 commits into from
Oct 8, 2024
Merged

[ResponseOps][Cases]Design Review changes PR 3 #194936

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5e10a0
Design Review changes PR 3
georgianaonoleata1904 Oct 4, 2024
93b2397
updated test to check if title is rendered corectly
georgianaonoleata1904 Oct 7, 2024
e83b0b8
Merge branch 'main' into design-review-issues-188187-pr3
georgianaonoleata1904 Oct 7, 2024
bbd9fc9
changed fly out title to be 'add template'
georgianaonoleata1904 Oct 8, 2024
25a36a0
Merge branch 'design-review-issues-188187-pr3' of https://github.com/…
georgianaonoleata1904 Oct 8, 2024
00e4e3c
Merge branch 'main' into design-review-issues-188187-pr3
georgianaonoleata1904 Oct 8, 2024
bc430d6
addressed comments
georgianaonoleata1904 Oct 8, 2024
719036c
Merge branch 'main' into design-review-issues-188187-pr3
georgianaonoleata1904 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions x-pack/plugins/cases/public/components/configure_cases/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,10 @@ describe('ConfigureCases', () => {

expect(await screen.findByTestId('common-flyout')).toBeInTheDocument();

expect(await screen.findByTestId('common-flyout-header')).toHaveTextContent(
i18n.EDIT_CUSTOM_FIELD
);

await userEvent.click(screen.getByTestId('custom-field-label-input'));
await userEvent.paste('!!');
await userEvent.click(screen.getByTestId('text-custom-field-required'));
Expand Down Expand Up @@ -941,6 +945,10 @@ describe('ConfigureCases', () => {
await userEvent.click(screen.getByTestId('add-custom-field'));

expect(await screen.findByTestId('common-flyout')).toBeInTheDocument();

expect(await screen.findByTestId('common-flyout-header')).toHaveTextContent(
i18n.ADD_CUSTOM_FIELD
);
});

it('closes fly out for when click on cancel', async () => {
Expand Down Expand Up @@ -1177,6 +1185,10 @@ describe('ConfigureCases', () => {

expect(await screen.findByTestId('common-flyout')).toBeInTheDocument();

expect(await screen.findByTestId('common-flyout-header')).toHaveTextContent(
i18n.EDIT_TEMPLATE
);

await userEvent.clear(await screen.findByTestId('template-name-input'));
await userEvent.click(await screen.findByTestId('template-name-input'));
await userEvent.paste('Updated template name');
Expand Down
8 changes: 6 additions & 2 deletions x-pack/plugins/cases/public/components/configure_cases/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,9 @@ export const ConfigureCases: React.FC = React.memo(() => {
}
onCloseFlyout={onCloseCustomFieldFlyout}
onSaveField={onCustomFieldSave}
renderHeader={() => <span>{i18n.ADD_CUSTOM_FIELD}</span>}
renderHeader={() => (
<span>{!customFieldToEdit ? i18n.ADD_CUSTOM_FIELD : i18n.EDIT_CUSTOM_FIELD} </span>
Comment thread
georgianaonoleata1904 marked this conversation as resolved.
Outdated
)}
>
{({ onChange }) => (
<CustomFieldsForm onChange={onChange} initialValue={customFieldToEdit} />
Expand All @@ -504,7 +506,9 @@ export const ConfigureCases: React.FC = React.memo(() => {
}
onCloseFlyout={onCloseTemplateFlyout}
onSaveField={onTemplateSave}
renderHeader={() => <span>{i18n.CREATE_TEMPLATE}</span>}
renderHeader={() => (
<span>{!templateToEdit ? i18n.CREATE_TEMPLATE : i18n.EDIT_TEMPLATE}</span>
)}
>
{({ onChange }) => (
<TemplateForm
Expand Down
13 changes: 12 additions & 1 deletion x-pack/plugins/cases/public/components/configure_cases/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,17 @@ export const ADD_CUSTOM_FIELD = i18n.translate(
}
);

export const EDIT_CUSTOM_FIELD = i18n.translate(
'xpack.cases.configureCases.customFields.editCustomField',
{
defaultMessage: 'Edit field',
}
);

export const CREATE_TEMPLATE = i18n.translate('xpack.cases.configureCases.templates.flyoutTitle', {
defaultMessage: 'Create template',
defaultMessage: 'Add template',
});

export const EDIT_TEMPLATE = i18n.translate('xpack.cases.configureCases.templates.editTemplate', {
defaultMessage: 'Edit template',
});