[ResponseOps][Cases]Design Review changes PR 3#194936
Merged
georgianaonoleata1904 merged 8 commits intoelastic:mainfrom Oct 8, 2024
Merged
[ResponseOps][Cases]Design Review changes PR 3#194936georgianaonoleata1904 merged 8 commits intoelastic:mainfrom
georgianaonoleata1904 merged 8 commits intoelastic:mainfrom
Conversation
georgianaonoleata1904
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
6 tasks
adcoelho
approved these changes
Oct 7, 2024
Contributor
adcoelho
left a comment
adcoelho
left a comment
There was a problem hiding this comment.
I tested it and it works as expected.
This is a super nitpick but should we have Add template in the header like the button instead of Create template?
For the custom fields, the header is actually Add field.
js-jankisalvi
approved these changes
Oct 7, 2024
jcger
approved these changes
Oct 8, 2024
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11236172334 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
## Summary Closes elastic#188187 - The fly out title now updates appropriately when editing an existing field or template, displaying "Edit field" and "Edit template" respectively. https://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8 (cherry picked from commit c6dd76e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Cases]Design Review changes PR 3 (#194936)](#194936) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"georgiana.onoleata@elastic.co"},"sourceCommit":{"committedDate":"2024-10-08T13:10:24Z","message":"[ResponseOps][Cases]Design Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses #188187 \r\n\r\n- The fly out title now updates appropriately when editing an existing\r\nfield or template, displaying \"Edit field\" and \"Edit template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Cases]Design Review changes PR 3","number":194936,"url":"https://github.com/elastic/kibana/pull/194936","mergeCommit":{"message":"[ResponseOps][Cases]Design Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses #188187 \r\n\r\n- The fly out title now updates appropriately when editing an existing\r\nfield or template, displaying \"Edit field\" and \"Edit template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194936","number":194936,"mergeCommit":{"message":"[ResponseOps][Cases]Design Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses #188187 \r\n\r\n- The fly out title now updates appropriately when editing an existing\r\nfield or template, displaying \"Edit field\" and \"Edit template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <georgiana.onoleata@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #188187
Screen.Recording.2024-10-07.at.13.43.34.mov