Skip to content

[8.x] fix: [Elasticsearch][COGNITION]: Page titles must be unique for each view (#192268)#194572

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192268
Oct 1, 2024
Merged

[8.x] fix: [Elasticsearch][COGNITION]: Page titles must be unique for each view (#192268)#194572
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192268

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…view (elastic#192268)

Closes: elastic/search-team#8215

## Description
Three views (Home, Connectors, and Playground) have page titles that are
just "Elastic". These page titles must be unique for each view so users
who rely on browser tab names/ICO files, screen readers, etc. understand
what page they are currently viewing.

## What was changed:

1. `coreStart.chrome.docTitle.change` method was called for mentioned
places.

## Screen:

### Home

<img width="1092" alt="image"
src="https://github.com/user-attachments/assets/49ba0ba3-3d01-4db1-b04c-f5db6a1eb359">

### Connectors

<img width="882" alt="image"
src="https://github.com/user-attachments/assets/a2baa0ae-245a-4f3d-9470-c114cdd4323f">

### Playground

<img width="882" alt="image"
src="https://github.com/user-attachments/assets/d91ac1dc-429b-44ac-91bc-c61fc4945ff6">

(cherry picked from commit a9455e1)
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchPlayground 7.1KB 7.2KB +30.0B
serverlessSearch 21.0KB 21.1KB +98.0B
total +128.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@kibanamachine kibanamachine merged commit a471bec into elastic:8.x Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants