Skip to content

fix: [Elasticsearch][COGNITION]: Page titles must be unique for each view#192268

Merged
alexwizp merged 10 commits intoelastic:mainfrom
alexwizp:#8215
Oct 1, 2024
Merged

fix: [Elasticsearch][COGNITION]: Page titles must be unique for each view#192268
alexwizp merged 10 commits intoelastic:mainfrom
alexwizp:#8215

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Sep 6, 2024 •
edited by kibanamachine
Loading

Closes: https://github.com/elastic/search-team/issues/8215

Description

Three views (Home, Connectors, and Playground) have page titles that are just "Elastic". These page titles must be unique for each view so users who rely on browser tab names/ICO files, screen readers, etc. understand what page they are currently viewing.

What was changed:

  1. coreStart.chrome.docTitle.change method was called for mentioned places.

Screen:

Home

image

Connectors

image

Playground

image

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Sep 6, 2024

/ci

@alexwizp alexwizp added v8.16.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Accessibility labels Sep 6, 2024
@alexwizp alexwizp marked this pull request as ready for review September 6, 2024 13:34
@alexwizp alexwizp requested a review from a team as a code owner September 6, 2024 13:34
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 6, 2024

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@alexwizp alexwizp added v9.0.0 and removed backport:skip This PR does not require backporting labels Sep 24, 2024
@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Sep 24, 2024

@elastic/search-kibana please have a look

@alexwizp alexwizp added the backport:version Backport to applied version labels label Sep 24, 2024
@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Sep 30, 2024

@sphilipse could you please help me to find someone who can review that PR?

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 1, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchPlayground 7.1KB 7.2KB +30.0B
serverlessSearch 21.0KB 21.0KB +98.0B
total +128.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit a9455e1 into elastic:main Oct 1, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 1, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11125933574

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2024
@alexwizp
fix: [Elasticsearch][COGNITION]: Page titles must be unique for each …
f20627b 
…view (elastic#192268)

Closes: elastic/search-team#8215

## Description
Three views (Home, Connectors, and Playground) have page titles that are
just "Elastic". These page titles must be unique for each view so users
who rely on browser tab names/ICO files, screen readers, etc. understand
what page they are currently viewing.

## What was changed:

1. `coreStart.chrome.docTitle.change` method was called for mentioned
places.

## Screen:

### Home

<img width="1092" alt="image"
src="https://github.com/user-attachments/assets/49ba0ba3-3d01-4db1-b04c-f5db6a1eb359">

### Connectors

<img width="882" alt="image"
src="https://github.com/user-attachments/assets/a2baa0ae-245a-4f3d-9470-c114cdd4323f">

### Playground

<img width="882" alt="image"
src="https://github.com/user-attachments/assets/d91ac1dc-429b-44ac-91bc-c61fc4945ff6">

(cherry picked from commit a9455e1)
@kibanamachine kibanamachine mentioned this pull request Oct 1, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 1, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 1, 2024
@kibanamachine @alexwizp
[8.x] fix: [Elasticsearch][COGNITION]: Page titles must be unique for…
a471bec 
… each view (#192268) (#194572)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Elasticsearch][COGNITION]: Page titles must be unique for each
view (#192268)](#192268)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-01T13:04:54Z","message":"fix:
[Elasticsearch][COGNITION]: Page titles must be unique for each view
(#192268)\n\nCloses:
https://github.com/elastic/search-team/issues/8215\r\n\r\n##
Description\r\nThree views (Home, Connectors, and Playground) have page
titles that are\r\njust \"Elastic\". These page titles must be unique
for each view so users\r\nwho rely on browser tab names/ICO files,
screen readers, etc. understand\r\nwhat page they are currently
viewing.\r\n\r\n## What was changed: \r\n\r\n1.
`coreStart.chrome.docTitle.change` method was called for
mentioned\r\nplaces.\r\n\r\n## Screen: \r\n\r\n### Home\r\n\r\n<img
width=\"1092\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/49ba0ba3-3d01-4db1-b04c-f5db6a1eb359\">\r\n\r\n###
Connectors\r\n\r\n<img width=\"882\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a2baa0ae-245a-4f3d-9470-c114cdd4323f\">\r\n\r\n###
Playground\r\n\r\n<img width=\"882\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d91ac1dc-429b-44ac-91bc-c61fc4945ff6\">","sha":"a9455e17942a3a73d62c2fa612b4ad734c1fbf5d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"fix:
[Elasticsearch][COGNITION]: Page titles must be unique for each
view","number":192268,"url":"https://github.com/elastic/kibana/pull/192268","mergeCommit":{"message":"fix:
[Elasticsearch][COGNITION]: Page titles must be unique for each view
(#192268)\n\nCloses:
https://github.com/elastic/search-team/issues/8215\r\n\r\n##
Description\r\nThree views (Home, Connectors, and Playground) have page
titles that are\r\njust \"Elastic\". These page titles must be unique
for each view so users\r\nwho rely on browser tab names/ICO files,
screen readers, etc. understand\r\nwhat page they are currently
viewing.\r\n\r\n## What was changed: \r\n\r\n1.
`coreStart.chrome.docTitle.change` method was called for
mentioned\r\nplaces.\r\n\r\n## Screen: \r\n\r\n### Home\r\n\r\n<img
width=\"1092\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/49ba0ba3-3d01-4db1-b04c-f5db6a1eb359\">\r\n\r\n###
Connectors\r\n\r\n<img width=\"882\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a2baa0ae-245a-4f3d-9470-c114cdd4323f\">\r\n\r\n###
Playground\r\n\r\n<img width=\"882\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d91ac1dc-429b-44ac-91bc-c61fc4945ff6\">","sha":"a9455e17942a3a73d62c2fa612b4ad734c1fbf5d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192268","number":192268,"mergeCommit":{"message":"fix:
[Elasticsearch][COGNITION]: Page titles must be unique for each view
(#192268)\n\nCloses:
https://github.com/elastic/search-team/issues/8215\r\n\r\n##
Description\r\nThree views (Home, Connectors, and Playground) have page
titles that are\r\njust \"Elastic\". These page titles must be unique
for each view so users\r\nwho rely on browser tab names/ICO files,
screen readers, etc. understand\r\nwhat page they are currently
viewing.\r\n\r\n## What was changed: \r\n\r\n1.
`coreStart.chrome.docTitle.change` method was called for
mentioned\r\nplaces.\r\n\r\n## Screen: \r\n\r\n### Home\r\n\r\n<img
width=\"1092\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/49ba0ba3-3d01-4db1-b04c-f5db6a1eb359\">\r\n\r\n###
Connectors\r\n\r\n<img width=\"882\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a2baa0ae-245a-4f3d-9470-c114cdd4323f\">\r\n\r\n###
Playground\r\n\r\n<img width=\"882\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d91ac1dc-429b-44ac-91bc-c61fc4945ff6\">","sha":"a9455e17942a3a73d62c2fa612b4ad734c1fbf5d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efegurkan efegurkan efegurkan approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexwizp @elasticmachine @kibana-ci @kibanamachine @efegurkan