Skip to content

[EDR Workflows] Connector capability label change #194265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomsonpl merged 4 commits into from
Oct 1, 2024
Merged

[EDR Workflows] Connector capability label change #194265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e961d76
fix placeholder, fix capability label
tomsonpl Sep 27, 2024
e4bf667
fix text
tomsonpl Sep 27, 2024
e4649a4
fix tests
tomsonpl Sep 27, 2024
a9b26b6
Merge branch 'main' into cs-connector-placeholder
tomsonpl Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/actions/common/connector_feature_config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('getConnectorCompatibility', () => {
it('returns the compatibility list for valid feature ids', () => {
expect(
getConnectorCompatibility(['alerting', 'cases', 'uptime', 'siem', 'generativeAIForSecurity'])
).toEqual(['Alerting Rules', 'Cases', 'Generative AI for Security']);
).toEqual(['Alerting Rules', 'Cases', 'Security Solution', 'Generative AI for Security']);
});

it('skips invalid feature ids', () => {
Expand Down
8 changes: 7 additions & 1 deletion x-pack/plugins/actions/common/connector_feature_config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ const compatibilityAlertingRules = i18n.translate(
defaultMessage: 'Alerting Rules',
}
);
const compatibilitySecuritySolution = i18n.translate(
'xpack.actions.availableConnectorFeatures.compatibility.securitySolution',
{
defaultMessage: 'Security Solution',
}
);

const compatibilityCases = i18n.translate(
'xpack.actions.availableConnectorFeatures.compatibility.cases',
Expand Down Expand Up @@ -93,7 +99,7 @@ export const SecuritySolutionFeature: ConnectorFeatureConfig = {
name: i18n.translate('xpack.actions.availableConnectorFeatures.securitySolution', {
defaultMessage: 'Security Solution',
}),
compatibility: compatibilityAlertingRules,
compatibility: compatibilitySecuritySolution,
};

export const GenerativeAIForSecurityFeature: ConnectorFeatureConfig = {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/stack_connectors/public/connector_types/crowdstrike/crowdstrike_connector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@ import {
} from '@kbn/triggers-actions-ui-plugin/public';
import * as i18n from './translations';

const CROWDSTRIKE_DEFAULT_API_URL = 'https://api.crowdstrike.com';
const configFormSchema: ConfigFieldSchema[] = [
{
id: 'url',
label: i18n.URL_LABEL,
isUrlField: true,
defaultValue: CROWDSTRIKE_DEFAULT_API_URL,
},
];

Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/stack_connectors/public/connector_types/crowdstrike/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ export const URL_LABEL = i18n.translate(
export const CLIENT_ID_LABEL = i18n.translate(
'xpack.stackConnectors.security.crowdstrike.config.clientIdTextFieldLabel',
{
defaultMessage: 'Crowdstrike client ID',
defaultMessage: 'Crowdstrike Client ID',
}
);

export const CLIENT_SECRET_LABEL = i18n.translate(
'xpack.stackConnectors.security.crowdstrike.config.clientSecretTextFieldLabel',
{
defaultMessage: 'Client secret',
defaultMessage: 'Client Secret',
}
);

Expand Down
2 changes: 1 addition & 1 deletion .../application/sections/actions_connectors_list/components/actions_connectors_list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ describe('actions_connectors_list', () => {
.at(4)
.find('div[data-test-subj="compatibility-content"]')
.text()
).toBe('Alerting RulesCases');
).toBe('Alerting RulesCasesSecurity Solution');

expect(
wrapper
Expand Down