[EDR Workflows] Connector capability label change#194265
Merged
tomsonpl merged 4 commits intoelastic:mainfrom Oct 1, 2024
Merged
[EDR Workflows] Connector capability label change#194265tomsonpl merged 4 commits intoelastic:mainfrom
tomsonpl merged 4 commits intoelastic:mainfrom
Conversation
tomsonpl
added
release_note:skip
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @tomsonpl |
adcoelho
approved these changes
Oct 1, 2024
Contributor
adcoelho
left a comment
adcoelho
left a comment
There was a problem hiding this comment.
changes the label used for SIEM from Alerting Rules to Security Solution. however if this was done this way on purpose - please tell me 😅
LGTM but I don't know if there was any reason behind this. I did a git blame and @ersin-erdal was the culprit. Any idea? 😅
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11125773851 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
(cherry picked from commit a5caba8)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
…94568) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] Connector capability label change (#194265)](#194265) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tomasz Ciecierski","email":"tomasz.ciecierski@elastic.co"},"sourceCommit":{"committedDate":"2024-10-01T12:55:48Z","message":"[EDR Workflows] Connector capability label change (#194265)","sha":"a5caba88390449500c28a249f23b910d7d87f16b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","backport:version"],"title":"[EDR Workflows] Connector capability label change","number":194265,"url":"https://github.com/elastic/kibana/pull/194265","mergeCommit":{"message":"[EDR Workflows] Connector capability label change (#194265)","sha":"a5caba88390449500c28a249f23b910d7d87f16b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194265","number":194265,"mergeCommit":{"message":"[EDR Workflows] Connector capability label change (#194265)","sha":"a5caba88390449500c28a249f23b910d7d87f16b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Alerting RulestoSecurity Solution. however if this was done this way on purpose - please tell me 😅Before:
After: