Skip to content

[8.x] Delete imports/references to EUI's distributed `.css` files (#194082) #194200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kibanamachine wants to merge 1 commit into from
Closed

[8.x] Delete imports/references to EUI's distributed `.css` files (#194082) #194200

kibanamachine wants to merge 1 commit into from

Conversation

@kibanamachine
Copy link
Contributor

@kibanamachine kibanamachine commented Sep 26, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@cee-chen
Delete imports/references to EUI's distributed .css files (elastic#…
e9571aa 
…194082)

## Summary

These files no longer contain any meaningful CSS used within Kibana as
of EUI's completed Emotion migration, and can be safely removed. EUI
will shortly no longer distribute these static `.css` files (although
`.scss` src files will still remain exported for the near future).

(cherry picked from commit 9956c9a)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Sep 26, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) September 26, 2024 17:17
@kibanamachine kibanamachine mentioned this pull request Sep 26, 2024
Merged
@kibana-ci
Copy link

kibana-ci commented Sep 26, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #55 / a11y tests using flights sample data Discover a11y tests a11y test for actions on a field
  • [job] [logs] FTR Configs #55 / a11y tests using flights sample data Discover a11y tests a11y test for actions on a field
  • [job] [logs] FTR Configs #20 / context app "after all" hook: afterTestSuite.trigger in "context app"
  • [job] [logs] FTR Configs #20 / context app "after all" hook: afterTestSuite.trigger in "context app"
  • [job] [logs] FTR Configs #20 / context app context filters "after all" hook: afterTestSuite.trigger for "should display the negated values correctly"
  • [job] [logs] FTR Configs #20 / context app context filters "after all" hook: afterTestSuite.trigger for "should display the negated values correctly"
  • [job] [logs] FTR Configs #20 / context app context filters inclusive filter should be addable via expanded data grid rows
  • [job] [logs] FTR Configs #20 / context app context filters inclusive filter should be addable via expanded data grid rows
  • [job] [logs] FTR Configs #10 / dashboard app - group 2 dashboard filter bar saved search filtering are added when a cell magnifying glass is clicked
  • [job] [logs] FTR Configs #10 / dashboard app - group 2 dashboard filter bar saved search filtering are added when a cell magnifying glass is clicked
  • [job] [logs] FTR Configs #39 / discover "after all" hook: afterTestSuite.trigger in "discover"
  • [job] [logs] FTR Configs #39 / discover "after all" hook: afterTestSuite.trigger in "discover"
  • [job] [logs] FTR Configs #59 / Discover alerting Search source Alert should navigate to alert results via link provided in notification
  • [job] [logs] FTR Configs #59 / Discover alerting Search source Alert should navigate to alert results via link provided in notification
  • [job] [logs] FTR Configs #39 / discover discover field visualize button "after all" hook: afterTestSuite.trigger for "should default title when saving chart in Discover (even when modal is closed and reopened)"
  • [job] [logs] FTR Configs #39 / discover discover field visualize button "after all" hook: afterTestSuite.trigger for "should default title when saving chart in Discover (even when modal is closed and reopened)"
  • [job] [logs] FTR Configs #39 / discover discover field visualize button should allow editing the query in the dashboard
  • [job] [logs] FTR Configs #39 / discover discover field visualize button should allow editing the query in the dashboard
  • [job] [logs] FTR Configs #1 / discover/context_awareness root profile ES|QL mode cell renderers should render custom @timestamp
  • [job] [logs] FTR Configs #1 / discover/context_awareness root profile ES|QL mode cell renderers should render custom @timestamp
  • [job] [logs] FTR Configs #69 / discover/esql discover esql view sorting should sort correctly
  • [job] [logs] FTR Configs #69 / discover/esql discover esql view sorting should sort correctly
  • [job] [logs] FTR Configs #68 / discover/group1 discover test query should modify the time range when a bar is clicked
  • [job] [logs] FTR Configs #68 / discover/group1 discover test query should modify the time range when a bar is clicked
  • [job] [logs] FTR Configs #15 / discover/group2/data_grid2 discover data grid field data tests field data doc view should sort ascending
  • [job] [logs] FTR Configs #15 / discover/group2/data_grid2 discover data grid field data tests field data doc view should sort ascending
  • [job] [logs] FTR Configs #60 / discover/group2/data_grid2 discover data grid footer time field with date type should show footer only for the last page and allow to load more
  • [job] [logs] FTR Configs #60 / discover/group2/data_grid2 discover data grid footer time field with date type should show footer only for the last page and allow to load more
  • [job] [logs] FTR Configs #49 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when sorting
  • [job] [logs] FTR Configs #49 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when sorting
  • [job] [logs] FTR Configs #54 / discover/group4 adhoc data views should update id after data view field edit
  • [job] [logs] FTR Configs #54 / discover/group4 adhoc data views should update id after data view field edit
  • [job] [logs] FTR Configs #33 / discover/group5 discover URL state should merge custom global filters with saved search filters
  • [job] [logs] FTR Configs #33 / discover/group5 discover URL state should merge custom global filters with saved search filters
  • [job] [logs] FTR Configs #43 / discover/group6 discover sidebar "after each" hook for "should show filters by type in ES|QL view"
  • [job] [logs] FTR Configs #43 / discover/group6 discover sidebar "after each" hook for "should show filters by type in ES|QL view"
  • [job] [logs] FTR Configs #43 / discover/group6 discover sidebar field filtering should show filters by type in ES|QL view
  • [job] [logs] FTR Configs #43 / discover/group6 discover sidebar field filtering should show filters by type in ES|QL view
  • [job] [logs] FTR Configs #74 / discover/group7 discover integration with runtime fields editor allows adding custom description to existing fields
  • [job] [logs] FTR Configs #74 / discover/group7 discover integration with runtime fields editor allows adding custom description to existing fields
  • [job] [logs] FTR Configs #4 / lens app - group 2 lens datatable should able to use filters cell actions in table
  • [job] [logs] FTR Configs #4 / lens app - group 2 lens datatable should able to use filters cell actions in table
  • [job] [logs] FTR Configs #15 / machine learning - data frame analytics results view content and total feature importance binary classification job should display the feature importance decision path
  • [job] [logs] FTR Configs #15 / machine learning - data frame analytics results view content and total feature importance binary classification job should display the feature importance decision path
  • [job] [logs] FTR Configs #53 / management scripted fields creating and using Painless numeric scripted fields discover scripted field should sort scripted field value in Discover
  • [job] [logs] FTR Configs #53 / management scripted fields creating and using Painless numeric scripted fields discover scripted field should sort scripted field value in Discover
  • [job] [logs] FTR Configs #48 / Observability Logs Explorer When the logs explorer loads render content virtual column properly on cell expansion with message field should open regular popover
  • [job] [logs] FTR Configs #48 / Observability Logs Explorer When the logs explorer loads render content virtual column properly on cell expansion with message field should open regular popover
  • [job] [logs] FTR Configs #77 / visualize app - group1 embedding a data table should allow to change timerange from the visualization in embedded mode
  • [job] [logs] FTR Configs #77 / visualize app - group1 embedding a data table should allow to change timerange from the visualization in embedded mode

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 148.7KB 125.9KB -22.8KB
kbnUiSharedDeps-npmDll 6.2MB 6.2MB -4.0B
total -22.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cee-chen

jbudz
jbudz requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR was reverted, so making sure this doesn't accidentally get merged

@cee-chen cee-chen closed this Sep 26, 2024
auto-merge was automatically disabled September 26, 2024 22:57

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz requested changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@cee-chen cee-chen

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kibanamachine @kibana-ci @jbudz @cee-chen