Delete imports/references to EUI's distributed .css files
#194082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
release_note:skip
- no longer contains any meaningful or used CSS as of the finished Emotion migration
cee-chen
force-pushed
the
eui/delete-css-file
branch
from
675c833 to
902f610
Compare
2 tasks
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/eui-team (EUI) |
jbudz
approved these changes
Sep 26, 2024
nreese
approved these changes
Sep 26, 2024
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…194082) ## Summary These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static `.css` files (although `.scss` src files will still remain exported for the near future). (cherry picked from commit 9956c9a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
This was reverted with b79dee5. |
Contributor
Author
|
Shucks, was worried about that. It's not totally clear to me what's even in |
cee-chen
added a commit
that referenced
this pull request
Sep 30, 2024
## Summary Trying #194082 again, this time wholly deleting `kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞 Original PR description: > These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static `.css` files (although `.scss` src files will still remain exported for the near future). --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
…194237) ## Summary Trying elastic#194082 again, this time wholly deleting `kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞 Original PR description: > These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static `.css` files (although `.scss` src files will still remain exported for the near future). --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 866adf3)
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…#x60; files (#194237) (#194474) # Backport This will backport the following commits from `main` to `8.x`: - [Delete imports/references to EUI's distributed `.css` files (#194237)](#194237) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T18:37:47Z","message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"866adf37f13c79c06fe426fa822231940132de03","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","ci:project-deploy-elasticsearch","v8.16.0","backport:version"],"title":"Delete imports/references to EUI's distributed `.css` files","number":194237,"url":"https://github.com/elastic/kibana/pull/194237","mergeCommit":{"message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194237","number":194237,"mergeCommit":{"message":"Delete imports/references to EUI's distributed `.css` files (#194237)\n\n## Summary\r\n\r\nTrying #194082 again, this time wholly deleting\r\n`kbn-ui-shared-deps-npm.v8.light/dark.css` as well 🤞\r\n\r\nOriginal PR description: \r\n\r\n> These files no longer contain any meaningful CSS used within Kibana as\r\nof EUI's completed Emotion migration, and can be safely removed. EUI\r\nwill shortly no longer distribute these static `.css` files (although\r\n`.scss` src files will still remain exported for the near future).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"866adf37f13c79c06fe426fa822231940132de03"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These files no longer contain any meaningful CSS used within Kibana as of EUI's completed Emotion migration, and can be safely removed. EUI will shortly no longer distribute these static
.cssfiles (although.scsssrc files will still remain exported for the near future).