Skip to content

[Security Solution] Cypress: Also cleanup proxy handler projects #192213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkirchan merged 14 commits into from
Feb 12, 2025
Merged

[Security Solution] Cypress: Also cleanup proxy handler projects #192213

Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
24933a7
Very simple attempt at proxy cleanup
jesse-sant Aug 23, 2024
38ec6ca
Missed a ;
jesse-sant Aug 26, 2024
c4dd9ac
Merge branch 'main' into cypress_also_cleanup_proxy_handler
jesse-sant Sep 4, 2024
fb0013c
Better variable declaration
jesse-sant Sep 5, 2024
495141d
Merge branch 'main' into cypress_also_cleanup_proxy_handler
elasticmachine Sep 13, 2024
16b2630
Merge branch 'main' into cypress_also_cleanup_proxy_handler
maximpn Sep 25, 2024
bbc1e9e
Merge branch 'main' into cypress_also_cleanup_proxy_handler
jesse-sant Oct 18, 2024
2ffc471
Merge branch 'main' into cypress_also_cleanup_proxy_handler
jesse-sant Dec 2, 2024
e76d33f
Merge branch 'main' into cypress_also_cleanup_proxy_handler
jesse-sant Feb 5, 2025
a6a4ada
Merge branch 'main' into cypress_also_cleanup_proxy_handler
dkirchan Feb 11, 2025
c313b4f
Merge branch 'main' into cypress_also_cleanup_proxy_handler
dkirchan Feb 11, 2025
5446b08
Merge branch 'main' into cypress_also_cleanup_proxy_handler
MadameSheema Feb 12, 2025
d090ab7
Merge branch 'main' into cypress_also_cleanup_proxy_handler
MadameSheema Feb 12, 2025
ee369c2
Merge branch 'main' into cypress_also_cleanup_proxy_handler
dkirchan Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,10 @@ ${JSON.stringify(cypressConfigFile, null, 2)}
if (cloudHandler instanceof CloudHandler) {

@maximpn maximpn Sep 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd move a cleanup task to a function for better readability and modularability.

@jesse-sant jesse-sant Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, however I am still learning this code structure, and the next task I am working on is generalizing functionality in the parallel and parallel_serverless scripts out into a common file. I think that PR would be a better place for restructuring something like this call.

command = `curl -X DELETE ${BASE_ENV_URL}/api/v1/serverless/projects/security/${project.id} -H "Authorization: ApiKey ${API_KEY}"`;
exec(command);
} else if (cloudHandler instanceof ProxyHandler) {
const proxyAuth = btoa(`${PROXY_CLIENT_ID}:${PROXY_SECRET}`);
command = `curl -X DELETE ${PROXY_URL}/projects/${project.id} -H "Authorization: Basic ${proxyAuth}"`;
exec(command);
}
});

Expand Down