[Security Solution] Cypress: Also cleanup proxy handler projects#192213
Merged
dkirchan merged 14 commits intoelastic:mainfrom Feb 12, 2025
Merged
[Security Solution] Cypress: Also cleanup proxy handler projects#192213dkirchan merged 14 commits intoelastic:mainfrom
dkirchan merged 14 commits intoelastic:mainfrom
Conversation
jesse-sant
added
release_note:skip
jesse-sant
requested review from
MadameSheema,
banderror,
maximpn and
patrykkopycinski
as code owners
maximpn
approved these changes
Sep 9, 2024
| @@ -464,6 +464,10 @@ ${JSON.stringify(cypressConfigFile, null, 2)} | |||
| if (cloudHandler instanceof CloudHandler) { | |||
Contributor
There was a problem hiding this comment.
nit: I'd move a cleanup task to a function for better readability and modularability.
Contributor
Author
There was a problem hiding this comment.
I agree, however I am still learning this code structure, and the next task I am working on is generalizing functionality in the parallel and parallel_serverless scripts out into a common file. I think that PR would be a better place for restructuring something like this call.
dkirchan
approved these changes
Sep 13, 2024
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jesse-sant |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @jesse-sant |
This was referenced Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on a request in this issue. The Cypress cleanup task for serverless testing didn't include a command to cleanup the project tested against when that project was created using the proxy handler. This PR adds a second conditional method in the cleanup task to cleanup projects with the proxy handler when it is in use.
Checklist
For maintainers