Skip to content

[Automatic Import] resolve a bug in ECS missing fields detection #191502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
P1llus merged 2 commits into from
Aug 27, 2024
Merged

[Automatic Import] resolve a bug in ECS missing fields detection #191502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82029c7
resolve a bug in missing fields detection
P1llus Aug 27, 2024
24ec789
make the recursion a bit more simplified now
P1llus Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions x-pack/plugins/integration_assistant/server/graphs/ecs/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
*/
/* eslint-disable @typescript-eslint/no-explicit-any */
import { ECS_FULL } from '../../../common/ecs';
import type { EcsBaseNodeParams } from './types';
import { ECS_RESERVED } from './constants';
import type { EcsBaseNodeParams } from './types';

const valueFieldKeys = new Set(['target', 'confidence', 'date_formats', 'type']);
type AnyObject = Record<string, any>;
Expand All @@ -22,15 +22,10 @@ function extractKeys(data: AnyObject, prefix: string = ''): Set<string> {
// Directly add the key for arrays without iterating over elements
keys.add(fullKey);
} else if (typeof value === 'object' && value !== null) {
const valueKeys = new Set(Object.keys(value));

if ([...valueFieldKeys].every((k) => valueKeys.has(k))) {
keys.add(fullKey);
} else {
// Recursively extract keys if the current value is a nested object
for (const nestedKey of extractKeys(value, fullKey)) {
keys.add(nestedKey);
}
keys.add(fullKey);
// Recursively extract keys if the current value is a nested object
for (const nestedKey of extractKeys(value, fullKey)) {
keys.add(nestedKey);
}
} else {
// Add the key if the value is not an object or is null
Expand Down