Skip to content

[Automatic Import] resolve a bug in ECS missing fields detection#191502

Merged
P1llus merged 2 commits intoelastic:mainfrom
P1llus:fix_missing_fields
Aug 27, 2024
Merged

[Automatic Import] resolve a bug in ECS missing fields detection#191502
P1llus merged 2 commits intoelastic:mainfrom
P1llus:fix_missing_fields

Conversation

@P1llus
Copy link
Copy Markdown
Member

@P1llus P1llus commented Aug 27, 2024

Summary

Resolves a bug when comparing LLM ECS mapping output with combined samples, and the mapping is right under the data_stream object, providing false positive results.

@P1llus P1llus added bug Fixes for quality problems that affect the customer experience release_note:fix backport:prev-minor Team:Security-Scalability Security Integrations Scalability Team labels Aug 27, 2024
@P1llus P1llus requested a review from a team as a code owner August 27, 2024 13:52
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@P1llus P1llus changed the title resolve a bug in missing fields detection [Automatic Import] resolve a bug in ECS missing fields detection Aug 27, 2024
Copy link
Copy Markdown
Contributor

@ilyannn ilyannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus P1llus self-assigned this Aug 27, 2024
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @P1llus

@P1llus P1llus merged commit fb84360 into elastic:main Aug 27, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [Automatic Import] Adding support for larger samples in ECS graph (#190426)

Manual backport

To create the backport manually run:

node scripts/backport --pr 191502

Questions ?

Please refer to the Backport tool documentation

@P1llus P1llus added backport:skip This PR does not require backporting backport:prev-minor and removed backport:prev-minor backport:skip This PR does not require backporting labels Aug 27, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 191502

Questions ?

Please refer to the Backport tool documentation

P1llus added a commit to P1llus/kibana that referenced this pull request Aug 27, 2024
…stic#191502)

## Summary

Resolves a bug when comparing LLM ECS mapping output with combined
samples, and the mapping is right under the data_stream object,
providing false positive results.

(cherry picked from commit fb84360)

# Conflicts:
#	x-pack/plugins/integration_assistant/server/graphs/ecs/validate.ts
@P1llus
Copy link
Copy Markdown
Member Author

P1llus commented Aug 27, 2024

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@P1llus P1llus added backport:skip This PR does not require backporting backport:prev-minor and removed backport:prev-minor backport:skip This PR does not require backporting labels Aug 27, 2024
P1llus added a commit that referenced this pull request Aug 27, 2024
…on (#191502) (#191526)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Automatic Import] resolve a bug in ECS missing fields detection
(#191502)](#191502)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marius
Iversen","email":"marius.iversen@elastic.co"},"sourceCommit":{"committedDate":"2024-08-27T15:52:00Z","message":"[Automatic
Import] resolve a bug in ECS missing fields detection (#191502)\n\n##
Summary\n\nResolves a bug when comparing LLM ECS mapping output with
combined\nsamples, and the mapping is right under the data_stream
object,\nproviding false positive
results.","sha":"fb84360e2e8dd7ef6d8b72687abcead44329c839","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","backport:prev-minor","v8.16.0","Team:Security-Scalability","v8.15.1"],"number":191502,"url":"https://github.com/elastic/kibana/pull/191502","mergeCommit":{"message":"[Automatic
Import] resolve a bug in ECS missing fields detection (#191502)\n\n##
Summary\n\nResolves a bug when comparing LLM ECS mapping output with
combined\nsamples, and the mapping is right under the data_stream
object,\nproviding false positive
results.","sha":"fb84360e2e8dd7ef6d8b72687abcead44329c839"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191502","number":191502,"mergeCommit":{"message":"[Automatic
Import] resolve a bug in ECS missing fields detection (#191502)\n\n##
Summary\n\nResolves a bug when comparing LLM ECS mapping output with
combined\nsamples, and the mapping is right under the data_stream
object,\nproviding false positive
results.","sha":"fb84360e2e8dd7ef6d8b72687abcead44329c839"}},{"branch":"8.15","label":"v8.15.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 27, 2024
…stic#191502)

## Summary

Resolves a bug when comparing LLM ECS mapping output with combined
samples, and the mapping is right under the data_stream object,
providing false positive results.

(cherry picked from commit fb84360)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@P1llus P1llus added backport:skip This PR does not require backporting and removed backport:prev-minor labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:fix Team:Security-Scalability Security Integrations Scalability Team v8.15.1 v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants