[Fleet] Synthetics installMissingPackage during monitor cruds #191486
Merged
shahzad31 merged 2 commits intoelastic:mainfrom Sep 24, 2024
Merged
[Fleet] Synthetics installMissingPackage during monitor cruds #191486shahzad31 merged 2 commits intoelastic:mainfrom
shahzad31 merged 2 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
Author
|
/ci |
shahzad31
added
the
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Member
|
@shahzad31 - Please try to include more content in PR descriptions. A relevant issue to reference, steps to reproduce, and a summary of the changes would be great to help with productive code review. The PR template for Kibana should have some helpful starting points for this. |
Contributor
Author
|
We are trying to invetigate all the code paths our project monitor API was interacting and after checking APM trace, found multiple API calls which seems excessive while interacting with fleet. I think this is mostly code refactoring category i would say. it's related to this SDH https://github.com/elastic/sdh-synthetics/issues/120 |
dominiqueclarke
approved these changes
Aug 29, 2024
Contributor
dominiqueclarke
left a comment
dominiqueclarke
left a comment
There was a problem hiding this comment.
LGTM, but think a variable naming change might be good.
...olution/synthetics/server/synthetics_service/private_location/synthetics_private_location.ts
Outdated
Show resolved
Hide resolved
Member
|
@shahzad31 what is the status of this PR? |
shahzad31
force-pushed
the
fleet-retries
branch
from
74c2219 to
ca09a53
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
shahzad31
changed the title
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
## Summary Reuse package infos for synthetics bulk ops !! We are just trying to debug Project monitor push API which interacts with fleet code and trying to see what excessive calls are being made, which can be reduced. (cherry picked from commit 6d584d4)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
3 tasks
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
…193846) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Reuse package infos for synthetics bulk ops (#191486)](#191486) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-09-24T10:33:22Z","message":"[Fleet] Reuse package infos for synthetics bulk ops (#191486)\n\n## Summary\r\n\r\n Reuse package infos for synthetics bulk ops !!\r\n\r\nWe are just trying to debug Project monitor push API which interacts\r\nwith fleet code and trying to see what excessive calls are being made,\r\nwhich can be reduced.","sha":"6d584d49a73284077d5331c9c5398593f9edd5ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Fleet] Reuse package infos for synthetics bulk ops","number":191486,"url":"https://github.com/elastic/kibana/pull/191486","mergeCommit":{"message":"[Fleet] Reuse package infos for synthetics bulk ops (#191486)\n\n## Summary\r\n\r\n Reuse package infos for synthetics bulk ops !!\r\n\r\nWe are just trying to debug Project monitor push API which interacts\r\nwith fleet code and trying to see what excessive calls are being made,\r\nwhich can be reduced.","sha":"6d584d49a73284077d5331c9c5398593f9edd5ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191486","number":191486,"mergeCommit":{"message":"[Fleet] Reuse package infos for synthetics bulk ops (#191486)\n\n## Summary\r\n\r\n Reuse package infos for synthetics bulk ops !!\r\n\r\nWe are just trying to debug Project monitor push API which interacts\r\nwith fleet code and trying to see what excessive calls are being made,\r\nwhich can be reduced.","sha":"6d584d49a73284077d5331c9c5398593f9edd5ea"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse package infos for synthetics bulk ops !!
We are just trying to debug Project monitor push API which interacts with fleet code and trying to see what excessive calls are being made, which can be reduced.