[Fleet] Ensure install package during buildPackagePolicyFromPackage

[shahzad31]

Summary

Ensure install package during buildPackagePolicyFromPackage !!

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[obltmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[juliaElastic]

Looks good, it would be good to cover with tests.

[nchaulet]

Looks like it will break the current behavior that uninstall a package if the package was not installed before the package policy creation

https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/routes/package_policy/handlers.ts#L287

[juliaElastic]

Looks like it will break the current behavior that uninstall a package if the package was not installed before the package policy creation

https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/routes/package_policy/handlers.ts#L287

@nchaulet The uninstall only happens if there was an error creating the package policy and the package was not installed before, why is that an issue?

kibana/x-pack/plugins/fleet/server/routes/package_policy/handlers.ts

Lines 302 to 322 in 8266415

	} catch (error) {
	appContextService
	.getLogger()
	.error(`Error while creating package policy due to error: ${error.message}`);
	if (!wasPackageAlreadyInstalled) {
	const installation = await getInstallation({
	savedObjectsClient: soClient,
	pkgName: pkg!.name,
	});
	if (installation) {
	appContextService
	.getLogger()
	.info(`rollback ${pkg!.name}-${pkg!.version} package installation after error`);
	await removeInstallation({
	savedObjectsClient: soClient,
	pkgName: pkg!.name,
	pkgVersion: pkg!.version,
	esClient,
	});
	}
	}

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: 37e7a81
• Interpreting CI Failures

Failed CI Steps

• FTR Configs #14
• FTR Configs #14
• FTR Configs #71
• FTR Configs #71
• FTR Configs #93

Test Failures

• [job] [logs] FTR Configs #71 / Agent policies fleet_agent_policies_with_agents_setup In default space POST /api/fleet/agent_policies should create an enrollment key for the policy
• [job] [logs] FTR Configs #71 / Agent policies fleet_agent_policies_with_agents_setup In default space POST /api/fleet/agent_policies should create an enrollment key for the policy
• [job] [logs] FTR Configs #14 / Agents fleet_upgrade_agent one agent should allow to upgrade a Fleet server agent to a version > fleet server version
• [job] [logs] FTR Configs #14 / Agents fleet_upgrade_agent one agent should allow to upgrade a Fleet server agent to a version > fleet server version
• [job] [logs] FTR Configs #93 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM AWS CIS_AWS Organization Manual Direct Access CIS_AWS Organization Manual Direct Access Workflow

Metrics [docs]

✅ unchanged

History

• 💔 Build #227371 failed ca3064a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[shahzad31]

closing in favour of #191486