Skip to content

[Detection Engine] Fix rule edit success toast #190928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yctercero merged 9 commits into from
Oct 9, 2024
Merged

[Detection Engine] Fix rule edit success toast #190928

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c3b840
have rule edit success toast reflect updated name
yctercero Aug 20, 2024
abd3d83
Merge branch 'main' into teeny_bug_3
yctercero Aug 21, 2024
9f10da0
Merge branch 'main' into teeny_bug_3
yctercero Aug 22, 2024
5b42367
Merge branch 'main' into teeny_bug_3
yctercero Aug 22, 2024
037e734
Merge branch 'main' into teeny_bug_3
yctercero Aug 26, 2024
d087a4a
Merge branch 'main' of github.com:elastic/kibana into teeny_bug_3
yctercero Oct 8, 2024
37d88ea
Merge branch 'teeny_bug_3' of github.com:yctercero/kibana into teeny_…
yctercero Oct 8, 2024
4fee101
Merge branch 'main' into teeny_bug_3
yctercero Oct 8, 2024
ce4cd10
Merge branch 'main' into teeny_bug_3
yctercero Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions ...s/security_solution/public/detection_engine/rule_creation_ui/pages/rule_editing/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { useParams } from 'react-router-dom';

import type { DataViewListItem } from '@kbn/data-views-plugin/common';

import { useAppToasts } from '../../../../common/hooks/use_app_toasts';
import { isEsqlRule } from '../../../../../common/detection_engine/utils';
import { RulePreview } from '../../components/rule_preview';
import { getIsRulePreviewDisabled } from '../../components/rule_preview/helpers';
Expand All @@ -38,7 +39,6 @@ import {
getRuleDetailsUrl,
getDetectionEngineUrl,
} from '../../../../common/components/link_to/redirect_to_detection_engine';
import { displaySuccessToast, useStateToaster } from '../../../../common/components/toasters';
import { SpyRoute } from '../../../../common/utils/route/spy_routes';
import { useUserData } from '../../../../detections/components/user_info';
import { StepPanel } from '../../../rule_creation/components/step_panel';
Expand Down Expand Up @@ -73,7 +73,7 @@ import { CustomHeaderPageMemo } from '..';
import { SaveWithErrorsModal } from '../../components/save_with_errors_confirmation';

const EditRulePageComponent: FC<{ rule: RuleResponse }> = ({ rule }) => {
const [, dispatchToaster] = useStateToaster();
const { addSuccess } = useAppToasts();
const [
{
loading: userInfoLoading,
Expand Down Expand Up @@ -394,7 +394,7 @@ const EditRulePageComponent: FC<{ rule: RuleResponse }> = ({ rule }) => {

const saveChanges = useCallback(async () => {
startTransaction({ name: SINGLE_RULE_ACTIONS.SAVE });
await updateRule({
const updatedRule = await updateRule({
...formatRule<RuleUpdateProps>(
defineStepData,
aboutStepData,
Expand All @@ -406,19 +406,18 @@ const EditRulePageComponent: FC<{ rule: RuleResponse }> = ({ rule }) => {
...(ruleId ? { id: ruleId } : {}),
});

displaySuccessToast(i18n.SUCCESSFULLY_SAVED_RULE(rule?.name ?? ''), dispatchToaster);
addSuccess(i18n.SUCCESSFULLY_SAVED_RULE(updatedRule?.name ?? ''));
navigateToApp(APP_UI_ID, {
deepLinkId: SecurityPageName.rules,
path: getRuleDetailsUrl(ruleId ?? ''),
});
}, [
aboutStepData,
actionsStepData,
addSuccess,
defineStepData,
dispatchToaster,
navigateToApp,
rule?.exceptions_list,
rule?.name,
ruleId,
scheduleStepData,
startTransaction,
Expand Down