[Detection Engine] Fix rule edit success toast#190928
Merged
yctercero merged 9 commits intoelastic:mainfrom Oct 9, 2024
Merged
[Detection Engine] Fix rule edit success toast#190928yctercero merged 9 commits intoelastic:mainfrom
yctercero merged 9 commits intoelastic:mainfrom
Conversation
yctercero
added
release_note:skip
Contributor
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yctercero |
dhurley14
approved these changes
Oct 2, 2024
yctercero
added
v9.0.0
backport:version
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11249043153 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @yctercero |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
## Summary Addresses elastic#122070 (cherry picked from commit 40471ae)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Detection Engine] Fix rule edit success toast (#190928)](#190928) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-09T05:51:55Z","message":"[Detection Engine] Fix rule edit success toast (#190928)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/122070","sha":"40471aedb9816a81e9ae6fcc143a96162068358d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detection Engine","v8.16.0","backport:version"],"title":"[Detection Engine] Fix rule edit success toast","number":190928,"url":"https://github.com/elastic/kibana/pull/190928","mergeCommit":{"message":"[Detection Engine] Fix rule edit success toast (#190928)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/122070","sha":"40471aedb9816a81e9ae6fcc143a96162068358d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190928","number":190928,"mergeCommit":{"message":"[Detection Engine] Fix rule edit success toast (#190928)\n\n## Summary\r\n\r\nAddresses https://github.com/elastic/kibana/issues/122070","sha":"40471aedb9816a81e9ae6fcc143a96162068358d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #122070
Fix
bug_fix_toast.mov