Skip to content

[8.15] [Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)#188892

Merged
parkiino merged 2 commits intoelastic:8.15from
parkiino:backport/8.15/pr-188359
Jul 23, 2024
Merged

[8.15] [Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)#188892
parkiino merged 2 commits intoelastic:8.15from
parkiino:backport/8.15/pr-188359

Conversation

@parkiino
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…kbn package (elastic#188359)

- [x] This is an improvement pr to move all the avc banner logic into a
reusable kibana package (security solution and fleet integrations)
- [x] Compresses the svg used in the banner's  background
- [x] Fixes a bug where the blog link didn't previously open in a new
tab

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 14498a0)
@parkiino parkiino added the backport This PR is a backport of another PR label Jul 23, 2024
@parkiino parkiino enabled auto-merge (squash) July 23, 2024 05:23
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 1205 1206 +1
securitySolution 5612 5613 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/avc-banner - 2 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB -129.0B
securitySolution 17.2MB 17.2MB -60.0B
total -189.0B
Unknown metric groups

API count

id before after diff
@kbn/avc-banner - 2 +2

ESLint disabled line counts

id before after diff
@kbn/avc-banner - 1 +1

miscellaneous assets size

id before after diff
fleet 99.3KB 50.8KB -48.5KB
securitySolution 6.3MB 6.2MB -48.5KB
total -97.0KB

Total ESLint disabled count

id before after diff
@kbn/avc-banner - 1 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino added the Team:Defend Workflows “EDR Workflows” sub-team of Security Solution label Jul 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@parkiino parkiino requested review from a team, ashokaditya and pzl and removed request for a team July 23, 2024 15:42
@parkiino parkiino merged commit 307143b into elastic:8.15 Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants