[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package#188359
Merged
parkiino merged 18 commits intoelastic:mainfrom Jul 18, 2024
Merged
[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package#188359parkiino merged 18 commits intoelastic:mainfrom
parkiino merged 18 commits intoelastic:mainfrom
Conversation
parkiino
added
release_note:skip
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
…into task/avc-banner-package
gergoabraham
approved these changes
Jul 18, 2024
Contributor
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
looking good! nice work on extracting the banner! 🚀
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
parkiino
added a commit
to parkiino/kibana
that referenced
this pull request
Jul 23, 2024
…kbn package (elastic#188359) - [x] This is an improvement pr to move all the avc banner logic into a reusable kibana package (security solution and fleet integrations) - [x] Compresses the svg used in the banner's background - [x] Fixes a bug where the blog link didn't previously open in a new tab --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 14498a0)
parkiino
added a commit
that referenced
this pull request
Jul 23, 2024
…into a kbn package (#188359) (#188892) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)](#188359) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-07-18T23:24:28Z","message":"[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)\n\n## Summary\r\n\r\n- [x] This is an improvement pr to move all the avc banner logic into a\r\nreusable kibana package (security solution and fleet integrations)\r\n- [x] Compresses the svg used in the banner's background \r\n- [x] Fixes a bug where the blog link didn't previously open in a new\r\ntab\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"14498a02214fbd312ad79497783b15ac7deb3b2b","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend Workflows","auto-backport","v8.15.0"],"number":188359,"url":"https://github.com/elastic/kibana/pull/188359","mergeCommit":{"message":"[Security Solution][Admin][AVC Banner] AVC banner logic moved into a kbn package (#188359)\n\n## Summary\r\n\r\n- [x] This is an improvement pr to move all the avc banner logic into a\r\nreusable kibana package (security solution and fleet integrations)\r\n- [x] Compresses the svg used in the banner's background \r\n- [x] Fixes a bug where the blog link didn't previously open in a new\r\ntab\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"14498a02214fbd312ad79497783b15ac7deb3b2b"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary