Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v95.3.0 #187342

Merged
merged 10 commits into from
Jul 13, 2024
Merged

Upgrade EUI to v95.3.0 #187342

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6d894ee
chore: upgrade `@elastic/eui` to v95.3.0
tkajtoch Jul 2, 2024
48cc12a
chore: update i18n
tkajtoch Jul 2, 2024
0918183
test: update import_data_model snapshot
tkajtoch Jul 2, 2024
cd8677d
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Jul 2, 2024
8a73f03
Merge branch 'main' into feat/eui-v95.3.0
tkajtoch Jul 3, 2024
aeef939
Merge branch 'main' into feat/eui-v95.3.0
tkajtoch Jul 4, 2024
bc6729a
Merge branch 'main' into feat/eui-v95.3.0
elasticmachine Jul 8, 2024
2265c3a
Merge branch 'main' into feat/eui-v95.3.0
elasticmachine Jul 10, 2024
93bbf4a
Merge branch 'main' into feat/eui-v95.3.0
elasticmachine Jul 11, 2024
e5d155f
Merge remote-tracking branch 'upstream/main' into feat/eui-v95.3.0
tkajtoch Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"@elastic/ecs": "^8.11.1",
"@elastic/elasticsearch": "^8.14.0",
"@elastic/ems-client": "8.5.1",
"@elastic/eui": "95.2.0",
"@elastic/eui": "95.3.0",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,9 +725,12 @@ export const getEuiContextMapping = (): EuiTokensObject => {
'euiFieldPassword.maskPassword': i18n.translate('core.euiFieldPassword.maskPassword', {
defaultMessage: 'Mask password',
}),
'euiFilePicker.clearSelectedFiles': i18n.translate('core.euiFilePicker.clearSelectedFiles', {
defaultMessage: 'Clear selected files',
}),
'euiFilePicker.removeSelectedAriaLabel': i18n.translate(
'core.euiFilePicker.removeSelectedAriaLabel',
{
defaultMessage: 'Remove selected files',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this copy changed from Clear to Remove? I don't think this functionality deletes anything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change comes from elastic/eui#7860 and originated in https://github.com/elastic/observability-dev/issues/3641.

The Remove EuiFilePicker button previously had an ARIA label, Clear selected files, that didn't match the button's displayed label. Now, the ARIA label matches the display label better. I agree that the usage of remove here could sometimes be misleading, but considering this button is only visible when you select a file from disk, it does make sense.

}
),
'euiFilePicker.filesSelected': ({ fileCount }: EuiValues) =>
i18n.translate('core.euiFilePicker.filesSelected', {
defaultMessage: '{fileCount} files selected',
Expand Down
2 changes: 1 addition & 1 deletion src/dev/license_checker/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const LICENSE_OVERRIDES = {
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint
'@elastic/[email protected]': ['Elastic License 2.0'],
'@elastic/eui@95.2.0': ['SSPL-1.0 OR Elastic License 2.0'],
'@elastic/eui@95.3.0': ['SSPL-1.0 OR Elastic License 2.0'],
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry
'[email protected]': ['MIT'], // license in importing module https://www.npmjs.com/package/binary
'@bufbuild/[email protected]': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause)
Expand Down
4 changes: 2 additions & 2 deletions ...ity_solution/public/common/components/import_data_modal/__snapshots__/index.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,6 @@
"core.euiExternalLinkIcon.newTarget.screenReaderOnlyText": "(s’ouvre dans un nouvel onglet ou une nouvelle fenêtre)",
"core.euiFieldPassword.maskPassword": "Masquer le mot de passe",
"core.euiFieldPassword.showPassword": "Afficher le mot de passe en texte brut. Remarque : votre mot de passe sera visible à l'écran.",
"core.euiFilePicker.clearSelectedFiles": "Effacer les fichiers sélectionnés",
"core.euiFilePicker.promptText": "Sélectionner ou glisser-déposer un fichier",
"core.euiFilePicker.removeSelected": "Supprimer",
"core.euiFlyoutCloseButton.ariaLabel": "Fermer cette boîte de dialogue",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,6 @@
"core.euiExternalLinkIcon.newTarget.screenReaderOnlyText": "（新しいタブまたはウィンドウで開く）",
"core.euiFieldPassword.maskPassword": "パスワードをマスク",
"core.euiFieldPassword.showPassword": "プレーンテキストとしてパスワードを表示します。注記：パスワードは画面上に見えるように表示されます。",
"core.euiFilePicker.clearSelectedFiles": "選択したファイルを消去",
"core.euiFilePicker.promptText": "ファイルを選択するかドラッグ&ドロップしてください",
"core.euiFilePicker.removeSelected": "削除",
"core.euiFlyoutCloseButton.ariaLabel": "このダイアログを閉じる",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,6 @@
"core.euiExternalLinkIcon.newTarget.screenReaderOnlyText": "（在新选项卡或窗口中打开）",
"core.euiFieldPassword.maskPassword": "屏蔽密码",
"core.euiFieldPassword.showPassword": "将密码显示为纯文本。注意：这会将您的密码暴露在屏幕上。",
"core.euiFilePicker.clearSelectedFiles": "清除选定的文件",
"core.euiFilePicker.promptText": "选择或拖放文件",
"core.euiFilePicker.removeSelected": "移除",
"core.euiFlyoutCloseButton.ariaLabel": "关闭此对话框",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,10 +1743,10 @@
resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314"
integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ==

"@elastic/eui@95.2.0":
version "95.2.0"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-95.2.0.tgz#12204f9206f1432e17276264e08e48cd026913bf"
integrity sha512-DVIAqZHox5esbmoxnG3McTw0ppbatvH+ymXYjr3PNNTTnXzmcAGadQAA0ZIpx1/c3/YOZmh2LJWWowLl4wodzw==
"@elastic/eui@95.3.0":
version "95.3.0"
resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-95.3.0.tgz#b880012120f748e71bc2c1e4dbcf5acd514f043e"
integrity sha512-KKe2Yuswm0pnOpEnFdWjnekOqFQpN1rlWLp4MPLQwHTc9hMIujiRfOo66RGgc4K3p8qWhyRl/DxbxXC+NnsKiQ==
dependencies:
"@hello-pangea/dnd" "^16.6.0"
"@types/lodash" "^4.14.202"
Expand Down