Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v95.3.0 #187342

Merged
merged 10 commits into from
Jul 13, 2024
Merged

Upgrade EUI to v95.3.0 #187342

merged 10 commits into from
Jul 13, 2024

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Jul 2, 2024

v95.2.0v95.3.0

Questions? Please see our Kibana upgrade FAQ.


v95.3.0

  • Updated EuiThemeProviders to allow modifying/setting custom breakpoints in nested usage (as opposed to only at the top EuiProvider level) (#7862)

Bug fixes

  • Fixed a Chrome/Edge CSS mask-image bug that was affecting scroll overflow shadow utilties (#7855)

CSS-in-JS conversions

  • Converted EuiColorPicker to Emotion; Removed $euiColorPickerWidth (#7845)
  • Converted EuiColorPickerSwatch to Emotion (#7853)
  • Converted EuiColorPalettePicker and EuiColorPaletteDisplay to Emotion (#7854)
    • Removed $euiColorPaletteDisplaySizes
    • Removed @mixin euiColorPaletteInnerBorder
  • Removed $euiColorPickerValueRange0, $euiColorPickerValueRange1, $euiColorPickerSaturationRange0, $euiColorPickerSaturationRange1, and $euiColorPickerIndicatorSize (#7859)

Accessibility

  • Updated the aria-label attribute for the EuiFilePicker remove file button (#7860)

@tkajtoch tkajtoch self-assigned this Jul 2, 2024
@tkajtoch tkajtoch added backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jul 2, 2024
@tkajtoch
Copy link
Member Author

tkajtoch commented Jul 2, 2024

buildkite test this

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 2, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #58 / @skipInServerless endpoint @ess @serverless For each artifact list under management When on the Event Filters entries list should be able to update an existing Event Filters entry

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alerting 91.5KB 91.5KB +48.0B
dashboard 503.6KB 503.7KB +48.0B
discover 809.4KB 809.5KB +96.0B
infra 1.5MB 1.5MB +193.0B
kubernetesSecurity 212.0KB 212.2KB +192.0B
lens 1.5MB 1.5MB +96.0B
maps 3.0MB 3.0MB +241.0B
ml 4.6MB 4.6MB +96.0B
observability 365.7KB 365.8KB +48.0B
security 587.9KB 588.0KB +48.0B
securitySolution 15.6MB 15.6MB +96.0B
slo 871.0KB 871.1KB +48.0B
spaces 180.6KB 180.6KB +48.0B
unifiedSearch 221.5KB 221.6KB +48.0B
visTypeVega 1.8MB 1.8MB +192.0B
total +1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 417.5KB 417.6KB +107.0B
kbnUiSharedDeps-css 212.7KB 206.6KB -6.1KB
kbnUiSharedDeps-npmDll 6.0MB 6.0MB +6.2KB
triggersActionsUi 114.5KB 114.6KB +48.0B
total +213.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

@asharma-5
Copy link

asharma-5 commented Jul 8, 2024

@tkajtoch this fix will be available in version 8.15.0 ? when can we expect this release?

@tkajtoch tkajtoch marked this pull request as ready for review July 8, 2024 13:13
@tkajtoch tkajtoch requested review from a team as code owners July 8, 2024 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/dev/license_checker/config.ts

'euiFilePicker.removeSelectedAriaLabel': i18n.translate(
'core.euiFilePicker.removeSelectedAriaLabel',
{
defaultMessage: 'Remove selected files',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this copy changed from Clear to Remove? I don't think this functionality deletes anything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change comes from elastic/eui#7860 and originated in https://github.com/elastic/observability-dev/issues/3641.

The Remove EuiFilePicker button previously had an ARIA label, Clear selected files, that didn't match the button's displayed label. Now, the ARIA label matches the display label better. I agree that the usage of remove here could sometimes be misleading, but considering this button is only visible when you select a file from disk, it does make sense.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 10, 2024

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests on Serverless #4 / Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #1 / Endpoint generated alerts "before each" hook for "should create a Detection Engine alert from an endpoint alert" "before each" hook for "should create a Detection Engine alert from an endpoint alert"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #7 / Endpoints page "before all" hook for "Shows endpoint on the list" "before all" hook for "Shows endpoint on the list"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #14 / Response console Execute operations: "before all" hook for ""execute --command" - should execute a command" "before all" hook for ""execute --command" - should execute a command"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #1 / Response console File operations: "before all" hook for ""get-file --path" - should retrieve a file" "before all" hook for ""get-file --path" - should retrieve a file"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #4 / Response console Host Isolation: "before all" hook for "should release an isolated host via response console" "before all" hook for "should release an isolated host via response console"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #5 / Response console Scan operation: "before all" hook for ""scan --path" - should scan a file" "before all" hook for ""scan --path" - should scan a file"

History

cc @tkajtoch

@tkajtoch
Copy link
Member Author

@elasticmachine merge upstream

@tkajtoch tkajtoch enabled auto-merge (squash) July 11, 2024 14:41
@tkajtoch tkajtoch merged commit c299737 into elastic:main Jul 13, 2024
42 checks passed
@cee-chen cee-chen removed the backport:skip This commit does not require backporting label Sep 12, 2024
cee-chen pushed a commit to cee-chen/kibana that referenced this pull request Sep 12, 2024
`v95.2.0`⏩`v95.3.0`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

- Updated `EuiThemeProvider`s to allow modifying/setting custom
`breakpoint`s in nested usage (as opposed to only at the top
`EuiProvider` level) ([elastic#7862](elastic/eui#7862))

**Bug fixes**

- Fixed a Chrome/Edge CSS `mask-image` bug that was affecting scroll
overflow shadow utilties
([elastic#7855](elastic/eui#7855))

**CSS-in-JS conversions**

- Converted `EuiColorPicker` to Emotion; Removed `$euiColorPickerWidth`
([elastic#7845](elastic/eui#7845))
- Converted `EuiColorPickerSwatch` to Emotion
([elastic#7853](elastic/eui#7853))
- Converted `EuiColorPalettePicker` and `EuiColorPaletteDisplay` to
Emotion ([elastic#7854](elastic/eui#7854))
  - Removed `$euiColorPaletteDisplaySizes`
  - Removed `@mixin euiColorPaletteInnerBorder`
- Removed `$euiColorPickerValueRange0`, `$euiColorPickerValueRange1`,
`$euiColorPickerSaturationRange0`, `$euiColorPickerSaturationRange1`,
and `$euiColorPickerIndicatorSize`
([elastic#7859](elastic/eui#7859))

**Accessibility**

- Updated the `aria-label` attribute for the `EuiFilePicker` remove file
button ([elastic#7860](elastic/eui#7860))

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@cee-chen cee-chen added backport:version Backport to applied version labels backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 12, 2024
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 187342

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 187342

Questions ?

Please refer to the Backport tool documentation

@cee-chen cee-chen removed the backport:version Backport to applied version labels label Sep 12, 2024
cee-chen added a commit that referenced this pull request Sep 12, 2024
## Backport

This is a manual backport of EUI v95.3.0 (#187342) which was intended to
target 8.15 but was missed due to the `backport:skip` label.

The release contains a requested visual bugfix for Chromium users:
elastic/eui#7855 (comment)

Co-authored-by: Tomasz Kajtoch <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) EUI release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants