Upgrade EUI to v95.0.0 by tkajtoch · Pull Request #185943 · elastic/kibana

tkajtoch · 2024-06-11T12:27:56Z

v94.6.0 ⏩ v95.0.0-backport.0

Questions? Please see our Kibana upgrade FAQ.

`v95.0.0-backport.0`

This is a backport release only intended for use by Kibana.

Updated EuiSteps to support a new titleSize="xxs" style, which outputs the same title font size but smaller unnumbered step indicators (#7813)
Updated EuiStepsHorizontal to support a new size="xs" style, which outputs smaller unnumbered step indicators (#7813)
Updated EuiStepNumber to support new titleSize="none" which omits rendering step numbers, and will only render icons (#7813)

`v95.0.0`

Added move glyph to EuiIcon (#7789)
Updated EuiBasicTable and EuiInMemoryTables with selection - the header row checkbox will now render an indeterminate state if some (but not all) rows are selected (#7817)

Bug fixes

Fixed an EuiDataGrid visual bug when using lineCount row heights where the clamped text was still visible for some font sizes (#7793)
Fixed EuiSearchBar's filter configs to always respect autoClose: false (#7806)

Breaking changes

Removed deprecated EUI_CHARTS_THEME_DARK, EUI_CHARTS_THEME_LIGHT and EUI_SPARKLINE_THEME_PARTIAL exports (#7682)
Removed deprecated euiPalettePositive and euiPaletteNegative. Use euiPaletteGreen and euiPaletteRed instead (#7808)
Removed type="inList" from EuiCheckbox. Simply omit passing a label prop to render this style of checkbox (#7814)
Removed the unused compressed prop from EuiCheckbox and EuiRadio. This prop was not doing anything on individual components. (#7818)

CSS-in-JS conversions

Converted EuiCheckboxGroup to Emotion (#7818)
Converted EuiRadioGroup to Emotion (#7818)

tkajtoch · 2024-06-12T12:02:11Z

buildkite test this

…ared deps

…EXCLUDE_PREVIOUS_HIST when not set

cee-chen · 2024-06-13T21:23:21Z

/ci

cee-chen · 2024-06-13T22:34:42Z

@tkajtoch I can't seem to repro the Observability Cypress failures locally 😬 Not sure if you can!

tkajtoch · 2024-06-13T22:47:55Z

@cee-chen Same. I tried reproducing these before and after rebase, and they all pass locally

elasticmachine · 2024-06-14T00:38:51Z

Pinging @elastic/eui-team (EUI)

elasticmachine · 2024-06-14T00:58:01Z

Pinging @elastic/fleet (Team:Fleet)

peteharverson

ML changes LGTM

nickpeihl

presentation changes lgtm!

- which needs to get in by 8.15

kpollich

Fleet changes in cypress suites LGTM

kibana-ci · 2024-06-17T18:44:10Z

💚 Build Succeeded

Buildkite Build
Commit: cb748e7
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-185943-cb748e78bde1
Observability Deployment

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ui-shared-deps-src`	47	46	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.5MB	3.5MB	+3.0B
`controls`	202.0KB	202.0KB	-14.0B
`dataViewFieldEditor`	176.3KB	176.3KB	+3.0B
`enterpriseSearch`	2.7MB	2.7MB	-11.0B
`exploratoryView`	182.0KB	182.0KB	+3.0B
`fileUpload`	951.8KB	951.8KB	+3.0B
`fleet`	1.4MB	1.4MB	+16.0B
`indexManagement`	661.7KB	661.7KB	+3.0B
`infra`	1.6MB	1.6MB	-2.0KB
`ingestPipelines`	373.3KB	373.3KB	+3.0B
`kubernetesSecurity`	213.9KB	212.0KB	-1.9KB
`logsShared`	138.4KB	138.4KB	+3.0B
`maps`	3.0MB	3.0MB	-1.9KB
`monitoring`	533.3KB	533.3KB	+3.0B
`security`	587.8KB	587.8KB	-14.0B
`securitySolution`	13.6MB	13.6MB	-11.0B
`stackAlerts`	79.7KB	79.7KB	+34.0B
`synthetics`	1.0MB	1.0MB	+3.0B
`uptime`	467.2KB	467.2KB	-11.0B
`visTypeVega`	1.8MB	1.8MB	-2.0KB
total			-7.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	415.4KB	415.5KB	+114.0B
`kbnUiSharedDeps-css`	241.2KB	240.9KB	-241.0B
`kbnUiSharedDeps-npmDll`	6.3MB	6.0MB	-310.7KB
`kbnUiSharedDeps-srcJs`	3.2MB	3.2MB	-104.0B
`observability`	123.0KB	123.0KB	+3.0B
total			-310.9KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/ui-shared-deps-src`	56	55	-1

History

💛 Build #216186 was flaky 7119095
💛 Build #215922 was flaky d6bd05e
💔 Build #215913 failed ae796e9
💔 Build #215802 failed 2181962

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

efegurkan

Enterprise Search/Search area changes look good.

justinkambic

Infra Services change LGTM

`v94.6.0` ⏩ `v95.0.0-backport.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.0.0-backport.0`](https://github.com/elastic/eui/releases/v95.0.0-backport.0) **This is a backport release only intended for use by Kibana.** - Updated `EuiSteps` to support a new `titleSize="xxs"` style, which outputs the same title font size but smaller unnumbered step indicators ([elastic#7813](elastic/eui#7813)) - Updated `EuiStepsHorizontal` to support a new `size="xs"` style, which outputs smaller unnumbered step indicators ([elastic#7813](elastic/eui#7813)) - Updated `EuiStepNumber` to support new `titleSize="none"` which omits rendering step numbers, and will only render icons ([elastic#7813](elastic/eui#7813)) ## [`v95.0.0`](https://github.com/elastic/eui/releases/v95.0.0) - Added `move` glyph to `EuiIcon` ([elastic#7789](elastic/eui#7789)) - Updated `EuiBasicTable` and `EuiInMemoryTable`s with `selection` - the header row checkbox will now render an indeterminate state if some (but not all) rows are selected ([elastic#7817](elastic/eui#7817)) **Bug fixes** - Fixed an `EuiDataGrid` visual bug when using `lineCount` row heights where the clamped text was still visible for some font sizes ([elastic#7793](elastic/eui#7793)) - Fixed `EuiSearchBar`'s filter configs to always respect `autoClose: false` ([elastic#7806](elastic/eui#7806)) **Breaking changes** - Removed deprecated `EUI_CHARTS_THEME_DARK`, `EUI_CHARTS_THEME_LIGHT` and `EUI_SPARKLINE_THEME_PARTIAL` exports ([elastic#7682](elastic/eui#7682)) - Removed deprecated `euiPalettePositive` and `euiPaletteNegative`. Use `euiPaletteGreen` and `euiPaletteRed` instead ([elastic#7808](elastic/eui#7808)) - Removed `type="inList"` from `EuiCheckbox`. Simply omit passing a `label` prop to render this style of checkbox ([elastic#7814](elastic/eui#7814)) - Removed the unused `compressed` prop from `EuiCheckbox` and `EuiRadio`. This prop was not doing anything on individual components. ([elastic#7818](elastic/eui#7818)) **CSS-in-JS conversions** - Converted `EuiCheckboxGroup` to Emotion ([elastic#7818](elastic/eui#7818)) - Converted `EuiRadioGroup` to Emotion ([elastic#7818](elastic/eui#7818)) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>

tkajtoch added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting v8.15.0 labels Jun 11, 2024

tkajtoch self-assigned this Jun 11, 2024

tkajtoch force-pushed the feat/eui-95.0.0 branch 4 times, most recently from a9c142b to 5b06765 Compare June 12, 2024 12:02

tkajtoch force-pushed the feat/eui-95.0.0 branch from 5b06765 to 2220cc4 Compare June 12, 2024 20:55

tkajtoch added 8 commits June 13, 2024 13:10

chore: upgrade @elastic/eui to v95.0.0

afa4817

build: remove deprecated @elastic/eui/dist/eui_charts_theme from sh…

e392d9e

…ared deps

chore: update i18n_eui_mapping

28742a3

test: update snapshots

9db17b1

feat: remove usages of unused compressed prop from EuiCheckbox

c8ae9d9

fix: ensure excludeHitsFromPreviousRun fallbacks to DEFAULT_VALUES.…

afc6fed

…EXCLUDE_PREVIOUS_HIST when not set

fix: use clear selection bulk action to deselect tags

08a6586

test: update fleet radio button selectors

531877e

tkajtoch force-pushed the feat/eui-95.0.0 branch from 2220cc4 to 531877e Compare June 13, 2024 11:10

tkajtoch and others added 2 commits June 13, 2024 15:37

style: reformat code

2181962

[Fleet] Update EuiRadioGroup wrapping to account for new Emotion styles

ae796e9

Merge branch 'main' into feat/eui-95.0.0

d6bd05e

cee-chen marked this pull request as ready for review June 14, 2024 00:38

cee-chen requested review from a team as code owners June 14, 2024 00:38

cee-chen requested a review from a team June 14, 2024 00:38

cee-chen requested review from a team as code owners June 14, 2024 00:38

Ikuni17 approved these changes Jun 14, 2024

View reviewed changes

botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 14, 2024

pgayvallet approved these changes Jun 14, 2024

View reviewed changes

smith added the apm:review label Jun 14, 2024

elena-shostak approved these changes Jun 17, 2024

View reviewed changes

adcoelho approved these changes Jun 17, 2024

View reviewed changes

peteharverson approved these changes Jun 17, 2024

View reviewed changes

rshen91 approved these changes Jun 17, 2024

View reviewed changes

nickpeihl approved these changes Jun 17, 2024

View reviewed changes

cee-chen and others added 2 commits June 17, 2024 08:47

Merge branch 'main' into feat/eui-95.0.0

7119095

EUI backport with unordered steps feature

cb748e7

- which needs to get in by 8.15

kpollich approved these changes Jun 17, 2024

View reviewed changes

spong approved these changes Jun 17, 2024

View reviewed changes

efegurkan approved these changes Jun 18, 2024

View reviewed changes

justinkambic approved these changes Jun 18, 2024

View reviewed changes

cee-chen merged commit 946a255 into elastic:main Jun 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v95.0.0#185943

Upgrade EUI to v95.0.0#185943
cee-chen merged 13 commits intoelastic:mainfrom
tkajtoch:feat/eui-95.0.0

tkajtoch commented Jun 11, 2024 •

edited by cee-chen

Loading

Uh oh!

tkajtoch commented Jun 12, 2024

Uh oh!

cee-chen commented Jun 13, 2024

Uh oh!

cee-chen commented Jun 13, 2024

Uh oh!

tkajtoch commented Jun 13, 2024

Uh oh!

elasticmachine commented Jun 14, 2024

Uh oh!

elasticmachine commented Jun 14, 2024

Uh oh!

peteharverson left a comment

Uh oh!

nickpeihl left a comment

Uh oh!

kpollich left a comment

Uh oh!

kibana-ci commented Jun 17, 2024 •

edited

Loading

API count

Uh oh!

efegurkan left a comment

Uh oh!

justinkambic left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Conversation

tkajtoch commented Jun 11, 2024 • edited by cee-chen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v95.0.0-backport.0

v95.0.0

Uh oh!

tkajtoch commented Jun 12, 2024

Uh oh!

cee-chen commented Jun 13, 2024

Uh oh!

cee-chen commented Jun 13, 2024

Uh oh!

tkajtoch commented Jun 13, 2024

Uh oh!

elasticmachine commented Jun 14, 2024

Uh oh!

elasticmachine commented Jun 14, 2024

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

nickpeihl left a comment

Choose a reason for hiding this comment

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

efegurkan left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

tkajtoch commented Jun 11, 2024 •

edited by cee-chen

Loading

`v95.0.0-backport.0`

`v95.0.0`

kibana-ci commented Jun 17, 2024 •

edited

Loading