chore: fully remove deprecated charts theming exports by nickofthyme · Pull Request #7682 · elastic/eui

nickofthyme · 2024-04-12T17:53:46Z

Summary

Removes all exports and build processes related to chart theming that were deprecated in #7572.

Following merging of elastic/kibana#179503, the EUI_SPARKLINE_THEME_PARTIAL is no longer used in kibana and can be fully removed. Usages of EUI_CHARTS_THEME_DARK and EUI_CHARTS_THEME_LIGHT were removed in elastic/kibana#170914.

BREAKING CHANGE: Removed EUI_CHARTS_THEME_DARK, EUI_CHARTS_THEME_LIGHT and EUI_SPARKLINE_THEME_PARTIAL exports.

github-actions · 2024-04-12T17:54:00Z

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

If this PR contains prop/API changes:
- Search through Kibana for <EuiComponent usages (example search)
- In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)

Log | Bot Usage

cee-chen · 2024-04-12T17:55:22Z

We have this scheduled for June as a heads up Nick (#1469) - are you cool keeping this PR open until then?

nickofthyme · 2024-04-12T18:02:50Z

We have this scheduled for June as a heads up Nick (#1469) - are you cool keeping this PR open until then?

Yeah absolutely, just want to get it off my plate. I'll keep it as a draft PR until then, I also updated the meta issue to point to this PR.

packages/eui/changelogs/upcoming/7682.md

cee-chen

🎉 Thanks again so much for this work Nick, you rock!! And happy 5th work anniversary!!

kibanamachine · 2024-06-03T18:35:50Z

Preview staging links for this PR:

Docs site: https://eui.elastic.co/pr_7682/
Storybook: https://eui.elastic.co/pr_7682/storybook

elasticmachine · 2024-06-03T18:37:24Z

💚 Build Succeeded

Buildkite Build
Commit: 61c0775

History

💚 Build #1749 succeeded daf373d

`v94.6.0` ⏩ `v95.0.0-backport.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.0.0-backport.0`](https://github.com/elastic/eui/releases/v95.0.0-backport.0) **This is a backport release only intended for use by Kibana.** - Updated `EuiSteps` to support a new `titleSize="xxs"` style, which outputs the same title font size but smaller unnumbered step indicators ([#7813](elastic/eui#7813)) - Updated `EuiStepsHorizontal` to support a new `size="xs"` style, which outputs smaller unnumbered step indicators ([#7813](elastic/eui#7813)) - Updated `EuiStepNumber` to support new `titleSize="none"` which omits rendering step numbers, and will only render icons ([#7813](elastic/eui#7813)) ## [`v95.0.0`](https://github.com/elastic/eui/releases/v95.0.0) - Added `move` glyph to `EuiIcon` ([#7789](elastic/eui#7789)) - Updated `EuiBasicTable` and `EuiInMemoryTable`s with `selection` - the header row checkbox will now render an indeterminate state if some (but not all) rows are selected ([#7817](elastic/eui#7817)) **Bug fixes** - Fixed an `EuiDataGrid` visual bug when using `lineCount` row heights where the clamped text was still visible for some font sizes ([#7793](elastic/eui#7793)) - Fixed `EuiSearchBar`'s filter configs to always respect `autoClose: false` ([#7806](elastic/eui#7806)) **Breaking changes** - Removed deprecated `EUI_CHARTS_THEME_DARK`, `EUI_CHARTS_THEME_LIGHT` and `EUI_SPARKLINE_THEME_PARTIAL` exports ([#7682](elastic/eui#7682)) - Removed deprecated `euiPalettePositive` and `euiPaletteNegative`. Use `euiPaletteGreen` and `euiPaletteRed` instead ([#7808](elastic/eui#7808)) - Removed `type="inList"` from `EuiCheckbox`. Simply omit passing a `label` prop to render this style of checkbox ([#7814](elastic/eui#7814)) - Removed the unused `compressed` prop from `EuiCheckbox` and `EuiRadio`. This prop was not doing anything on individual components. ([#7818](elastic/eui#7818)) **CSS-in-JS conversions** - Converted `EuiCheckboxGroup` to Emotion ([#7818](elastic/eui#7818)) - Converted `EuiRadioGroup` to Emotion ([#7818](elastic/eui#7818)) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>

`v94.6.0` ⏩ `v95.0.0-backport.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.0.0-backport.0`](https://github.com/elastic/eui/releases/v95.0.0-backport.0) **This is a backport release only intended for use by Kibana.** - Updated `EuiSteps` to support a new `titleSize="xxs"` style, which outputs the same title font size but smaller unnumbered step indicators ([elastic#7813](elastic/eui#7813)) - Updated `EuiStepsHorizontal` to support a new `size="xs"` style, which outputs smaller unnumbered step indicators ([elastic#7813](elastic/eui#7813)) - Updated `EuiStepNumber` to support new `titleSize="none"` which omits rendering step numbers, and will only render icons ([elastic#7813](elastic/eui#7813)) ## [`v95.0.0`](https://github.com/elastic/eui/releases/v95.0.0) - Added `move` glyph to `EuiIcon` ([elastic#7789](elastic/eui#7789)) - Updated `EuiBasicTable` and `EuiInMemoryTable`s with `selection` - the header row checkbox will now render an indeterminate state if some (but not all) rows are selected ([elastic#7817](elastic/eui#7817)) **Bug fixes** - Fixed an `EuiDataGrid` visual bug when using `lineCount` row heights where the clamped text was still visible for some font sizes ([elastic#7793](elastic/eui#7793)) - Fixed `EuiSearchBar`'s filter configs to always respect `autoClose: false` ([elastic#7806](elastic/eui#7806)) **Breaking changes** - Removed deprecated `EUI_CHARTS_THEME_DARK`, `EUI_CHARTS_THEME_LIGHT` and `EUI_SPARKLINE_THEME_PARTIAL` exports ([elastic#7682](elastic/eui#7682)) - Removed deprecated `euiPalettePositive` and `euiPaletteNegative`. Use `euiPaletteGreen` and `euiPaletteRed` instead ([elastic#7808](elastic/eui#7808)) - Removed `type="inList"` from `EuiCheckbox`. Simply omit passing a `label` prop to render this style of checkbox ([elastic#7814](elastic/eui#7814)) - Removed the unused `compressed` prop from `EuiCheckbox` and `EuiRadio`. This prop was not doing anything on individual components. ([elastic#7818](elastic/eui#7818)) **CSS-in-JS conversions** - Converted `EuiCheckboxGroup` to Emotion ([elastic#7818](elastic/eui#7818)) - Converted `EuiRadioGroup` to Emotion ([elastic#7818](elastic/eui#7818)) --------- Co-authored-by: Cee Chen <constance.chen@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>

chore: fully remove deprecated charts theming exports

441bded

nickofthyme added breaking change PRs with breaking changes. (Don't delete - used for automation) Elastic Charts labels Apr 12, 2024

nickofthyme requested a review from a team as a code owner April 12, 2024 17:53

chore: add changelog

daf373d

nickofthyme marked this pull request as draft April 12, 2024 18:00

nickofthyme mentioned this pull request Apr 12, 2024

[Meta] Deprecation and Beta schedule #1469

Open

41 tasks

nickofthyme mentioned this pull request Apr 12, 2024

[Meta] Reclaim chart theme from eui elastic/elastic-charts#2069

Closed

5 tasks

Merge branch 'main' into remove-charts-theming

f30a10e

cee-chen reviewed Jun 3, 2024

View reviewed changes

packages/eui/changelogs/upcoming/7682.md Outdated Show resolved Hide resolved

changelog copy tweaks

61c0775

cee-chen marked this pull request as ready for review June 3, 2024 18:09

cee-chen approved these changes Jun 3, 2024

View reviewed changes

cee-chen enabled auto-merge (squash) June 3, 2024 18:11

cee-chen merged commit 37f15d8 into elastic:main Jun 3, 2024

nickofthyme deleted the remove-charts-theming branch June 3, 2024 18:39

tkajtoch mentioned this pull request Jun 11, 2024

Upgrade EUI to v95.0.0 elastic/kibana#185943

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: fully remove deprecated charts theming exports#7682

chore: fully remove deprecated charts theming exports#7682
cee-chen merged 4 commits intoelastic:mainfrom
nickofthyme:remove-charts-theming

nickofthyme commented Apr 12, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 12, 2024 •

edited by cee-chen

Loading

Uh oh!

cee-chen commented Apr 12, 2024

Uh oh!

nickofthyme commented Apr 12, 2024 •

edited

Loading

Uh oh!

Uh oh!

cee-chen left a comment

Uh oh!

kibanamachine commented Jun 3, 2024

Uh oh!

elasticmachine commented Jun 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nickofthyme commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

github-actions bot commented Apr 12, 2024 • edited by cee-chen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cee-chen commented Apr 12, 2024

Uh oh!

nickofthyme commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cee-chen left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 3, 2024

Uh oh!

elasticmachine commented Jun 3, 2024

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nickofthyme commented Apr 12, 2024 •

edited

Loading

github-actions bot commented Apr 12, 2024 •

edited by cee-chen

Loading

nickofthyme commented Apr 12, 2024 •

edited

Loading