Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] DetectionRulesClient: move public methods out and add APM spans #184820

Merged
merged 13 commits into from
Jun 6, 2024
Merged

[Security Solution] DetectionRulesClient: move public methods out and add APM spans #184820

merged 13 commits into from
Jun 6, 2024

Commits on Jun 5, 2024

  1. Add withSecuritySpan to client methods

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2ca4f6d View commit details
    Browse the repository at this point in the history

  2. Move public methods out

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8aed597 View commit details
    Browse the repository at this point in the history

  3. Remove _createRule internal method

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0e15597 View commit details
    Browse the repository at this point in the history

  4. Remove _updateRule internal method

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    98f1d8a View commit details
    Browse the repository at this point in the history

  5. Remove _patchRule internal method

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    96942c2 View commit details
    Browse the repository at this point in the history

  6. Remove _upgradePrebuiltRuleWithTypeChange internal method

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e88d56a View commit details
    Browse the repository at this point in the history

  7. Remove empty options and allowMissingConnectorSecrets from test a… 

    …ssertions
    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8d39096 View commit details
    Browse the repository at this point in the history

  8. Remove underscores from functions in utils.ts, remove unused mocks

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2c4f396 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/main' into detection-rules-cli… 

    …ent-apm-and-refactor
    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    186d455 View commit details
    Browse the repository at this point in the history

  10. Simplify client creation params, use the whole client in tests

    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c085d4b View commit details
    Browse the repository at this point in the history

  11. Rename *.rules_management_client.test.ts -> `*.detection_rules_clie… 

    …nt.test.ts`
    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    cd77b84 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'upstream/main' into detection-rules-cli… 

    …ent-apm-and-refactor
    @nikitaindik
    nikitaindik committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4acf28f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'main' into detection-rules-client-apm-and-refactor

    @nikitaindik
    nikitaindik authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d41def5 View commit details
    Browse the repository at this point in the history