[Security Solution] DetectionRulesClient: move public methods out and add APM spans

[nikitaindik]

Partially addresses: #184364

Summary

This PR is second step in refactoring our newly added detectionRulesClient.

Changes in this PR:

• every public method was extracted into its own file for readability
• _createRule, _updateRule, _patchRule and _upgradePrebuiltRuleWithTypeChange private methods were removed, their code inlined into the public methods
• toggleRuleEnabledOnUpdate, validateMlAuth and ClientError were moved to utils.ts
• methods are now wrapped in withSecuritySpan to report perf stats to APM
• renamed *.rules_management_client.test.ts -> *.detection_rules_client.test.ts
• now using the whole detectionRulesClient in tests, not just separate methods
• simplified parameters of createDetectionRulesClient. Now 2 parameters are needed instead of 5,

DetectionRulesClient method showing up in APM

Extracted methods
Upon reviewing the private methods in detection_rules_client.ts, it became apparent that extracting these methods into separate files may not be the most effective approach to improve readability. The primary reason is that these private methods do not provide clear abstractions, making them difficult to name appropriately.

Take _updateRule as an example. This method combines an existing rule with a rule update to create an InternalRuleUpdate object, which is then passed to rulesClient.update. If we were to extract this into a separate file, we would need to import it for use in the public updateRule method. This would result in an updateRule method that calls _updateRule, creating confusion about what the inner _updateRule does.

Also, extracting only private methods does not significantly improve readability, as these methods do not contain a large amount of code.

So I ended up inlining the code from most of these private methods directly into the public methods.

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[elasticmachine]

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

[nikitaindik]

/ci

[nikitaindik]

/ci

[elasticmachine]

Pinging @elastic/security-detections-response (Team:Detections and Resp)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: d41def5

Metrics [docs]

✅ unchanged

History

• 💔 Build #214215 failed 4acf28f
• 💔 Build #214155 failed 186d455

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nikitaindik

[banderror]

Reviewed the PR together with @nikitaindik over zoom, along with refactoring the client further. We'll open a follow-up one shortly. Thanks Nikita!