Cleanup aiAssistantFlyoutMode feature flag by patrykkopycinski · Pull Request #182992 · elastic/kibana

patrykkopycinski · 2024-05-08T19:50:00Z

Summary

Cleanup Security aiAssistantFlyoutMode feature flag

…-modal-cleanup

patrykkopycinski · 2024-05-08T19:50:06Z

/ci

patrykkopycinski · 2024-05-08T20:11:26Z

/ci

…-modal-cleanup # Conflicts: # x-pack/plugins/security_solution/public/attack_discovery/pages/header/index.tsx

patrykkopycinski · 2024-05-08T20:31:26Z

/ci

patrykkopycinski · 2024-05-10T08:33:01Z

/ci

patrykkopycinski · 2024-05-10T09:24:09Z

/ci

…-fix'

…cinski/kibana into chore/assistant-modal-cleanup

patrykkopycinski · 2024-05-13T15:43:21Z

/ci

…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.tsx

patrykkopycinski · 2024-05-15T20:50:51Z

/ci

…-fix'

patrykkopycinski · 2024-05-16T11:27:55Z

/ci

…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/assistant_header_flyout.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.tsx

patrykkopycinski · 2024-05-16T13:34:38Z

/ci

patrykkopycinski · 2024-05-16T15:28:32Z

/ci

patrykkopycinski · 2024-05-16T18:54:05Z

/ci

…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/assistant_header_flyout.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/index.test.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/conversations/conversation_settings/conversation_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/quick_prompts/quick_prompt_settings/quick_prompt_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/settings/assistant_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/settings/assistant_settings_management.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/types.ts # x-pack/packages/kbn-elastic-assistant/impl/connectorland/connector_selector/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/connectorland/connector_selector_inline/connector_selector_inline.tsx # x-pack/packages/kbn-elastic-assistant/impl/connectorland/connector_setup/index.tsx # x-pack/plugins/security_solution/public/assistant/stack_management/management_settings.tsx

kibana-ci · 2024-07-01T22:48:00Z

💚 Build Succeeded

Buildkite Build
Commit: e8b19fe

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`integrationAssistant`	538	532	-6
`securitySolution`	5582	5575	-7
total			-13

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/elastic-assistant`	139	138	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	15.6MB	15.4MB	-142.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	83.7KB	83.7KB	-33.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/elastic-assistant`	166	165	-1

async chunk count

id	before	after	diff
`securitySolution`	101	99	-2

ESLint disabled in files

id	before	after	diff
`@kbn/elastic-assistant`	2	1	-1

ESLint disabled line counts

id	before	after	diff
`@kbn/elastic-assistant`	17	13	-4
`securitySolution`	551	550	-1
total			-5

Total ESLint disabled count

id	before	after	diff
`@kbn/elastic-assistant`	19	14	-5
`securitySolution`	634	633	-1
total			-6

History

💛 Build #218679 was flaky 0322c3f
💔 Build #218672 failed 48493a7
💔 Build #218665 failed 20c5f15
💚 Build #210712 succeeded 6bca407
💔 Build #210674 failed e97496f
💔 Build #210603 failed 820e01a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

stephmilovic

LGTM! Thanks for the cleanup

…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/assistant_header_flyout.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.test.tsx

…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/assistant_header_flyout.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/index.test.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/assistant_header/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/index.test.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/system_prompt/helpers.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/system_prompt/index.test.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/system_prompt/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/system_prompt/select_system_prompt/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/quick_prompts/quick_prompts.test.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/quick_prompts/quick_prompts.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/types.ts

…-fix'

…cinski/kibana into chore/assistant-modal-cleanup

…-fix'

…cinski/kibana into chore/assistant-modal-cleanup

elasticmachine · 2024-07-08T10:17:14Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: 7757c8a

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #21 / Alerting alerts_as_data install alerts as data resources should install common alerts as data resources on startup

History

cc @patrykkopycinski

## Summary Cleanup Security `aiAssistantFlyoutMode` feature flag --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 27ccd4d)

kibanamachine · 2024-07-09T13:02:53Z

💚 All backports created successfully

Status	Branch	Result
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-07-10T21:48:55Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

# Backport This will backport the following commits from `main` to `8.15`: - [Cleanup aiAssistantFlyoutMode feature flag (#182992)](#182992)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com> Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>

patrykkopycinski added 2 commits May 8, 2024 21:46

Cleanup aiAssistantFlyoutMode feature flag

f7c29bf

Merge branch 'main' of github.com:elastic/kibana into chore/assistant…

e3c6148

…-modal-cleanup

fix

7015e04

patrykkopycinski added 2 commits May 8, 2024 22:27

fix

e115338

Merge branch 'main' of github.com:elastic/kibana into chore/assistant…

726e044

…-modal-cleanup # Conflicts: # x-pack/plugins/security_solution/public/attack_discovery/pages/header/index.tsx

patrykkopycinski changed the title ~~Chore/assistant modal cleanup~~ Cleanup aiAssistantFlyoutMode feature flag May 9, 2024

cleanup

35cbe61

fix

53da06a

kibanamachine and others added 3 commits May 10, 2024 10:18

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

eb58aee

…-fix'

fix

544554f

Merge branch 'chore/assistant-modal-cleanup' of github.com:patrykkopy…

0f60f57

…cinski/kibana into chore/assistant-modal-cleanup

patrykkopycinski added 3 commits May 14, 2024 20:45

Merge branch 'main' into chore/assistant-modal-cleanup

1f284ed

merge

1f78213

Merge branch 'main' of github.com:elastic/kibana into chore/assistant…

c180b5b

…-modal-cleanup # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/index.tsx

kibanamachine and others added 2 commits May 15, 2024 21:35

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

36480a8

…-fix'

fix

8a9ef8c

fix

dfbce5f

types

d355cab

patrykkopycinski added 4 commits June 30, 2024 22:43

fix

48493a7

fix

0322c3f

Merge branch 'main' into chore/assistant-modal-cleanup

e8b19fe

stephmilovic approved these changes Jul 2, 2024

View reviewed changes

stephmilovic mentioned this pull request Jul 2, 2024

[Security AI Assistant] Persist prompts #187040

Merged

patrykkopycinski and others added 8 commits July 3, 2024 00:22

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

b6b97f0

…-fix'

cleanup

f81219d

Merge branch 'chore/assistant-modal-cleanup' of github.com:patrykkopy…

4a1d519

…cinski/kibana into chore/assistant-modal-cleanup

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

7036fd7

…-fix'

fix

81d5b19

Merge branch 'chore/assistant-modal-cleanup' of github.com:patrykkopy…

7757c8a

…cinski/kibana into chore/assistant-modal-cleanup

patrykkopycinski added ci:cloud-deploy Create or update a Cloud deployment Team:Security Generative AI Security Generative AI labels Jul 8, 2024

patrykkopycinski removed the ci:cloud-deploy Create or update a Cloud deployment label Jul 9, 2024

patrykkopycinski merged commit 27ccd4d into elastic:main Jul 9, 2024

kibanamachine added the v8.16.0 label Jul 9, 2024

kibanamachine mentioned this pull request Jul 9, 2024

[8.15] Cleanup aiAssistantFlyoutMode feature flag (#182992) #187863

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 10, 2024

kibanamachine mentioned this pull request Jul 17, 2024

[Security Assistant] Clean up AI settings tabs #187705

Merged

1 task

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 17, 2024

Conversation

patrykkopycinski commented May 8, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

patrykkopycinski commented May 8, 2024

Uh oh!

patrykkopycinski commented May 8, 2024

Uh oh!

patrykkopycinski commented May 8, 2024

Uh oh!

patrykkopycinski commented May 10, 2024

Uh oh!

patrykkopycinski commented May 10, 2024

Uh oh!

patrykkopycinski commented May 13, 2024

Uh oh!

patrykkopycinski commented May 15, 2024

Uh oh!

patrykkopycinski commented May 16, 2024

Uh oh!

patrykkopycinski commented May 16, 2024

Uh oh!

patrykkopycinski commented May 16, 2024

Uh oh!

patrykkopycinski commented May 16, 2024

Uh oh!

kibana-ci commented Jul 1, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

Uh oh!

kibanamachine commented Jul 9, 2024

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

patrykkopycinski commented May 8, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Jul 8, 2024 •

edited

Loading