[Security AI Assistant] Persist prompts by YulNaumenko · Pull Request #187040 · elastic/kibana

YulNaumenko · 2024-06-27T01:02:05Z

Moving prompts persistence layer from the local storage to the server side data stream .kibana-elastic-ai-assistant-prompts

…nt-prompt-store # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/conversations/conversation_settings/conversation_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/system_prompt/system_prompt_modal/system_prompt_selector/system_prompt_selector.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_editor/system_prompt/system_prompt_modal/system_prompt_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/quick_prompts/quick_prompt_selector/quick_prompt_selector.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/quick_prompts/quick_prompt_settings/quick_prompt_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/settings/assistant_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/settings/assistant_settings_management.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/settings/use_settings_updater/use_settings_updater.test.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/settings/use_settings_updater/use_settings_updater.tsx # x-pack/packages/kbn-elastic-assistant/impl/assistant/types.ts # x-pack/packages/kbn-elastic-assistant/impl/assistant_context/index.tsx

…-fix'

…umenko/kibana into security-ai-assistant-prompt-store

banderror

Rule Management changes LGTM

semd

data_quality changes LGTM

stephmilovic · 2024-07-02T13:08:43Z

          type: boolean
-        isShared:
-          type: boolean
+        consumer:


should this be enum?

his value will come from the Kibana applications.currentAppId$, which is dynamic and we should be flexible enough to supporting new apps

stephmilovic

Nice work Yuliia, LGTM!!

…umenko/kibana into security-ai-assistant-prompt-store

angorayc · 2024-07-03T09:53:00Z

+      http.fetch(ELASTIC_AI_ASSISTANT_PROMPTS_URL_FIND, {
+        method: 'GET',
+        version: API_VERSIONS.internal.v1,
+        query: QUERY,


The long term goal for prompt settings table would be moving away from the in-memory table and control the pagination. We might want the query to be passed from the payload in the long run. https://github.com/elastic/kibana/pull/186566/files#diff-4e741c819ea07d57f5a686e4a5e024a034ee2e4d16b4775ea3d3501787bb83d6R51

For later, should we add the include the conversations that are using this prompt or update the fetchCurrentConversations function? The current implementation for fetching conversations that using this prompt is actually filtering from all the conversations by their defaultSystemPrompt Id on the client side. This might not be great for performance when there are more and more conversations in the future.

elasticmachine · 2024-07-03T14:24:12Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: 8abfbd8

Failed CI Steps

Test Failures

[job] [logs] Defend Workflows Cypress Tests #11 / Endpoints page should update endpoint policy on Endpoint should update endpoint policy on Endpoint
[job] [logs] Defend Workflows Cypress Tests #20 / Response actions history page retains expanded action details on page reload retains expanded action details on page reload

History

cc @YulNaumenko

…umenko/kibana into security-ai-assistant-prompt-store

[Security AI Assistant] Persist prompts

f80b152

YulNaumenko added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jun 27, 2024

YulNaumenko self-assigned this Jun 27, 2024

spong mentioned this pull request Jun 28, 2024

[Security Solution] AI settings #184678

Merged

3 tasks

YulNaumenko added 3 commits July 1, 2024 10:23

fixed merge

5019292

fixed type checks

492aa25

YulNaumenko marked this pull request as ready for review July 1, 2024 17:44

YulNaumenko requested a review from a team as a code owner July 1, 2024 17:44

spong mentioned this pull request Jul 1, 2024

[Security AI Assistant] Chat complete API #184485

Merged

fixed create new

5ef4eb1

YulNaumenko requested review from a team as code owners July 1, 2024 18:46

YulNaumenko requested a review from jpdjere July 1, 2024 18:46

YulNaumenko and others added 8 commits July 1, 2024 12:36

fixed tests

bb2ce24

fixed tests

3aec593

fixed delete

45c33e8

fixed types

cb8d7fc

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

2c6c32c

…-fix'

fixed prompts update

a71e190

Merge branch 'security-ai-assistant-prompt-store' of github.com:YulNa…

875c129

…umenko/kibana into security-ai-assistant-prompt-store

added default conversations

9ae6ee8

YulNaumenko requested a review from a team July 2, 2024 04:59

banderror approved these changes Jul 2, 2024

View reviewed changes

banderror removed the request for review from jpdjere July 2, 2024 09:05

semd approved these changes Jul 2, 2024

View reviewed changes

fixed unused labels

883d9a9

stephmilovic reviewed Jul 2, 2024

View reviewed changes

Comment thread x-pack/packages/kbn-elastic-assistant/impl/assistant/api/prompts/use_fetch_prompts.ts Outdated

stephmilovic reviewed Jul 2, 2024

View reviewed changes

Comment thread x-pack/plugins/security_solution/public/assistant/provider.tsx

stephmilovic reviewed Jul 2, 2024

View reviewed changes

Comment thread x-pack/packages/kbn-elastic-assistant/impl/assistant/api/prompts/use_fetch_prompts.ts Outdated

stephmilovic reviewed Jul 2, 2024

View reviewed changes

Comment thread x-pack/plugins/security_solution/public/assistant/provider.tsx Outdated

stephmilovic reviewed Jul 2, 2024

View reviewed changes

Comment thread x-pack/packages/kbn-elastic-assistant/impl/assistant/api/prompts/use_fetch_prompts.ts

YulNaumenko added 4 commits July 2, 2024 09:12

fixed update on save

a2a7fb6

fixed delete

e43b4d5

fixed due to comments

17d7d81

-

81534c6

stephmilovic reviewed Jul 2, 2024

View reviewed changes

Comment thread ...ssistant/impl/assistant/conversations/conversation_settings/conversation_settings_editor.tsx

YulNaumenko added 2 commits July 2, 2024 10:55

fixed tests

4c993d8

fixed default prompt

09c97f0

stephmilovic approved these changes Jul 2, 2024

View reviewed changes

Merge branch 'main' into security-ai-assistant-prompt-store

23b1b85

YulNaumenko enabled auto-merge (squash) July 2, 2024 21:28

YulNaumenko and others added 6 commits July 2, 2024 17:01

fixed test and stack management page

75af95f

Merge branch 'security-ai-assistant-prompt-store' of github.com:YulNa…

750d30f

…umenko/kibana into security-ai-assistant-prompt-store

fixed test

e26b0c5

Merge branch 'main' into security-ai-assistant-prompt-store

a282e2d

Merge branch 'main' into security-ai-assistant-prompt-store

9be7b85

Merge branch 'main' into security-ai-assistant-prompt-store

d3cdac3

angorayc reviewed Jul 3, 2024

View reviewed changes

YulNaumenko added 2 commits July 3, 2024 05:52

Merge branch 'main' into security-ai-assistant-prompt-store

8af1bc3

Merge branch 'main' into security-ai-assistant-prompt-store

8abfbd8

patrykkopycinski and others added 3 commits July 3, 2024 16:42

fix Error fetching prompts toast

e87383e

Merge branch 'security-ai-assistant-prompt-store' of github.com:YulNa…

3f700ad

…umenko/kibana into security-ai-assistant-prompt-store

added license check

05d97d4

YulNaumenko merged commit 0a0bb14 into elastic:main Jul 3, 2024

kibanamachine added the backport:skip This PR does not require backporting label Jul 3, 2024

peluja1012 mentioned this pull request Jul 30, 2024

[Request] Document behavior of AI Assistant prompts upon upgrade to 8.15 elastic/security-docs#5623

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security AI Assistant] Persist prompts#187040

[Security AI Assistant] Persist prompts#187040
YulNaumenko merged 32 commits intoelastic:mainfrom
YulNaumenko:security-ai-assistant-prompt-store

YulNaumenko commented Jun 27, 2024 •

edited

Loading

Uh oh!

banderror left a comment

Uh oh!

semd left a comment

Uh oh!

stephmilovic Jul 2, 2024

Uh oh!

YulNaumenko Jul 2, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephmilovic left a comment

Uh oh!

angorayc Jul 3, 2024 •

edited

Loading

Uh oh!

elasticmachine commented Jul 3, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

YulNaumenko commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

banderror left a comment

Choose a reason for hiding this comment

Uh oh!

semd left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

YulNaumenko Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

angorayc Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

YulNaumenko commented Jun 27, 2024 •

edited

Loading

angorayc Jul 3, 2024 •

edited

Loading

elasticmachine commented Jul 3, 2024 •

edited

Loading