Skip to content

Add resolutions for protobufjs#182424

Merged
legrego merged 2 commits intoelastic:mainfrom
legrego:resolve-protobufjs
May 3, 2024
Merged

Add resolutions for protobufjs#182424
legrego merged 2 commits intoelastic:mainfrom
legrego:resolve-protobufjs

Conversation

@legrego
Copy link
Member

@legrego legrego commented May 2, 2024

Summary

Forces a resolution of protobufjs for @bazel/typescript, which cannot be upgraded at this time due to performance issues (#130347).

[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "protobufjs@6.11.4"
info Reasons this module exists
   - "@bazel#typescript" depends on it
   - Hoisted from "@bazel#typescript#protobufjs"
info Disk size without dependencies: "21.65MB"
info Disk size with unique dependencies: "26.22MB"
info Disk size with transitive dependencies: "26.39MB"
info Number of shared dependencies: 13
=> Found "@grpc/proto-loader#protobufjs@7.2.5"
info This module exists because "@grpc#grpc-js#@grpc#proto-loader" depends on it.
info Disk size without dependencies: "3.02MB"
info Disk size with unique dependencies: "7.57MB"
info Disk size with transitive dependencies: "7.73MB"
info Number of shared dependencies: 12

cc @elastic/kibana-operations for awareness

@legrego
Copy link
Member Author

legrego commented May 2, 2024

/ci

@legrego legrego added chore Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels May 2, 2024
@legrego
Copy link
Member Author

legrego commented May 2, 2024

/ci

@legrego legrego marked this pull request as ready for review May 2, 2024 18:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #79 / transform - creation - index pattern "after all" hook in "transform - creation - index pattern"
  • [job] [logs] FTR Configs #79 / transform - creation - index pattern creation_continuous_transform "after all" hook: afterTestSuite.trigger in "creation_continuous_transform"
  • [job] [logs] FTR Configs #79 / transform - creation - index pattern creation_continuous_transform continuous with the latest function "after all" hook: afterTestSuite.trigger for "resets and starts previously stopped transform"
  • [job] [logs] FTR Configs #79 / transform - creation - index pattern creation_continuous_transform continuous with the latest function navigates through the wizard and sets all needed fields

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@legrego legrego merged commit de75523 into elastic:main May 3, 2024
@legrego legrego deleted the resolve-protobufjs branch July 25, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants