Skip to content

chore(NA): downgrades rules nodejs into v4.7.0#130347

Merged
mistic merged 5 commits intoelastic:mainfrom
mistic:downgrade-rules-nodejs-into-v4.0.0
Apr 15, 2022
Merged

chore(NA): downgrades rules nodejs into v4.7.0#130347
mistic merged 5 commits intoelastic:mainfrom
mistic:downgrade-rules-nodejs-into-v4.0.0

Conversation

@mistic
Copy link
Contributor

@mistic mistic commented Apr 14, 2022

This PR reverts what was done at #129522 , #130051 and #130214 as we found a major performance decreasing when building without no cache.

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, yarn kbn reset && yarn kbn bootstrap with a populated remote cache took 64 seconds.

info [bazel] INFO: Elapsed time: 64.299s, Critical Path: 8.51s
info [bazel] INFO: 945 processes: 658 remote cache hit, 280 internal, 7 darwin-sandbox.
info [bazel] INFO: Streaming build results to: https://app.buildbuddy.io/invocation/a5358f3e-22ff-492e-9f79-4bb33c1ae960

image

60mb downloaded, pretty reasonable (a couple cache misses on ARM macs are expected, but not causing any issues right now).

@mistic mistic added chore release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.2.1 Team:Operations Kibana-Operations Team labels Apr 14, 2022
@mistic mistic marked this pull request as ready for review April 14, 2022 23:29
@mistic mistic requested a review from a team as a code owner April 14, 2022 23:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Contributor Author

mistic commented Apr 14, 2022

Thanks for the the performance checks @spalger . @jbudz is testing this on Windows and after it we can merge it.

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM. Uncached reset took 15 minutes and 35 seconds. I'm thinking it's probably worth adding cache hits to CI metrics to unskew bootstrap times.

@mistic mistic merged commit 0b2da10 into elastic:main Apr 15, 2022
kibanamachine pushed a commit that referenced this pull request Apr 15, 2022
* chore(NA): downgrade rules nodejs into v4.0.0

* chore(NA): include windows patch

* chore(NA): polish downgrade code

* chore(NA): include yarn.lock

(cherry picked from commit 0b2da10)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 15, 2022
* chore(NA): downgrade rules nodejs into v4.0.0

* chore(NA): include windows patch

* chore(NA): polish downgrade code

* chore(NA): include yarn.lock

(cherry picked from commit 0b2da10)

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
@legrego
Copy link
Member

legrego commented May 2, 2024

For awareness, we've had to add a resolution to our package.json to force @bazel/typescript to use a newer version of protobufjs (#182424). We should remove this resolution once we're able to upgrade (or remove?) this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.2.1 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants